tag, just like building a block on the page. However, many modules call drupal_add_css or drupal_add_js which ultimately gets added to the page when it's rendered. I think email generation should have the same ability to include CSS files (which should go in the tag, not a

) I notice that mimemail does in fact get the CSS files from drupal and the current theme (in the absence of a mail.css file) so you can simply call drupal_add_cs() from a theme function that generates email.... just confusing if you're generating an email, and then a resulting page at the same time..... -Matt On 16/07/2008, at 10:46 AM, Nathaniel Catchpole wrote: > There's a patch here that's not had much attention for over a year > but would provide better support in core: http://drupal.org/node/28604 > > You should also look at http://drupal.org/project/mimemail > > Nat > > On Wed, Jul 16, 2008 at 10:22 AM, Omar Abdel-Wahab wrote: > +1 > > I strongly would love to have D7 send HTML e-mails. > > At least 20 modules will benefit from this step. > > Omar > > > Matt Connolly wrote: > I haven't looked at drupal 7 yet, so I'm throwing this out there for > discussion. > > The D6 mail api seems like it's pretty much designed for plain text > emails, however, a module's implementation of hook_mail can clearly > set the headers of the mail to "Content-Type: text/html; > charset=utf-8" and send rich text. > > For example, I'm looking at using "forward" module for the "email > this page" link on a node, and the "simplenews" module, which uses > "mimemail" to send rich emails, including attachments. Both > "forward" and "mimemail" modules create a html header. > > The problem occurs when a module implements "drupal_mail_wrapper()" > to build a html header when hook_mail has already done that - you > can easily end up with bodies like: > > > ... > > ... etc. > > > Because there are two opportunities to create the html "head" for > the message: in hook_mail and drupal_mail_wrapper. > > I'm throwing this out there for discussion, I think that the > hook_mail should construct the message in a similar fashion to the > Form API, specifying a theme for rendering the body part of the > message (ie what goes in the tag) and anything special that > needs to go in the head as attributes. > > That way the message can be constructed only once. > > Besides, email clients have been HTML friendly for a *long* time, so > I don't see why Drupal shouldn't have an interface that understands > rich email messages. > > Thoughts? > > > Matt > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080716/4ae107de/attachment.htm From enboig at gmail.com Wed Jul 16 11:15:19 2008 From: enboig at gmail.com (=?ISO-8859-1?Q?Llu=EDs?=) Date: Wed, 16 Jul 2008 13:15:19 +0200 Subject: [development] HTML emails In-Reply-To: References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <487DBDE9.3030808@owahab.com>

Message-ID: <45a29f450807160415o35fa554bh92d3e650d65f7f0c@mail.gmail.com> A problem with HTML mails and CSS is that they don't render the same in all mail clients. I have searched a way to convert CSS page into pure HTML (without CSS) before sending it, but I didn't found any way to do so. Maybe something like http://wiki.tcl.tk/12383 but for PHP would make sent mails look better. On Wed, Jul 16, 2008 at 12:32 PM, Matt Connolly wrote: > Yes, I am trying to use "mimemail", just ported the code to Drupal 6 > yesterday. > The problem is that other modules that don't use mimemail duplicate some of > its functionality, which makes sense when the module is not present. > At the moment, I'm manually re-theming the other modules to not create > "" stuff to play nice with mimemail. > Ideally, though, you could set html head elements in an array in a similar > fashion to for FORM API so that mimemail (or any HTML aware drupal mail > module) could interpret and include in the constructed email message in the > correct place. ie: returning a structured array instead of a flat string. > Although this may be contrary to how theme functions work... > > > It makes sense to me that modules should only create the content that goes > in a

tag, just like building a block on the page. However, many > modules call drupal_add_css or drupal_add_js which ultimately gets added to > the page when it's rendered. I think email generation should have the same > ability to include CSS files (which should go in the tag, not a >

) > I notice that mimemail does in fact get the CSS files from drupal and the > current theme (in the absence of a mail.css file) so you can simply call > drupal_add_cs() from a theme function that generates email.... just > confusing if you're generating an email, and then a resulting page at the > same time..... > > -Matt > > On 16/07/2008, at 10:46 AM, Nathaniel Catchpole wrote: > > There's a patch here that's not had much attention for over a year but would > provide better support in core: http://drupal.org/node/28604 > > You should also look at http://drupal.org/project/mimemail > > Nat > > On Wed, Jul 16, 2008 at 10:22 AM, Omar Abdel-Wahab wrote: >> >> +1 >> >> I strongly would love to have D7 send HTML e-mails. >> >> At least 20 modules will benefit from this step. >> >> Omar >> >> Matt Connolly wrote: >>> >>> I haven't looked at drupal 7 yet, so I'm throwing this out there for >>> discussion. >>> >>> The D6 mail api seems like it's pretty much designed for plain text >>> emails, however, a module's implementation of hook_mail can clearly set the >>> headers of the mail to "Content-Type: text/html; charset=utf-8" and send >>> rich text. >>> >>> For example, I'm looking at using "forward" module for the "email this >>> page" link on a node, and the "simplenews" module, which uses "mimemail" to >>> send rich emails, including attachments. Both "forward" and "mimemail" >>> modules create a html header. >>> >>> The problem occurs when a module implements "drupal_mail_wrapper()" to >>> build a html header when hook_mail has already done that - you can easily >>> end up with bodies like: >>> >>> >> >>> ... >>> >> >> >>> ... etc. >>> >>> >>> Because there are two opportunities to create the html "head" for the >>> message: in hook_mail and drupal_mail_wrapper. >>> >>> I'm throwing this out there for discussion, I think that the hook_mail >>> should construct the message in a similar fashion to the Form API, >>> specifying a theme for rendering the body part of the message (ie what goes >>> in the tag) and anything special that needs to go in the head as >>> attributes. >>> >>> That way the message can be constructed only once. >>> >>> Besides, email clients have been HTML friendly for a *long* time, so I >>> don't see why Drupal shouldn't have an interface that understands rich email >>> messages. >>> >>> Thoughts? >>> >>> >>> Matt >>> >>> > > > -- *La vida ?s com una moneda, la pots gastar en el que vulguis per? nom?s una vegada. *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les il?lusions. *Als llocs desconeguts nom?s s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient. From earnie at users.sourceforge.net Wed Jul 16 11:25:07 2008 From: earnie at users.sourceforge.net (Earnie Boyd) Date: Wed, 16 Jul 2008 07:25:07 -0400 Subject: [development] New Developer - for Tamil from Tamil Nadu-India In-Reply-To: <6176a14d0807160240vf791442gc2a42056be18411c@mail.gmail.com> References: <6176a14d0807160240vf791442gc2a42056be18411c@mail.gmail.com> Message-ID: <20080716072507.pc1snnquhny88c4c@mail.progw.org> Quoting vin vin <4vinoth at gmail.com>: > Hi Everyone > > I am Vinoth, New joiner. Please let me know if any one from TamilNadu or for > Tamil Development in the Great group. > Did you look here http://qroups.drupal.org? Earnie -- http://for-my-kids.com/ -- http://give-me-an-offer.com/ From aron at novaak.net Wed Jul 16 13:19:01 2008 From: aron at novaak.net (=?utf-8?q?Nov=C3=A1k_=C3=81ron?=) Date: Wed, 16 Jul 2008 15:19:01 +0200 Subject: [development] GSoC Aggregator patch Message-ID: <200807161519.01754.aron@novaak.net> I rolled out the patch against HEAD aggregator: http://drupal.org/node/236237#comment-923418 I would like to ask everyone interested in aggregation topic: please review it and tell your opinion. Important to know: It will definitely break your tests because the new tests are still under construction and the old ones are not suitable for the modified module. More verbose explanation and instructions can be found at the linked d.o. ticket. If you'd like to see my plans for testing and more: http://drupal.org/node/282570 Thanks, Aron Novak From larry at garfieldtech.com Wed Jul 16 14:47:25 2008 From: larry at garfieldtech.com (Larry Garfield) Date: Wed, 16 Jul 2008 9:47:25 -0500 Subject: [development] =?utf-8?q?gotcha=3A_menu_wildcards=2Cforeach=28=29_?= =?utf-8?q?and_MENU=5FSUGGESTED=5FITEM?= In-Reply-To: <200807161415.05608.drupal.beginner@wechange.org> References: <200807161415.05608.drupal.beginner@wechange.org> Message-ID: <51640e370de36e2eadea19c52cdca034@localhost> On Wed, 16 Jul 2008 14:15:05 +0800, "augustin (beginner)" wrote: > > Hi again, > > On the issue, crell write: > > " A foreach loop inside a D6 menu handler is 99% of the time the WRONG way > to > do it." > http://drupal.org/node/283198 > > Have I stumbled upon the 1% of cases where it's the right thing to do? > If you agree with crell and if I am wrong, I certainly would like to know > it, > and I'll revert the documentation changes I made. > > What is the proper way to have MENU_SUGGESTED_ITEM with wildcards and > without > a loop? > See the issue for code examples. > > > Thanks, > > Augustin. I will defer to chx and pwolanin on this front. I am by and large quoting chx here, who said something very similar to me back in February. I won't say you have definitely not found that 1%, but the whole point of all the fancy math in the menu system is to not have to loop but to simply declare matchable patterns. Looping should be very strongly discouraged. --Larry Garfield From larry at garfieldtech.com Wed Jul 16 14:59:01 2008 From: larry at garfieldtech.com (Larry Garfield) Date: Wed, 16 Jul 2008 9:59:01 -0500 Subject: [development] HTML emails In-Reply-To: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> Message-ID: <2af50bac682c41897554f33ee5e8324a@localhost> On Wed, 16 Jul 2008 10:12:33 +0100, Matt Connolly wrote: > Besides, email clients have been HTML friendly for a *long* time, so I > don't see why Drupal shouldn't have an interface that understands rich > email messages. > > Thoughts? > > > Matt I am going to take the luddite position. Consider yourself warned. :-) HTML email is not, as far as I am aware, an actual standard. It is a de facto convention for a hack of the SMTP protocol using a tool that was never built for it. It also breaks nearly every convention of email usage (at least as far as replies are involved), and wastes gobs and gobs of bandwidth, especially for the increasing number of people on mobile devices. It serves no purpose except to send spam (both legit and not, I am going to call all marketing emails spam even if they are solicited as a debate tactic), which means it is filtered out by mail servers more frequently. They are also a wonderful attack vector for viruses and trojans. As a result, many many email clients don't render HTML email by default, showing a blob of unrecognizable HTML instead. Some moronic mail senders send out HTML emails that have no plaintext version, which makes them unreadable to many people (who do not, in fact, accept HTML email). As others have mentioned, support for anything pos t-HTML 3.2 in email varies widely, and you can't exactly do client targeting over email. Why should we encourage that? As far as I'm concerned, we shouldn't. That said, there may well be advantages to switching to drupal_render() for email messages. I am in general a big fan of structured data remaining structured for as long as possible. The benefit, however, would not be for HTML mail but for, say, easier email attachments. That such a move would make it easier to send HTML email as well, well, that's a side effect I suppose we can live with. --Larry Garfield From darrel.opry at gmail.com Wed Jul 16 16:06:38 2008 From: darrel.opry at gmail.com (Darrel O'Pry) Date: Wed, 16 Jul 2008 12:06:38 -0400 Subject: [development] HTML emails In-Reply-To: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> Message-ID: On Wed, Jul 16, 2008 at 5:12 AM, Matt Connolly wrote: > > Besides, email clients have been HTML friendly for a *long* time, so I > don't see why Drupal shouldn't have an interface that understands rich email > messages. > > Thoughts? > Have you even tried to make an HTML email look the same in multiple email clients? That stuff is impossible... and forget it if you want colored anchors or css support consistently. Heck they don't even send mime attachments consistently... They all do something close to spec... and lets not even get into the quirks of various webmail clients and the pluthera of different versions of MS Outlook in the wild and still supported by MS. You basically have a minimum of 8 different applications that handle HTML slightly differently. There are also major variations per version... If you thought cross browser support was annoying you haven't seen anything yet... apple: mac mail windows: outlook 8 -> present, including express variations. // each outlook seems to use a different combination renderer and mime library. linux: evolution cross platform: eudora mac, eudora pc, thunderbird web: gmail, windows live/hotmail, yahoo but using drupal_render ++ .darrel. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080716/74dbcb71/attachment.htm From development at robuustdesign.nl Wed Jul 16 16:44:35 2008 From: development at robuustdesign.nl (Stefan Nagtegaal) Date: Wed, 16 Jul 2008 18:44:35 +0200 Subject: [development] HTML emails In-Reply-To: References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> Message-ID: <4622D560-2B29-4A19-AAE6-7810611FFCD1@robuustdesign.nl> Op 16 jul 2008, om 18:06 heeft Darrel O'Pry het volgende geschreven: > On Wed, Jul 16, 2008 at 5:12 AM, Matt Connolly > wrote: > > Besides, email clients have been HTML friendly for a *long* time, so > I don't see why Drupal shouldn't have an interface that understands > rich email messages. > > Thoughts? > > Have you even tried to make an HTML email look the same in multiple > email clients? That stuff is impossible... and forget it if you > want colored anchors or css support consistently. Heck they don't > even send mime attachments consistently... They all do something > close to spec... and lets not even get into the quirks of various > webmail clients and the pluthera of different versions of MS Outlook > in the wild and still supported by MS. It isn't impossible! Just use CSS and make sure you have a wrapper div around your HTML- layout, styled with the CSS. The only thing that breaks your e-mails along the different e-mail clients is when you add styling to the ... of your HTML e- mail. Stefan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080716/477b6614/attachment.htm From mail at webthatworks.it Wed Jul 16 16:54:51 2008 From: mail at webthatworks.it (Ivan Sergio Borgonovo) Date: Wed, 16 Jul 2008 18:54:51 +0200 Subject: [development] HTML emails In-Reply-To: <2af50bac682c41897554f33ee5e8324a@localhost> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> Message-ID: <20080716185451.5c419f3a@dawn.webthatworks.it> On Wed, 16 Jul 2008 9:59:01 -0500 Larry Garfield wrote: > That said, there may well be advantages to switching to > drupal_render() for email messages. I am in general a big fan of > structured data remaining structured for as long as possible. The I really really would like to avoid HTML emails and I agree with most of your points and they are enough to hate html emails. Anyway it is a very frequently requested feature. I know consistency of rendering of HTML is a hell... but it is still a very frequent request we have to live with. We have a rendering engine that is specialised to render HTML. Even if mobile devices are getting more and more popular, they are getting more and more able to render html as it is. Template system makes much easier to delegate design tasks to non programmers compared to XLS/XML/whatever and building up a more flexible rendering engine may take a long time... why not just provide a way to build up structured emails (attachment, auto inclusion of CSS etc...) and something that just do html2text? BTW I didn't find html2text up to the task. w3m provided the best results in the tools I've used... but there is no w3m library that I know that can be easily integrated in php. Rewriting a text browser in php doesn't look to be easy. -- Ivan Sergio Borgonovo http://www.webthatworks.it From eric.schaefer at eas-consulting.de Wed Jul 16 17:41:58 2008 From: eric.schaefer at eas-consulting.de (Eric-Alexander Schaefer) Date: Wed, 16 Jul 2008 19:41:58 +0200 Subject: [development] HTML emails In-Reply-To: <2af50bac682c41897554f33ee5e8324a@localhost> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> Message-ID: <487E32E6.9090903@eas-consulting.de> Larry Garfield schrieb: > I am going to take the luddite position. Consider yourself warned. :-) Thanks (for your position, not the warning). Plaintext should be the default and HTML _could_ be an option. If HTML is used, it should contain a plaintext version. Eric From allie at pajunas.com Wed Jul 16 18:24:02 2008 From: allie at pajunas.com (Allie Micka) Date: Wed, 16 Jul 2008 13:24:02 -0500 Subject: [development] HTML emails In-Reply-To: References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <487DBDE9.3030808@owahab.com>

Message-ID: <0EF24D1A-DA36-49BB-AB32-714318396306@pajunas.com> On Jul 16, 2008, at 5:32 AM, Matt Connolly wrote: > At the moment, I'm manually re-theming the other modules to not > create "" stuff to play nice with mimemail. If there's a generalizeable way to do this, I'd be a huge fan of its implementation. Please see http://drupal.org/node/ 121849#comment-915935 for a description of how messages are themed and how to override them. The goal here was to have something that looks consistent without creating a giant themeing task for admins and users; and without any knowledge or assumptions of how a site is themed. By default, Mime Mail includes copies of your CSS information inside of your message's section. In many cases this looks pretty great, but it can lead to some darn large messages. Also, as indicated here, several mail clients don't read the CSS information in the head section. Mostly, this just means gmail and hotmail - see http://www.campaignmonitor.com/css/ It would be super-awesome if someone could help this module - for everyone - by a) attempting to reduce the overall size of included CSS content and b) attempt to migrate some element and style definitions into the body of the message to combat the "gmail problem" Thanks, Allie Micka Advantage Labs, Inc. From allie at pajunas.com Wed Jul 16 18:31:09 2008 From: allie at pajunas.com (Allie Micka) Date: Wed, 16 Jul 2008 13:31:09 -0500 Subject: [development] HTML emails In-Reply-To: <2af50bac682c41897554f33ee5e8324a@localhost> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> Message-ID: <3701E219-5398-466C-BC39-06B33B6A293A@pajunas.com> > That said, there may well be advantages to switching to > drupal_render() for email messages. +1 Also, I think it's more than appropriate to keep HTML-formatting and Mime machinations out of core. However, Drupal can't go around assuming that messages *won't* be HTML until it's ready to send them out, and then do its html-to-text conversion then. Thanks! Allie Micka Advantage Labs, Inc. From ben.lewis at benl.co.uk Wed Jul 16 21:26:38 2008 From: ben.lewis at benl.co.uk (Benjamin Lewis) Date: Wed, 16 Jul 2008 22:26:38 +0100 Subject: [development] HTML emails In-Reply-To: <487E32E6.9090903@eas-consulting.de> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> <487E32E6.9090903@eas-consulting.de> Message-ID: <487E678E.7050800@benl.co.uk> Eric-Alexander Schaefer wrote: > Larry Garfield schrieb: >> I am going to take the luddite position. Consider yourself warned. :-) > > Thanks (for your position, not the warning). > Plaintext should be the default and HTML _could_ be an option. If HTML > is used, it should contain a plaintext version. It MUST contain a plaintext version (per RFC 2119 [1]) [1] http://tools.ietf.org/html/rfc2119 > > Eric -- Benjamin Lewis Fedora Ambassador ben.lewis at benl.co.uk ----------------------------------------------------------------------- http://benl.co.uk./ PGP Key: 0x647E480C "In cases of major discrepancy, it is always reality that got it wrong" -- RFC 1118 -------------- next part -------------- A non-text attachment was scrubbed... Name: ben_lewis.vcf Type: text/x-vcard Size: 206 bytes Desc: not available Url : http://lists.drupal.org/pipermail/development/attachments/20080716/132782be/attachment.vcf -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 897 bytes Desc: OpenPGP digital signature Url : http://lists.drupal.org/pipermail/development/attachments/20080716/132782be/attachment.pgp From larry at garfieldtech.com Thu Jul 17 01:59:29 2008 From: larry at garfieldtech.com (Larry Garfield) Date: Wed, 16 Jul 2008 20:59:29 -0500 Subject: [development] HTML emails In-Reply-To: <487E678E.7050800@benl.co.uk> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <487E32E6.9090903@eas-consulting.de> <487E678E.7050800@benl.co.uk> Message-ID: <200807162059.29306.larry@garfieldtech.com> On Wednesday 16 July 2008 4:26:38 pm Benjamin Lewis wrote: > Eric-Alexander Schaefer wrote: > > Larry Garfield schrieb: > >> I am going to take the luddite position. Consider yourself warned. :-) > > > > Thanks (for your position, not the warning). > > Plaintext should be the default and HTML _could_ be an option. If HTML > > is used, it should contain a plaintext version. > > It MUST contain a plaintext version (per RFC 2119 [1]) > > [1] http://tools.ietf.org/html/rfc2119 You're making the naive assumption that people actually follow that requirement. :-) LOTS of email floating about the Net, both legit and spam/trojans, contains HTML and no body. And sending the message twice (plain and HTML) is a slap in the face to anyone on low bandwidth. drupal_render() for mail does have potential advantages. That it may make it easier for *contribs* to send HTML email is a downside I am willing to accept. -- Larry Garfield larry at garfieldtech.com From owahab at owahab.com Thu Jul 17 02:49:16 2008 From: owahab at owahab.com (Omar Abdel-Wahab) Date: Thu, 17 Jul 2008 05:49:16 +0300 Subject: [development] HTML emails In-Reply-To: <200807162059.29306.larry@garfieldtech.com> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <487E32E6.9090903@eas-consulting.de> <487E678E.7050800@benl.co.uk> <200807162059.29306.larry@garfieldtech.com> Message-ID: <487EB32C.6080307@owahab.com> I'd go for allowing users to choose the e-mail format they prefer to receive in their account screen. Omar Larry Garfield wrote: > On Wednesday 16 July 2008 4:26:38 pm Benjamin Lewis wrote: >> Eric-Alexander Schaefer wrote: >>> Larry Garfield schrieb: >>>> I am going to take the luddite position. Consider yourself warned. :-) >>> Thanks (for your position, not the warning). >>> Plaintext should be the default and HTML _could_ be an option. If HTML >>> is used, it should contain a plaintext version. >> It MUST contain a plaintext version (per RFC 2119 [1]) >> >> [1] http://tools.ietf.org/html/rfc2119 > > You're making the naive assumption that people actually follow that > requirement. :-) LOTS of email floating about the Net, both legit and > spam/trojans, contains HTML and no body. And sending the message twice > (plain and HTML) is a slap in the face to anyone on low bandwidth. > > drupal_render() for mail does have potential advantages. That it may make it > easier for *contribs* to send HTML email is a downside I am willing to > accept. > From karoly at negyesi.net Thu Jul 17 04:02:08 2008 From: karoly at negyesi.net (Karoly Negyesi) Date: Thu, 17 Jul 2008 06:02:08 +0200 (CEST) Subject: [development] gotcha: menu wildcards, foreach() and MENU_SUGGESTED_ITEM In-Reply-To: <200807161146.20332.drupal.beginner@wechange.org> References: <200807161146.20332.drupal.beginner@wechange.org> Message-ID: > In most cases, you DO want to remove the foreach() loop you had in D5. there, I fixed for you :) > Within D6, it is ALMOST NEVER NEEDED TO HAVE a loop, recursively declaring several > well defined menu items, e.g. one item for each vocabulary. When you have > such a loop, DO use the wildcard loader. there, I fixed for you :) You forgot about the distinction of router items and menu links. You will want to use a single router item and save several links with menu_link_save as you see fit. Regards Karoly Negyesi From drupal.beginner at wechange.org Thu Jul 17 04:28:41 2008 From: drupal.beginner at wechange.org (augustin (beginner)) Date: Thu, 17 Jul 2008 12:28:41 +0800 Subject: [development] gotcha: menu wildcards, foreach() and MENU_SUGGESTED_ITEM In-Reply-To: References: <200807161146.20332.drupal.beginner@wechange.org> Message-ID: <200807171228.41913.drupal.beginner@wechange.org> On Thursday 17 July 2008 12:02:08 Karoly Negyesi wrote: > You forgot about the distinction of router items and menu links. You will > want to use a single router item and save several links with menu_link_save > as you see fit. Ah, yes! Not knowing too much about the internals, I was looking at it from the perspective of a module developer and what was possible using hook_menu() only. Thank you very much for your feedback. I have updated the issue with a copy of your comment: http://drupal.org/node/283198 And since this problem is not particularly obvious, I have updated my handbook edits to correspond to the sanctioned solution: http://drupal.org/node/103114 http://drupal.org/node/109153 Thanks again to Larry and Karoly for their comments. Blessings, Augustin. P.S. to Larry: I guess I *still* need my beginner handle for a while longer, after all... ;) From pwolanin at gmail.com Thu Jul 17 15:38:12 2008 From: pwolanin at gmail.com (Peter Wolanin) Date: Thu, 17 Jul 2008 11:38:12 -0400 Subject: [development] gotcha: menu wildcards, foreach() and MENU_SUGGESTED_ITEM In-Reply-To: <200807171228.41913.drupal.beginner@wechange.org> References: <200807161146.20332.drupal.beginner@wechange.org> <200807171228.41913.drupal.beginner@wechange.org> Message-ID: <2247a8a70807170838o6d7adf17i6156244c4b2630cf@mail.gmail.com> Menu module is one example in core where several links are created and added to the navigation menu. For some things like node types, we probably could have done the same (rather than using a foreach) but we had also hit the "don't fix it if it works" phase of the core cycle. -Peter On Thu, Jul 17, 2008 at 12:28 AM, augustin (beginner) wrote: > On Thursday 17 July 2008 12:02:08 Karoly Negyesi wrote: >> You forgot about the distinction of router items and menu links. You will >> want to use a single router item and save several links with menu_link_save >> as you see fit. > > Ah, yes! > Not knowing too much about the internals, I was looking at it from the > perspective of a module developer and what was possible using hook_menu() > only. > > Thank you very much for your feedback. > > I have updated the issue with a copy of your comment: > http://drupal.org/node/283198 > > And since this problem is not particularly obvious, I have updated my handbook > edits to correspond to the sanctioned solution: > http://drupal.org/node/103114 > http://drupal.org/node/109153 > > > > Thanks again to Larry and Karoly for their comments. > > > Blessings, > > Augustin. > > P.S. to Larry: I guess I *still* need my beginner handle for a while longer, > after all... ;) > > From barry at jaspan.org Thu Jul 17 15:58:03 2008 From: barry at jaspan.org (Barry Jaspan) Date: 17 Jul 2008 11:58:03 -0400 Subject: [development] no date / time types in schema API In-Reply-To: <200807021818.56356.drupal.beginner@wechange.org> References: <200807021818.56356.drupal.beginner@wechange.org> Message-ID: "augustin (beginner)" writes: > All (but one) SQL dialects have a date type. However, Drupal's > Schema API does not seem to have a type for date only: > http://drupal.org/node/159605 > > Is this a purposeful omission? What workarounds do you use? It is not so much a purposeful omission as a problem I did not put effort into solving because, when I asked, no one told me it mattered. To have a Schema API type for dates and times require that it be able to map meaningfully to a native db type on all dbs we want to support. I thought that date and time types would be inconsistent between various dbs. I did put in one type, datetime, that works on mysql and pgsql, but did not try to find portable types for time and date separately. That said, there is a workaround: You can declare db-specific column types in the Schema API field structure, using mysql_type and pgsql_type, like this: $schema['mytable'] = array( 'fields' => array( 'mycolumn' => array('mysql_type' => 'date', 'pgsql_type' => 'whatever', ....))); > There is probably a better way to truncate the time part (please > say), but it feels a shame to have to deal with the extraneous time > part when Schema API could easily handle date types. If you have a specific suggestion for what the Schema API date and time related types should be and how they should map to mysql and pgsql native types, by all means submit an issue at d.o. Thanks, Barry From eric.schaefer at eas-consulting.de Thu Jul 17 17:21:21 2008 From: eric.schaefer at eas-consulting.de (Eric-Alexander Schaefer) Date: Thu, 17 Jul 2008 19:21:21 +0200 Subject: [development] HTML emails In-Reply-To: <487E678E.7050800@benl.co.uk> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> <487E32E6.9090903@eas-consulting.de> <487E678E.7050800@benl.co.uk> Message-ID: <487F7F91.2010908@eas-consulting.de> Benjamin Lewis schrieb: > It MUST contain a plaintext version (per RFC 2119 [1]) Well, then we should call the RFC-Swat, because 1001 MUAs don't care a bit about it. ;-) Eric From sepeck at gmail.com Thu Jul 17 20:00:30 2008 From: sepeck at gmail.com (Steven Peck) Date: Thu, 17 Jul 2008 13:00:30 -0700 Subject: [development] HTML emails In-Reply-To: <200807162059.29306.larry@garfieldtech.com> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <487E32E6.9090903@eas-consulting.de> <487E678E.7050800@benl.co.uk> <200807162059.29306.larry@garfieldtech.com> Message-ID: On Wed, Jul 16, 2008 at 6:59 PM, Larry Garfield wrote: > On Wednesday 16 July 2008 4:26:38 pm Benjamin Lewis wrote: >> Eric-Alexander Schaefer wrote: >> > Larry Garfield schrieb: >> >> I am going to take the luddite position. Consider yourself warned. :-) >> > >> > Thanks (for your position, not the warning). >> > Plaintext should be the default and HTML _could_ be an option. If HTML >> > is used, it should contain a plaintext version. >> >> It MUST contain a plaintext version (per RFC 2119 [1]) >> >> [1] http://tools.ietf.org/html/rfc2119 > > You're making the naive assumption that people actually follow that > requirement. :-) LOTS of email floating about the Net, both legit and > spam/trojans, contains HTML and no body. And sending the message twice > (plain and HTML) is a slap in the face to anyone on low bandwidth. > > -- > Larry Garfield > larry at garfieldtech.com > Urban legends aside, actually it is not a naive assumption, it's a valid one and the referenced RFC is a good starting point for anyone wanting to develop a valid message format. The vast majority of spam filters will in fact block as spam malformed messages. A message is considered malformed if it only has HTML content and no text component. The percentage in gross terms of malformed messages (particularly deliberate spam) is fairly low to the overall percentage of email. We block approximately 85-90% of the incoming email where I work as spam and of that 85-90% less than 2% is triggered as malformed. It is a mid-sized environment with about 30 million messages in the last month. In the early days of spam (where simple word filters roamed free as the tool of choice), malformed messages were not tested for and as a result spammers used that technique for a while. While sending HTML messages is in fact harder on low bandwidth recipients, HTML messages are a fact of life and there is a portion of a given customer base that does in fact want to use it. From ben.lewis at benl.co.uk Thu Jul 17 21:03:50 2008 From: ben.lewis at benl.co.uk (Benjamin Lewis) Date: Thu, 17 Jul 2008 22:03:50 +0100 Subject: [development] HTML emails In-Reply-To: References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <487E32E6.9090903@eas-consulting.de> <487E678E.7050800@benl.co.uk> <200807162059.29306.larry@garfieldtech.com> Message-ID: <487FB3B6.4040707@benl.co.uk> Steven Peck wrote: > On Wed, Jul 16, 2008 at 6:59 PM, Larry Garfield wrote: >> On Wednesday 16 July 2008 4:26:38 pm Benjamin Lewis wrote: >>> Eric-Alexander Schaefer wrote: >>>> Larry Garfield schrieb: >>>>> I am going to take the luddite position. Consider yourself warned. :-) >>>> Thanks (for your position, not the warning). >>>> Plaintext should be the default and HTML _could_ be an option. If HTML >>>> is used, it should contain a plaintext version. >>> It MUST contain a plaintext version (per RFC 2119 [1]) >>> >>> [1] http://tools.ietf.org/html/rfc2119 >> You're making the naive assumption that people actually follow that >> requirement. :-) LOTS of email floating about the Net, both legit and >> spam/trojans, contains HTML and no body. And sending the message twice >> (plain and HTML) is a slap in the face to anyone on low bandwidth. >> >> -- >> Larry Garfield >> larry at garfieldtech.com >> > > Urban legends aside, actually it is not a naive assumption, it's a > valid one and the referenced RFC is a good starting point for anyone > wanting to develop a valid message format. The vast majority of spam > filters will in fact block as spam malformed messages. A message is > considered malformed if it only has HTML content and no text > component. The percentage in gross terms of malformed messages I also hate it when I receive messages that say something like: "You need to upgrade your mail client to see HTML messages" That is not, imho, a good enough text component and it would be really good if this could _also_ be avoided. > (particularly deliberate spam) is fairly low to the overall percentage > of email. We block approximately 85-90% of the incoming email where I > work as spam and of that 85-90% less than 2% is triggered as > malformed. It is a mid-sized environment with about 30 million > messages in the last month. In the early days of spam (where simple > word filters roamed free as the tool of choice), malformed messages > were not tested for and as a result spammers used that technique for a > while. Exactly, so it is absolutely paramount that we output well-formed messages. > > While sending HTML messages is in fact harder on low bandwidth > recipients, HTML messages are a fact of life and there is a portion of > a given customer base that does in fact want to use it. -- Benjamin Lewis Fedora Ambassador ben.lewis at benl.co.uk ----------------------------------------------------------------------- http://benl.co.uk./ PGP Key: 0x647E480C "In cases of major discrepancy, it is always reality that got it wrong" -- RFC 1118 -------------- next part -------------- A non-text attachment was scrubbed... Name: ben_lewis.vcf Type: text/x-vcard Size: 196 bytes Desc: not available Url : http://lists.drupal.org/pipermail/development/attachments/20080717/61be9590/attachment.vcf -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 897 bytes Desc: OpenPGP digital signature Url : http://lists.drupal.org/pipermail/development/attachments/20080717/61be9590/attachment.pgp From support at corp.scour.com Thu Jul 17 15:43:08 2008 From: support at corp.scour.com (Sambasiva Rao) Date: Thu, 17 Jul 2008 08:43:08 -0700 (PDT) Subject: [development] Scour.com invite from Sambasiva Rao Message-ID: <20080717192838.EC9834736A5@www1.scour.com> Hey, Did you hear about Scour? It is the next gen search engine with Google/Yahoo/MSN results and user comments all on one page. Best of all we get paid for using it by earning points with every search, comment and vote. The points are redeemable for Visa gift cards! It's like earning credit card or airline points just for searching! Hit the link below to join for free and we will both get points! http://scour.com/invite/sanaari/ I know you'll like it! - Sambasiva Rao From info at 33rdprime.com Fri Jul 18 00:39:14 2008 From: info at 33rdprime.com (Patrick Teglia) Date: Thu, 17 Jul 2008 18:39:14 -0600 Subject: [development] Scour.com invite from Sambasiva Rao In-Reply-To: <20080717192838.EC9834736A5@www1.scour.com> References: <20080717192838.EC9834736A5@www1.scour.com> Message-ID: And I am wondering why this is on this list? Patrick Teglia On Thu, Jul 17, 2008 at 9:43 AM, Sambasiva Rao wrote: > Hey, > > Did you hear about Scour? It is the next gen search engine with > Google/Yahoo/MSN results and user comments all on one page. Best of all we > get paid for using it by earning points with every search, comment and vote. > The points are redeemable for Visa gift cards! It's like earning credit card > or airline points just for searching! Hit the link below to join for free > and we will both get points! > > http://scour.com/invite/sanaari/ > > I know you'll like it! > > - Sambasiva Rao > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080717/eb527a9c/attachment.htm From cwgordon7 at cwgordon.com Fri Jul 18 02:18:32 2008 From: cwgordon7 at cwgordon.com (Charlie Gordon) Date: Thu, 17 Jul 2008 22:18:32 -0400 Subject: [development] Scour.com invite from Sambasiva Rao In-Reply-To: References: <20080717192838.EC9834736A5@www1.scour.com> Message-ID: <487FFD78.3050809@cwgordon.com> Because it's spam? Maybe the development list should be minimally moderated, just so this sort of thing doesn't get through (as well as the occasional support request, etc). Patrick Teglia wrote: > And I am wondering why this is on this list? From drupal at oadaeh.net Fri Jul 18 05:49:14 2008 From: drupal at oadaeh.net (Jason Flatt) Date: Thu, 17 Jul 2008 22:49:14 -0700 Subject: [development] Scour.com invite from Sambasiva Rao In-Reply-To: <487FFD78.3050809@cwgordon.com> References: <20080717192838.EC9834736A5@www1.scour.com> <487FFD78.3050809@cwgordon.com> Message-ID: <200807172249.14854.drupal@oadaeh.net> On Thu Jul 17 2008 7:18:32 pm Charlie Gordon wrote: > Because it's spam? > > Maybe the development list should be minimally moderated, just so this > sort of thing doesn't get through (as well as the occasional support > request, etc). > With as little time as people have to do the important tasks, like database, server and search optimization, I think it would be a bad idea to try and moderate this list. I get far more spam from my d.o account than I do from this list. -- Jason Flatt http://www.oadaeh.net/ Father of Six: http://www.flattfamily.com/ (Joseph, 15; Cramer, 13; Travis, 11; Angela; Harry, 8; and William, 2) Linux User: http://www.kubuntu.org/ Drupal Fanatic: http://drupal.org/ From syscrusher at 4th.com Fri Jul 18 12:07:45 2008 From: syscrusher at 4th.com (Syscrusher) Date: Fri, 18 Jul 2008 08:07:45 -0400 Subject: [development] Scour.com invite from Sambasiva Rao In-Reply-To: <200807172249.14854.drupal@oadaeh.net> References: <20080717192838.EC9834736A5@www1.scour.com> <487FFD78.3050809@cwgordon.com> <200807172249.14854.drupal@oadaeh.net> Message-ID: <1216382865.9883.136.camel@marcus> On Thu, 2008-07-17 at 22:49 -0700, Jason Flatt wrote: > With as little time as people have to do the important tasks, like > database, > server and search optimization, I think it would be a bad idea to try > and > moderate this list. I get far more spam from my d.o account than I do > from > this list. How about setting the list so that each new subscriber's first post needs moderation, but subsequent posts don't? That's what I do on public lists I admin, and it works well with minimal moderator attention. If their first post is spam, you drop the subscription and delete it. If not, then you clear the moderation flag and let them run free. Scott -- Syscrusher From michael at favias.org Fri Jul 18 15:51:05 2008 From: michael at favias.org (Michael Favia) Date: Fri, 18 Jul 2008 10:51:05 -0500 Subject: [development] Scour.com invite from Sambasiva Rao In-Reply-To: References: <20080717192838.EC9834736A5@www1.scour.com> Message-ID: <4880BBE9.2030902@favias.org> Patrick Teglia wrote: > And I am wondering why this is on this list? FWIW i doubt he was trying to even send it to this list but instead used one of those contact list importers that social network providers have and we were collateral damage. Lets give him the benefit of the doubt and chalk it up to the equivalent of a cellphone ringing in during a speech. Annoying but not malicious nor requiring draconian action. Then again if he sends another one for Amway products I say we burn him at the stake with all the other witches. -- Michael Favia michael at favias.org tel. 512.585.5650 http://www.favias.org From rob at robshouse.net Fri Jul 18 20:36:50 2008 From: rob at robshouse.net (Robert Douglass) Date: Fri, 18 Jul 2008 22:36:50 +0200 Subject: [development] Memcache critical issues blocking D6 upgrade Message-ID: Anyone interested in the health and future of the memcache module: Please look at the critical issues for memcache DRUPAL-5--1-7: http://tinyurl.com/5flw54 I want to make a DRUPAL-5--1-8 release that fixes these issues before upgrading to Drupal 6. Please lend your support. Robert Douglass rob at robshouse.net The RobsHouse.net Newsletter: http://robshouse.net/newsletter/robshousenet-newsletter From rob at robshouse.net Fri Jul 18 22:10:49 2008 From: rob at robshouse.net (Robert Douglass) Date: Sat, 19 Jul 2008 00:10:49 +0200 Subject: [development] Advcache module needs some love. Message-ID: <5ED12048-62B1-4A14-A9B8-2E91F93868A4@robshouse.net> Hi all, I'd like to do a DRUPAL-5--1-8 release of advcache but there are some bugs. I could use eyeballs on the queue. When we get the queue down I'll look into a DRUPAL-6 version. http://tinyurl.com/5q4537 Robert Douglass rob at robshouse.net The RobsHouse.net Newsletter: http://robshouse.net/newsletter/robshousenet-newsletter -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080719/fa677619/attachment.htm From catch56 at googlemail.com Fri Jul 18 22:25:38 2008 From: catch56 at googlemail.com (Nathaniel Catchpole) Date: Fri, 18 Jul 2008 23:25:38 +0100 Subject: [development] Memcache critical issues blocking D6 upgrade In-Reply-To: References: Message-ID: How does this fit in with cacherouter? http://drupal.org/project/cacherouter On Fri, Jul 18, 2008 at 9:36 PM, Robert Douglass wrote: > Anyone interested in the health and future of the memcache module: > From rob at robshouse.net Sat Jul 19 04:49:02 2008 From: rob at robshouse.net (Robert Douglass) Date: Sat, 19 Jul 2008 06:49:02 +0200 Subject: [development] Memcache critical issues blocking D6 upgrade In-Reply-To: References: Message-ID: At the moment there isn't much coordination between cacherouter and memcache. If cacherouter were made in a pluggable way that could simply absorb new caching modules and route between them it would be easier to coordinate. I don't know if this is the case. On Jul 19, 2008, at 12:25 AM, Nathaniel Catchpole wrote: > How does this fit in with cacherouter? http://drupal.org/project/cacherouter > > > On Fri, Jul 18, 2008 at 9:36 PM, Robert Douglass wrote: >> Anyone interested in the health and future of the memcache module: >> From pec.sumit at gmail.com Sat Jul 19 23:47:23 2008 From: pec.sumit at gmail.com (sumit kataria) Date: Sun, 20 Jul 2008 05:17:23 +0530 Subject: [development] Scour.com invite from Sambasiva Rao In-Reply-To: <4880BBE9.2030902@favias.org> References: <20080717192838.EC9834736A5@www1.scour.com> <4880BBE9.2030902@favias.org> Message-ID: yeah may be Scour contacts import thing pulled this mail address from his contact list ;) But spam will remain spam sad behavior sanari9 at gmail.com On Fri, Jul 18, 2008 at 9:21 PM, Michael Favia wrote: > Patrick Teglia wrote: > >> And I am wondering why this is on this list? >> > > FWIW i doubt he was trying to even send it to this list but instead used > one of those contact list importers that social network providers have and > we were collateral damage. Lets give him the benefit of the doubt and chalk > it up to the equivalent of a cellphone ringing in during a speech. Annoying > but not malicious nor requiring draconian action. Then again if he sends > another one for Amway products I say we burn him at the stake with all the > other witches. > > -- > Michael Favia michael at favias.org > tel. 512.585.5650 http://www.favias.org > -- Warm Regards sumit kataria cell 91-9888546343 www.sumitk.net -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080720/7a8549f9/attachment.htm From sean at practicalweb.co.uk Sun Jul 20 19:15:14 2008 From: sean at practicalweb.co.uk (Sean Burlington) Date: Sun, 20 Jul 2008 20:15:14 +0100 Subject: [development] HTML emails In-Reply-To: <2af50bac682c41897554f33ee5e8324a@localhost> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> Message-ID: <48838EC2.2090402@practicalweb.co.uk> Larry Garfield wrote: > On Wed, 16 Jul 2008 10:12:33 +0100, Matt Connolly wrote: > >> Besides, email clients have been HTML friendly for a *long* time, so I >> don't see why Drupal shouldn't have an interface that understands rich >> email messages. >> >> Thoughts? >> >> >> Matt > > I am going to take the luddite position. Consider yourself warned. :-) > > HTML email is not, as far as I am aware, an actual standard. Well there's this http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html and there's the fact that over half of emails sent are html formatted ;-) > Why should we encourage that? As far as I'm concerned, we shouldn't. > > That said, there may well be advantages to switching to drupal_render() for email messages. I am in general a big fan of structured data remaining structured for as long as possible. The benefit, however, would not be for HTML mail but for, say, easier email attachments. That such a move would make it easier to send HTML email as well, well, that's a side effect I suppose we can live with. > I have just been working on an email that I need Drupal to send which include both tabular data and a graph In Drupal 5 the mimemail module worked a treat for this. Yes I had to work at getting the formatting to work consistently - but then what's new - it's just another dimension to cross browser support. It would be really useful to have the ability to more easily send formatted mail - the more ways too cleanly hook into Drupal's email sending process the better. I don't like HTML email - but I don't dictate my preferences to clients. If they want formatted email with company logos and and 3 pages of legal disclaimers - I may try to inform them of alternatives - but if its what they want and they're paying - it's what I'll provide. -- Sean Burlington www.practicalweb.co.uk From pushyamitra at gmail.com Mon Jul 21 09:26:36 2008 From: pushyamitra at gmail.com (Pushyamitra Navare) Date: Mon, 21 Jul 2008 14:56:36 +0530 Subject: [development] Can I Indicate failure from hook_user? Message-ID: Hello there, I'm new to Drupal, just started a couple of weeks ago. I had following queries regarding hooks. It would be great if someone could provide feedback/suggestions on this. 1. I have written a module which implements "hook_user" and handles "update" and "insert" operations. I want to be able to signal failure/ success from this function. For e.g. if I return failure (boolean FALSE) from "hook_user" for "update" operation, then user update should not happen. I want to do this for "insert", "update" and "delete" operations. * Is it possible to indicate failure in this way so that update/ insert/ delete will not take place? * If yes, how can I accomplish this? 2. Also, I quickly glanced through the user.module. At the top there is a function called "user_module_invoke" which takes care of invoking "hook_user" in various modules. But it does not check for return value, nor does it return anything. So probably result of invoking a hook_user is never checked. If Drupal hooks currently don't check for return value, would it be good idea to add such a functionality? A "pre-operation" hook, which will indicate (boolean TRUE/ FALSE) if the operation should continue or not. Such a hook could be used for various validations when Drupal is integrated with some third-party applications. Any takers for this? Do reply. Thanks in anticipation, Pushyamitra -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080721/dbf0aab1/attachment-0001.htm From enboig at gmail.com Mon Jul 21 09:55:48 2008 From: enboig at gmail.com (=?ISO-8859-1?Q?Llu=EDs?=) Date: Mon, 21 Jul 2008 11:55:48 +0200 Subject: [development] clone a node Message-ID: <45a29f450807210255u7aaebb6bn1cb6deab4594e69f@mail.gmail.com> I have developed a custom module with custom node types and I need to make users able to clone nodes; would this be a good way to do so? $clone=node_load($value); $clone->is_new = true; $clone->uid = $user->uid; unset($clone->nid); unset($clone->vid); node_save($clone); -- *La vida ?s com una moneda, la pots gastar en el que vulguis per? nom?s una vegada. *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les il?lusions. *Als llocs desconeguts nom?s s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient. From catch56 at googlemail.com Mon Jul 21 09:59:03 2008 From: catch56 at googlemail.com (Nathaniel Catchpole) Date: Mon, 21 Jul 2008 10:59:03 +0100 Subject: [development] clone a node In-Reply-To: <45a29f450807210255u7aaebb6bn1cb6deab4594e69f@mail.gmail.com> References: <45a29f450807210255u7aaebb6bn1cb6deab4594e69f@mail.gmail.com> Message-ID: You could take a look at the node_clone module if you haven't already: http://drupal.org/project/node_clone On Mon, Jul 21, 2008 at 10:55 AM, Llu?s wrote: > I have developed a custom module with custom node types and I need to > make users able to clone nodes; would this be a good way to do so? > > $clone=node_load($value); > $clone->is_new = true; > $clone->uid = $user->uid; > unset($clone->nid); > unset($clone->vid); > node_save($clone); > > > -- From darthsteven at gmail.com Mon Jul 21 10:23:16 2008 From: darthsteven at gmail.com (Steven Jones) Date: Mon, 21 Jul 2008 11:23:16 +0100 Subject: [development] Can I Indicate failure from hook_user? In-Reply-To: References: Message-ID: Always good to see someone new to Drupal. Lots of hook return values. You'll probably want to do something with the $op == "validate" argument of hook_user. Throw an error if you don't want the update/insert to continue. Regards Steven Jones On Mon, Jul 21, 2008 at 10:26 AM, Pushyamitra Navare wrote: > Hello there, > > I'm new to Drupal, just started a couple of weeks ago. I had following > queries regarding hooks. It would be great if someone could provide > feedback/suggestions on this. > > 1. I have written a module which implements "hook_user" and handles "update" > and "insert" operations. I want to be able to signal failure/ success from > this function. For e.g. if I return failure (boolean FALSE) from "hook_user" > for "update" operation, then user update should not happen. I want to do > this for "insert", "update" and "delete" operations. > > * Is it possible to indicate failure in this way so that update/ insert/ > delete will not take place? > * If yes, how can I accomplish this? > > 2. Also, I quickly glanced through the user.module. At the top there is a > function called "user_module_invoke" which takes care of invoking > "hook_user" in various modules. But it does not check for return value, nor > does it return anything. So probably result of invoking a hook_user is never > checked. > > If Drupal hooks currently don't check for return value, would it be good > idea to add such a functionality? A "pre-operation" hook, which will > indicate (boolean TRUE/ FALSE) if the operation should continue or not. Such > a hook could be used for various validations when Drupal is integrated with > some third-party applications. Any takers for this? > > Do reply. > Thanks in anticipation, > Pushyamitra From matt at cabinetuk.com Mon Jul 21 11:03:57 2008 From: matt at cabinetuk.com (Matt Connolly) Date: Mon, 21 Jul 2008 12:03:57 +0100 Subject: [development] HTML emails In-Reply-To: <48838EC2.2090402@practicalweb.co.uk> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> <48838EC2.2090402@practicalweb.co.uk> Message-ID: <3EBB8F2C-7565-4245-8C68-0652B27AFE51@cabinetuk.com> That's a great spec for constructing multi part messages, but it doesn't really go in to HTML at all. Is there a standard, for example, for using content-inline-disposition links to use an attached image in the html document? Does HTML email conform to HTML3 HTML4 XHTML1.0, etc? Anyway, I agree that the data should remain structured for as long possible. Perhaps drupal can detect if there's a string (or array of strings) then it's an old school email, or if it's a keyed array of attributes, then construct the multipart message, using drupal render to a default theme or theme function (perhaps specified by a '#theme' key). -Matt On 20/07/2008, at 8:15 PM, Sean Burlington wrote: > > Well there's this > > http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html > > and there's the fact that over half of emails sent are html formatted > > ;-) > >> Why should we encourage that? As far as I'm concerned, we >> shouldn't. That said, there may well be advantages to switching to >> drupal_render() for email messages. I am in general a big fan of >> structured data remaining structured for as long as possible. The >> benefit, however, would not be for HTML mail but for, say, easier >> email attachments. That such a move would make it easier to send >> HTML email as well, well, that's a side effect I suppose we can >> live with. > > I have just been working on an email that I need Drupal to send > which include both tabular data and a graph > > In Drupal 5 the mimemail module worked a treat for this. > > Yes I had to work at getting the formatting to work consistently - > but then what's new - it's just another dimension to cross browser > support. > > It would be really useful to have the ability to more easily send > formatted mail - the more ways too cleanly hook into Drupal's email > sending process the better. > > I don't like HTML email - but I don't dictate my preferences to > clients. > > If they want formatted email with company logos and and 3 pages of > legal disclaimers - I may try to inform them of alternatives - but > if its what they want and they're paying - it's what I'll provide. > > > > > -- > > Sean Burlington > > www.practicalweb.co.uk > From enboig at gmail.com Mon Jul 21 11:44:51 2008 From: enboig at gmail.com (=?ISO-8859-1?Q?Llu=EDs?=) Date: Mon, 21 Jul 2008 13:44:51 +0200 Subject: [development] clone a node In-Reply-To: References: <45a29f450807210255u7aaebb6bn1cb6deab4594e69f@mail.gmail.com> Message-ID: <45a29f450807210444ka642b5au45595c478cc9b7b8@mail.gmail.com> I have developed a simple group system (similar to OG in some ways, very diferent in others) so I need a user beeing able to import nodes from other groups to his own. To do so I have created a form which loads all the nodes from other groups as checkboxes. The checked items will be cloned to his group. I haven't tried node_clone, but I think it is UI oriented; I just need to clone a node knowing its ID (all group permissions, etc... are rewritten using nodeapi of my custom node). On Mon, Jul 21, 2008 at 11:59 AM, Nathaniel Catchpole wrote: > You could take a look at the node_clone module if you haven't already: > http://drupal.org/project/node_clone > > On Mon, Jul 21, 2008 at 10:55 AM, Llu?s wrote: >> I have developed a custom module with custom node types and I need to >> make users able to clone nodes; would this be a good way to do so? >> >> $clone=node_load($value); >> $clone->is_new = true; >> $clone->uid = $user->uid; >> unset($clone->nid); >> unset($clone->vid); >> node_save($clone); >> >> >> -- > -- *La vida ?s com una moneda, la pots gastar en el que vulguis per? nom?s una vegada. *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les il?lusions. *Als llocs desconeguts nom?s s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient. From morbus at disobey.com Mon Jul 21 12:53:41 2008 From: morbus at disobey.com (Morbus Iff) Date: Mon, 21 Jul 2008 08:53:41 -0400 Subject: [development] Drupal Tough Love #2: Signatures for Forums 5.x-2.3 Message-ID: <488486D5.2080208@disobey.com> In case you missed it, a new Drupal Tough Love is up: http://www.drupaltoughlove.com/review/signatures-for-forums It has caused a few changes, and issues, for Coder.module and core. And there's one issue that I still haven't gotten around to making, which Benjamin Melan?on brings up - core's uid should, in fact, be considered unsigned in all tables, but isn't (ex. node.install). -- Morbus Iff ( i've got the creme filling ) Technical: http://www.oreillynet.com/pub/au/779 Enjoy: http://www.disobey.com/ and http://www.videounderbelly.com/ aim: akaMorbus / skype: morbusiff / icq: 2927491 / jabber.org: morbus From bto108 at psu.edu Mon Jul 21 13:46:12 2008 From: bto108 at psu.edu (Bryan Ollendyke) Date: Mon, 21 Jul 2008 09:46:12 -0400 Subject: [development] clone a node In-Reply-To: <45a29f450807210444ka642b5au45595c478cc9b7b8@mail.gmail.com> References: <45a29f450807210255u7aaebb6bn1cb6deab4594e69f@mail.gmail.com> <45a29f450807210444ka642b5au45595c478cc9b7b8@mail.gmail.com> Message-ID: <89c4d4df0807210646w4a34c03lceb364128899d577@mail.gmail.com> There's a switch statement based ajax function in outline_designer ( http://drupal.org/project/outline_designer) called duplicate. The best way to clone a node is to load it with drupal node_load then clear out the nid. Then call node_save and it'll look at the node, see that there isn't a nid and assign it one. The rest of the fields will be saved via the nodeapi hooks. The function you wrote before looks very similar to the one I used. btopro On Mon, Jul 21, 2008 at 7:44 AM, Llu?s wrote: > I have developed a simple group system (similar to OG in some ways, > very diferent in others) so I need a user beeing able to import nodes > from other groups to his own. > To do so I have created a form which loads all the nodes from other > groups as checkboxes. The checked items will be cloned to his group. > > I haven't tried node_clone, but I think it is UI oriented; I just need > to clone a node knowing its ID (all group permissions, etc... are > rewritten using nodeapi of my custom node). > > > On Mon, Jul 21, 2008 at 11:59 AM, Nathaniel Catchpole > wrote: > > You could take a look at the node_clone module if you haven't already: > > http://drupal.org/project/node_clone > > > > On Mon, Jul 21, 2008 at 10:55 AM, Llu?s wrote: > >> I have developed a custom module with custom node types and I need to > >> make users able to clone nodes; would this be a good way to do so? > >> > >> $clone=node_load($value); > >> $clone->is_new = true; > >> $clone->uid = $user->uid; > >> unset($clone->nid); > >> unset($clone->vid); > >> node_save($clone); > >> > >> > >> -- > > > > > > -- > *La vida ?s com una moneda, la pots gastar en el que vulguis per? > nom?s una vegada. > *La felicitat ha de ser compatible, compartible i cooperativa. > *Envellim quan els records superen les il?lusions. > *Als llocs desconeguts nom?s s'hi arriba per camins desconeguts. > *Abans d'imprimir aquest missatge, pensa en el medi ambient. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080721/00906dcc/attachment.htm From sean at practicalweb.co.uk Mon Jul 21 13:57:12 2008 From: sean at practicalweb.co.uk (Sean Burlington) Date: Mon, 21 Jul 2008 14:57:12 +0100 Subject: [development] HTML emails In-Reply-To: <3EBB8F2C-7565-4245-8C68-0652B27AFE51@cabinetuk.com> References: <181BDA55-7852-46DB-A1D9-CF6D7C8A06E9@cabinetuk.com> <2af50bac682c41897554f33ee5e8324a@localhost> <48838EC2.2090402@practicalweb.co.uk> <3EBB8F2C-7565-4245-8C68-0652B27AFE51@cabinetuk.com> Message-ID: <488495B8.7010301@practicalweb.co.uk> Matt Connolly wrote: > That's a great spec for constructing multi part messages, but it doesn't > really go in to HTML at all. > see http://www.w3.org/TR/html4/ ;-) > Is there a standard, for example, for using content-inline-disposition > links to use an attached image in the html document? > see 9.3 Example with relative URIs to embedded GIF pictures http://www.faqs.org/rfcs/rfc2557.html But there's a whole swarm of related RFCs on this subject Each tends to be fairly focussed on a particular subtopic - you have to do a lot of cross referencing to get the full picture > Does HTML email conform to HTML3 HTML4 XHTML1.0, etc? > Surely that depends on the doctype - it's up to the author. Mail clients don't provide very good support of the standards - but the standards do exist. > > Anyway, I agree that the data should remain structured for as long > possible. Perhaps drupal can detect if there's a string (or array of > strings) then it's an old school email, or if it's a keyed array of > attributes, then construct the multipart message, using drupal render to > a default theme or theme function (perhaps specified by a '#theme' key). > that sounds good to me. To render the email will require different CSS Mail client rendering is back in the dark ages - tags and tables for layout are far more common in this area (Bad - yuk - I know - but Drupal should not prevent it). To mitigate against the accessibility issues: sending multipart/alternative AND allowing the user the option of plain text only are both important. mailing to a $user could check the receiving preference - and strip out the formatting if required. -- Sean Burlington www.practicalweb.co.uk From dan at drob.org Mon Jul 21 18:29:50 2008 From: dan at drob.org (Dan Robinson) Date: Mon, 21 Jul 2008 11:29:50 -0700 Subject: [development] Issues with selecting radio buttons with JQuery Message-ID: <4884D59E.2070103@drob.org> Folks, Help appreciated - I'm building a node form where the form will reveal/hide portions depending on the users choices. To do this I'm using jQuery to manipulate the DOM. I'm having a lot of issues with the radio buttons. What I want to do is have a message pop up if the user selects a particular radio button (in this case a "no" choice of a "Yes/No" "set"). For this to work I need to attach an "onClick" handle to the "no" radio button and when the user clicks evaluate and display the message. Because of a series of interrelated issues I've tried a number of approaches. The one I'm working on now is: - I'm using the form APIs "radios" - an issue here is that "radios" define the actual radio buttons in an array and it doesn't look like there is a way to assign an id attribute using the forms api (as a matter of fact there is code in form.inc which explicitly strips out an ID at that level). - I assign an onClick handler to the "radios" - #attributes' => array('onClick' => 'CitizenClick()') - On form load I assign an id to the specific radio button I'm interested in - $("[name=CitizenQ][value=no]").attr('id', 'CitizenNoButton'); - In CitizenClick() I check and take action depending - if ( $("#CitizenNoButton").attr('checked') ) { - Please note that although I could do all this without an "id" and by selecting the "name" instead of the "id" - it was very slow Everything works - EXCEPT - I am placing the radio buttons inside of a fieldset thusly - $form['Qualifyers'] = array( '#type' => 'fieldset', '#tree' => TRUE, '#weight' => 1, ); $form['Qualifyers']['CitizenQ'] = array( '#type' => 'radios', '#title' => t('Are you a U.S. Citizen?'), '#default_value' => 1, '#options' => array('yes' => t('Yes'), 'no' => t('No')), '#attributes' => array('onClick' => 'CitizenClick()'), ); If I don't place it within the fieldset I can select the radio with - $("[name=CitizenQ][value=no]") However withing the fieldset I can't get this to work - $("[name=Qualifyers[CitizenQ]][value=no]") I assumed the above wouldn't work because the "[]" are special characters so I tried escaping them - $("[name=Qualifyers\\[CitizenQ\\]][value=no]") Still no joy - I have been beating my head against this for a while and would appreciate some assistance - also if I've approached this in a fundamentally wrong way please let me know. Thanks! Dan From merlin at logrus.com Mon Jul 21 18:56:32 2008 From: merlin at logrus.com (Earl Miles) Date: Mon, 21 Jul 2008 11:56:32 -0700 Subject: [development] Issues with selecting radio buttons with JQuery In-Reply-To: <4884D59E.2070103@drob.org> References: <4884D59E.2070103@drob.org> Message-ID: <4884DBE0.9070508@logrus.com> Dan Robinson wrote: > Folks, > > Help appreciated - > > I'm building a node form where the form will reveal/hide portions > depending on the users choices. To do this I'm using jQuery to > manipulate the DOM. I'm having a lot of issues with the radio buttons. > > What I want to do is have a message pop up if the user selects a > particular radio button (in this case a "no" choice of a "Yes/No" > "set"). For this to work I need to attach an "onClick" handle to the > "no" radio button and when the user clicks evaluate and display the > message. Because of a series of interrelated issues I've tried a number > of approaches. The one I'm working on now is: > > - I'm using the form APIs "radios" - an issue here is that "radios" > define the actual radio buttons in an array and it doesn't look like > there is a way to assign an id attribute using the forms api (as a > matter of fact there is code in form.inc which explicitly strips out an > ID at that level). > - I assign an onClick handler to the "radios" - #attributes' => > array('onClick' => 'CitizenClick()') > - On form load I assign an id to the specific radio button I'm > interested in - $("[name=CitizenQ][value=no]").attr('id', > 'CitizenNoButton'); > - In CitizenClick() I check and take action depending - if ( > $("#CitizenNoButton").attr('checked') ) { > - Please note that although I could do all this without an "id" and by > selecting the "name" instead of the "id" - it was very slow > > Everything works - EXCEPT - > > I am placing the radio buttons inside of a fieldset thusly - > > $form['Qualifyers'] = array( > '#type' => 'fieldset', > '#tree' => TRUE, > '#weight' => 1, > ); > $form['Qualifyers']['CitizenQ'] = array( > '#type' => 'radios', > '#title' => t('Are you a U.S. Citizen?'), > '#default_value' => 1, > '#options' => array('yes' => t('Yes'), 'no' => t('No')), > '#attributes' => array('onClick' => 'CitizenClick()'), > ); > > If I don't place it within the fieldset I can select the radio with - > > $("[name=CitizenQ][value=no]") > > However withing the fieldset I can't get this to work - > > $("[name=Qualifyers[CitizenQ]][value=no]") > > I assumed the above wouldn't work because the "[]" are special > characters so I tried escaping them - > > $("[name=Qualifyers\\[CitizenQ\\]][value=no]") > > Still no joy - I have been beating my head against this for a while and > would appreciate some assistance - also if I've approached this in a > fundamentally wrong way please let me know. I would recommend setting up a #process so that you can use your own version of expand_radios() -- this will let you set things like the #name and #id of each individual radio option individually. That could allow you to much more easily deal with some of this oddness. From weitzman at tejasa.com Mon Jul 21 18:57:42 2008 From: weitzman at tejasa.com (Moshe Weitzman) Date: Mon, 21 Jul 2008 14:57:42 -0400 Subject: [development] Issues with selecting radio buttons with JQuery In-Reply-To: <4884D59E.2070103@drob.org> References: <4884D59E.2070103@drob.org> Message-ID: <6117a7500807211157g3743684cs2b1f8124cb0ae579@mail.gmail.com> please add your review and support to http://drupal.org/node/215301. You might learn something helpful from og_access.js in HEAD which does some radio button trickery. for example, $("input[@name='og_visibility']:nth(1)").removeAttr('disabled'); On Mon, Jul 21, 2008 at 2:29 PM, Dan Robinson wrote: > Folks, > > Help appreciated - > > I'm building a node form where the form will reveal/hide portions > depending on the users choices. To do this I'm using jQuery to > manipulate the DOM. I'm having a lot of issues with the radio buttons. > > What I want to do is have a message pop up if the user selects a > particular radio button (in this case a "no" choice of a "Yes/No" > "set"). For this to work I need to attach an "onClick" handle to the > "no" radio button and when the user clicks evaluate and display the > message. Because of a series of interrelated issues I've tried a number > of approaches. The one I'm working on now is: > > - I'm using the form APIs "radios" - an issue here is that "radios" > define the actual radio buttons in an array and it doesn't look like > there is a way to assign an id attribute using the forms api (as a > matter of fact there is code in form.inc which explicitly strips out an > ID at that level). > - I assign an onClick handler to the "radios" - #attributes' => > array('onClick' => 'CitizenClick()') > - On form load I assign an id to the specific radio button I'm > interested in - $("[name=CitizenQ][value=no]").attr('id', > 'CitizenNoButton'); > - In CitizenClick() I check and take action depending - if ( > $("#CitizenNoButton").attr('checked') ) { > - Please note that although I could do all this without an "id" and by > selecting the "name" instead of the "id" - it was very slow > > Everything works - EXCEPT - > > I am placing the radio buttons inside of a fieldset thusly - > > $form['Qualifyers'] = array( > '#type' => 'fieldset', > '#tree' => TRUE, > '#weight' => 1, > ); > $form['Qualifyers']['CitizenQ'] = array( > '#type' => 'radios', > '#title' => t('Are you a U.S. Citizen?'), > '#default_value' => 1, > '#options' => array('yes' => t('Yes'), 'no' => t('No')), > '#attributes' => array('onClick' => 'CitizenClick()'), > ); > > If I don't place it within the fieldset I can select the radio with - > > $("[name=CitizenQ][value=no]") > > However withing the fieldset I can't get this to work - > > $("[name=Qualifyers[CitizenQ]][value=no]") > > I assumed the above wouldn't work because the "[]" are special > characters so I tried escaping them - > > $("[name=Qualifyers\\[CitizenQ\\]][value=no]") > > Still no joy - I have been beating my head against this for a while and > would appreciate some assistance - also if I've approached this in a > fundamentally wrong way please let me know. > > Thanks! > > > Dan > > > > > From recidive at gmail.com Mon Jul 21 19:04:01 2008 From: recidive at gmail.com (Henrique Recidive) Date: Mon, 21 Jul 2008 16:04:01 -0300 Subject: [development] Issues with selecting radio buttons with JQuery In-Reply-To: <6117a7500807211157g3743684cs2b1f8124cb0ae579@mail.gmail.com> References: <4884D59E.2070103@drob.org> <6117a7500807211157g3743684cs2b1f8124cb0ae579@mail.gmail.com> Message-ID: <841684fe0807211204r611b326q7232c4b6ac7e936e@mail.gmail.com> This should do the trick: $("input[name='Qualifyers[CitizenQ]'][value=no]") henrique 2008/7/21 Moshe Weitzman : > please add your review and support to http://drupal.org/node/215301. > You might learn something helpful from og_access.js in HEAD which does > some radio button trickery. for example, > > $("input[@name='og_visibility']:nth(1)").removeAttr('disabled'); > > On Mon, Jul 21, 2008 at 2:29 PM, Dan Robinson wrote: >> Folks, >> >> Help appreciated - >> >> I'm building a node form where the form will reveal/hide portions >> depending on the users choices. To do this I'm using jQuery to >> manipulate the DOM. I'm having a lot of issues with the radio buttons. >> >> What I want to do is have a message pop up if the user selects a >> particular radio button (in this case a "no" choice of a "Yes/No" >> "set"). For this to work I need to attach an "onClick" handle to the >> "no" radio button and when the user clicks evaluate and display the >> message. Because of a series of interrelated issues I've tried a number >> of approaches. The one I'm working on now is: >> >> - I'm using the form APIs "radios" - an issue here is that "radios" >> define the actual radio buttons in an array and it doesn't look like >> there is a way to assign an id attribute using the forms api (as a >> matter of fact there is code in form.inc which explicitly strips out an >> ID at that level). >> - I assign an onClick handler to the "radios" - #attributes' => >> array('onClick' => 'CitizenClick()') >> - On form load I assign an id to the specific radio button I'm >> interested in - $("[name=CitizenQ][value=no]").attr('id', >> 'CitizenNoButton'); >> - In CitizenClick() I check and take action depending - if ( >> $("#CitizenNoButton").attr('checked') ) { >> - Please note that although I could do all this without an "id" and by >> selecting the "name" instead of the "id" - it was very slow >> >> Everything works - EXCEPT - >> >> I am placing the radio buttons inside of a fieldset thusly - >> >> $form['Qualifyers'] = array( >> '#type' => 'fieldset', >> '#tree' => TRUE, >> '#weight' => 1, >> ); >> $form['Qualifyers']['CitizenQ'] = array( >> '#type' => 'radios', >> '#title' => t('Are you a U.S. Citizen?'), >> '#default_value' => 1, >> '#options' => array('yes' => t('Yes'), 'no' => t('No')), >> '#attributes' => array('onClick' => 'CitizenClick()'), >> ); >> >> If I don't place it within the fieldset I can select the radio with - >> >> $("[name=CitizenQ][value=no]") >> >> However withing the fieldset I can't get this to work - >> >> $("[name=Qualifyers[CitizenQ]][value=no]") >> >> I assumed the above wouldn't work because the "[]" are special >> characters so I tried escaping them - >> >> $("[name=Qualifyers\\[CitizenQ\\]][value=no]") >> >> Still no joy - I have been beating my head against this for a while and >> would appreciate some assistance - also if I've approached this in a >> fundamentally wrong way please let me know. >> >> Thanks! >> >> >> Dan >> >> >> >> >> > From dan at drob.org Mon Jul 21 20:10:41 2008 From: dan at drob.org (Dan Robinson) Date: Mon, 21 Jul 2008 13:10:41 -0700 Subject: [development] Issues with selecting radio buttons with JQuery In-Reply-To: <4884D59E.2070103@drob.org> References: <4884D59E.2070103@drob.org> Message-ID: <4884ED41.9050609@drob.org> Thanks everyone! - answering all in one to save bits. Earl - > I would recommend setting up a #process so that you can use your own > version of expand_radios() -- this will let you set things like the > #name and #id of each individual radio option individually. That could > allow you to much more easily deal with some of this oddness. Interesting - I'm not sure I completely understand how this works - but I will study up. Moshe - > please add your review and support to http://drupal.org/node/215301. > You might learn something helpful from og_access.js in HEAD which does > some radio button trickery. for example, > > $("input[@name='og_visibility']:nth(1)").removeAttr('disabled'); I would like to help here - I actually looked through this yesterday but couldn't get the patch to work on D6 - so headed in another direction. I'm not working on D7 right now so I'm not sure how to review it - if a patch for D6 appears I could jump on that. Henrique - > This should do the trick: > > $("input[name='Qualifyers[CitizenQ]'][value=no]") > > henrique > yeah baby! - that worked - not sure why the escape didn't - but maybe I'll figure that out later - thanks! Dan > Folks, > > Help appreciated - > > I'm building a node form where the form will reveal/hide portions > depending on the users choices. To do this I'm using jQuery to > manipulate the DOM. I'm having a lot of issues with the radio buttons. > > What I want to do is have a message pop up if the user selects a > particular radio button (in this case a "no" choice of a "Yes/No" > "set"). For this to work I need to attach an "onClick" handle to the > "no" radio button and when the user clicks evaluate and display the > message. Because of a series of interrelated issues I've tried a number > of approaches. The one I'm working on now is: From merlin at logrus.com Mon Jul 21 20:37:13 2008 From: merlin at logrus.com (Earl Miles) Date: Mon, 21 Jul 2008 13:37:13 -0700 Subject: [development] Issues with selecting radio buttons with JQuery In-Reply-To: <4884ED41.9050609@drob.org> References: <4884D59E.2070103@drob.org> <4884ED41.9050609@drob.org> Message-ID: <4884F379.8070809@logrus.com> Dan Robinson wrote: > Thanks everyone! - answering all in one to save bits. > > Earl - >> I would recommend setting up a #process so that you can use your own >> version of expand_radios() -- this will let you set things like the >> #name and #id of each individual radio option individually. That could >> allow you to much more easily deal with some of this oddness. > > Interesting - I'm not sure I completely understand how this works - but > I will study up. While it may be moot as your problem was solved by Henrique, the way checkboxes and radios work is that they automatically have a #process function which expands the checkboxes into multiple form widgets. See: http://api.drupal.org/?q=api/function/expand_radios/head You can do this (at least in D6): '#process' => array('mymodule_expand_radios'), This will override the default #process and call your version of the function instead. From syscrusher at 4th.com Mon Jul 21 21:27:07 2008 From: syscrusher at 4th.com (Syscrusher) Date: Mon, 21 Jul 2008 17:27:07 -0400 Subject: [development] Peculiar behavior of collapsible fieldset titles Message-ID: <1216675627.7280.45.camel@marcus> I've got a set of forms in Drupal 5 that are working correctly but have an odd cosmetic error that I've been unable to track down. The code worked in Drupal 4.7. Basically, I am assigning the title of some collapsible fieldsets dynamically -- specifically, it's a project number and name that result from a database query. The title should look like this: Subtasks for Project #1234 (Redesign Office LAN) For some reason, the titles are perfect when the fieldsets are expanded but empty when collapsed (that is, they look like this): Subtasks for # () I think I know *what* is happening -- that is, the function that builds the $form array is being called twice and has the variable unpopulated one of the two times -- but I'm at a loss to figure out how that could be happening. The database query not only populates the title of the fieldset, but also its very presence depends on a row being retrieved. So I would think that if the database query were somehow being skipped, the fieldset would be entirely missing, not just empty! Has anyone seen something like this before? I realize I haven't given enough detail or code to troubleshoot it entirely -- I'm not asking someone to do my debugging for me, just looking for someone out there who has seen something similar and can tell me in general terms what might be happening. Thanks if anyone has suggestions. Kind regards, Scott -- Syscrusher From jk at ozlabs.org Mon Jul 21 23:36:14 2008 From: jk at ozlabs.org (Jeremy Kerr) Date: Tue, 22 Jul 2008 09:36:14 +1000 Subject: [development] [PATCH] drupal/filter: fix broken multi-line HTML tags Message-ID: <1216683374.199267.203058232764.qpush@pingu> Currently, the filter module will mis-handle HTML tags that span more than one line. For example: link Will be filtered to: This is caused by the attempt to match '.>' in filter_xss(). Since the . doesn't (by default) match a newline, the filter will try to escape the closing > on the tag. This results in aggregated feeds with badly-formed HTML. This change removes the . match, so that a newline as the last character in a opening HTML tag is accepted. So that we always require at least one character in a tag, we also change the [^>]* to [^>]+ Signed-off-by: Jeremy Kerr --- modules/filter/filter.module | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: drupal-6.2/modules/filter/filter.module =================================================================== --- drupal-6.2.orig/modules/filter/filter.module 2008-07-01 09:28:22.000000000 +1000 +++ drupal-6.2/modules/filter/filter.module 2008-07-22 09:24:48.000000000 +1000 @@ -983,7 +983,7 @@ function filter_xss($string, $allowed_ta ( <(?=[^a-zA-Z!/]) # a lone < | # or - <[^>]*.(>|$) # a string that starts with a <, up until the > or the end of the string + <[^>]+(>|$) # a string that starts with a <, up until the > or the end of the string | # or > # just a > )%x', '_filter_xss_split', $string); From darrel.opry at gmail.com Tue Jul 22 00:23:35 2008 From: darrel.opry at gmail.com (Darrel O'Pry) Date: Mon, 21 Jul 2008 20:23:35 -0400 Subject: [development] Peculiar behavior of collapsible fieldset titles In-Reply-To: <1216675627.7280.45.camel@marcus> References: <1216675627.7280.45.camel@marcus> Message-ID: I experienced it, and shook my fist at it in rage... my issue I found to be a typo in some custom CSS though... On Mon, Jul 21, 2008 at 5:27 PM, Syscrusher wrote: > I've got a set of forms in Drupal 5 that are working correctly but have > an odd cosmetic error that I've been unable to track down. The code > worked in Drupal 4.7. > > Basically, I am assigning the title of some collapsible fieldsets > dynamically -- specifically, it's a project number and name that result > from a database query. The title should look like this: > > Subtasks for Project #1234 (Redesign Office LAN) > > For some reason, the titles are perfect when the fieldsets are expanded > but empty when collapsed (that is, they look like this): > > Subtasks for # () > > I think I know *what* is happening -- that is, the function that builds > the $form array is being called twice and has the variable unpopulated > one of the two times -- but I'm at a loss to figure out how that could > be happening. The database query not only populates the title of the > fieldset, but also its very presence depends on a row being retrieved. > So I would think that if the database query were somehow being skipped, > the fieldset would be entirely missing, not just empty! > > Has anyone seen something like this before? I realize I haven't given > enough detail or code to troubleshoot it entirely -- I'm not asking > someone to do my debugging for me, just looking for someone out there > who has seen something similar and can tell me in general terms what > might be happening. > > Thanks if anyone has suggestions. > > Kind regards, > > Scott > -- > Syscrusher > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080721/d655e8c0/attachment.htm From merlin at logrus.com Tue Jul 22 00:36:18 2008 From: merlin at logrus.com (Earl Miles) Date: Mon, 21 Jul 2008 17:36:18 -0700 Subject: [development] [PATCH] drupal/filter: fix broken multi-line HTML tags In-Reply-To: <1216683374.199267.203058232764.qpush@pingu> References: <1216683374.199267.203058232764.qpush@pingu> Message-ID: <48852B82.8070301@logrus.com> Jeremy Kerr wrote: > Currently, the filter module will mis-handle HTML tags that span more > than one line. For example: > > > link > > Will be filtered to: > > >link > > This is caused by the attempt to match '.>' in filter_xss(). Since > the . doesn't (by default) match a newline, the filter will try to > escape the closing > on the tag. > > This results in aggregated feeds with badly-formed HTML. > > This change removes the . match, so that a newline as the last > character in a opening HTML tag is accepted. So that we always require > at least one character in a tag, we also change the [^>]* to [^>]+ > > Signed-off-by: Jeremy Kerr > > --- > > modules/filter/filter.module | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: drupal-6.2/modules/filter/filter.module > =================================================================== > --- drupal-6.2.orig/modules/filter/filter.module 2008-07-01 09:28:22.000000000 +1000 > +++ drupal-6.2/modules/filter/filter.module 2008-07-22 09:24:48.000000000 +1000 > @@ -983,7 +983,7 @@ function filter_xss($string, $allowed_ta > ( > <(?=[^a-zA-Z!/]) # a lone < > | # or > - <[^>]*.(>|$) # a string that starts with a <, up until the > or the end of the string > + <[^>]+(>|$) # a string that starts with a <, up until the > or the end of the string > | # or > > # just a > > )%x', '_filter_xss_split', $string); Your work is respected and appreciated; please, though, can you create an issue in the drupal.org queue against the Drupal project (category filter.module) and attach this patch there? Then set it patch (code needs review). From jk at ozlabs.org Tue Jul 22 00:42:59 2008 From: jk at ozlabs.org (Jeremy Kerr) Date: Tue, 22 Jul 2008 10:42:59 +1000 Subject: [development] [PATCH] drupal/filter: fix broken multi-line HTML tags In-Reply-To: <48852B82.8070301@logrus.com> References: <1216683374.199267.203058232764.qpush@pingu> <48852B82.8070301@logrus.com> Message-ID: <200807221042.59970.jk@ozlabs.org> > Your work is respected and appreciated; please, though, can you > create an issue in the drupal.org queue against the Drupal project > (category filter.module) and attach this patch there? Then set it > patch (code needs review). Sure! will do that now. Cheers, Jeremy From syscrusher at 4th.com Tue Jul 22 01:52:19 2008 From: syscrusher at 4th.com (Syscrusher) Date: Mon, 21 Jul 2008 21:52:19 -0400 Subject: [development] Peculiar behavior of collapsible fieldset titles In-Reply-To: References: <1216675627.7280.45.camel@marcus> Message-ID: <1216691539.7280.64.camel@marcus> On Mon, 2008-07-21 at 20:23 -0400, Darrel O'Pry wrote: > I experienced it, and shook my fist at it in rage... my issue I found > to be a typo in some custom CSS though... Hmmmmm... My module uses a lot of custom CSS also. Perhaps I have the same issue. Could you contact me off-list and describe (or perhaps share the code) the issue you found? My module creates a lot of accounting-like tables, using CSS, so it is entirely possible I have such an issue. If nothing else, thanks for sparking an idea that had not occurred to me otherwise. Kind regards, Scott -- Syscrusher From jazepstein at gmail.com Tue Jul 22 03:36:06 2008 From: jazepstein at gmail.com (Jeremy Epstein) Date: Tue, 22 Jul 2008 13:36:06 +1000 Subject: [development] Issues with selecting radio buttons with JQuery In-Reply-To: <4884DBE0.9070508@logrus.com> References: <4884D59E.2070103@drob.org> <4884DBE0.9070508@logrus.com> Message-ID: Hey Dan, On Tue, Jul 22, 2008 at 4:56 AM, Earl Miles wrote: > I would recommend setting up a #process so that you can use your own version > of expand_radios() -- this will let you set things like the #name and #id of > each individual radio option individually. That could allow you to much more > easily deal with some of this oddness. For some examples of a custom #process callback, see the D6 version of the Category module (currently in Alpha). The category_menu sub-module has two custom overrides of expand_checkboxes(), which are there to add some jQuery to each box in a set of checkboxes (not _exactly_ the same as radios, but pretty close). Cheers, Jaza. From pushyamitra at gmail.com Tue Jul 22 04:03:31 2008 From: pushyamitra at gmail.com (Pushyamitra Navare) Date: Tue, 22 Jul 2008 09:33:31 +0530 Subject: [development] Can I Indicate failure from hook_user? In-Reply-To: References: Message-ID: On Mon, Jul 21, 2008 at 3:53 PM, Steven Jones wrote: > You'll probably want to do something with the $op == "validate" > argument of hook_user. Throw an error if you don't want the > update/insert to continue. Ok, thanks Steven! I will try to see how can I use hook_user's validate operation for my purpose. But can you tell me, is "validate" operation invoked for both "insert" and "update"? If yes, then how do I know in hook_user if it is being called for insert or for update? What parameter of hook_user should I check? I quickly went through documentation but did not find anything. Also, i need such a "validate" hook for "user delete" operation as well. Any way to do that? Thanks, Pushyamitra > On Mon, Jul 21, 2008 at 10:26 AM, Pushyamitra Navare >> If Drupal hooks currently don't check for return value, would it be good >> idea to add such a functionality? A "pre-operation" hook, which will >> indicate (boolean TRUE/ FALSE) if the operation should continue or not. Such >> a hook could be used for various validations when Drupal is integrated with >> some third-party applications. From jcfiala at gmail.com Tue Jul 22 04:09:47 2008 From: jcfiala at gmail.com (John Fiala) Date: Mon, 21 Jul 2008 22:09:47 -0600 Subject: [development] Can I Indicate failure from hook_user? In-Reply-To: References: Message-ID: On Mon, Jul 21, 2008 at 10:03 PM, Pushyamitra Navare wrote: > But can you tell me, is "validate" operation invoked for both "insert" > and "update"? If yes, then how do I know in hook_user if it is being > called for insert or for update? What parameter of hook_user should I > check? I quickly went through documentation but did not find anything. Yes, it's called for any modification of the user. It's an insert if the $account parameter doesn't have a uid, and it's an update if the $account parameter does have a uid. > Also, i need such a "validate" hook for "user delete" operation as > well. Any way to do that? I don't think there is any way - looking at user_delete, it doesn't call hook_user until the user is deleted. -- John Fiala From enboig at gmail.com Tue Jul 22 06:51:59 2008 From: enboig at gmail.com (=?ISO-8859-1?Q?Llu=EDs?=) Date: Tue, 22 Jul 2008 08:51:59 +0200 Subject: [development] clone a node In-Reply-To: <89c4d4df0807210646w4a34c03lceb364128899d577@mail.gmail.com> References: <45a29f450807210255u7aaebb6bn1cb6deab4594e69f@mail.gmail.com> <45a29f450807210444ka642b5au45595c478cc9b7b8@mail.gmail.com> <89c4d4df0807210646w4a34c03lceb364128899d577@mail.gmail.com> Message-ID: <45a29f450807212351p4e86b2fbq7aca1c8ec07995f1@mail.gmail.com> ok, I will do the way I wrote then. Thanks On Mon, Jul 21, 2008 at 3:46 PM, Bryan Ollendyke wrote: > There's a switch statement based ajax function in outline_designer > (http://drupal.org/project/outline_designer) called duplicate. The best way > to clone a node is to load it with drupal node_load then clear out the nid. > Then call node_save and it'll look at the node, see that there isn't a nid > and assign it one. The rest of the fields will be saved via the nodeapi > hooks. The function you wrote before looks very similar to the one I used. > > btopro > > On Mon, Jul 21, 2008 at 7:44 AM, Llu?s wrote: >> >> I have developed a simple group system (similar to OG in some ways, >> very diferent in others) so I need a user beeing able to import nodes >> from other groups to his own. >> To do so I have created a form which loads all the nodes from other >> groups as checkboxes. The checked items will be cloned to his group. >> >> I haven't tried node_clone, but I think it is UI oriented; I just need >> to clone a node knowing its ID (all group permissions, etc... are >> rewritten using nodeapi of my custom node). >> >> >> On Mon, Jul 21, 2008 at 11:59 AM, Nathaniel Catchpole >> wrote: >> > You could take a look at the node_clone module if you haven't already: >> > http://drupal.org/project/node_clone >> > >> > On Mon, Jul 21, 2008 at 10:55 AM, Llu?s wrote: >> >> I have developed a custom module with custom node types and I need to >> >> make users able to clone nodes; would this be a good way to do so? >> >> >> >> $clone=node_load($value); >> >> $clone->is_new = true; >> >> $clone->uid = $user->uid; >> >> unset($clone->nid); >> >> unset($clone->vid); >> >> node_save($clone); >> >> >> >> >> >> -- >> > >> >> >> >> -- >> *La vida ?s com una moneda, la pots gastar en el que vulguis per? >> nom?s una vegada. >> *La felicitat ha de ser compatible, compartible i cooperativa. >> *Envellim quan els records superen les il?lusions. >> *Als llocs desconeguts nom?s s'hi arriba per camins desconeguts. >> *Abans d'imprimir aquest missatge, pensa en el medi ambient. > > -- *La vida ?s com una moneda, la pots gastar en el que vulguis per? nom?s una vegada. *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les il?lusions. *Als llocs desconeguts nom?s s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient. From pushyamitra at gmail.com Tue Jul 22 09:46:15 2008 From: pushyamitra at gmail.com (Pushyamitra Navare) Date: Tue, 22 Jul 2008 15:16:15 +0530 Subject: [development] Can I Indicate failure from hook_user? In-Reply-To: References: Message-ID: Ok, cool. Thanks John and Steven! - Pushya On Tue, Jul 22, 2008 at 9:39 AM, John Fiala wrote: > On Mon, Jul 21, 2008 at 10:03 PM, Pushyamitra Navare > wrote: >> But can you tell me, is "validate" operation invoked for both "insert" >> and "update"? If yes, then how do I know in hook_user if it is being >> called for insert or for update? What parameter of hook_user should I >> check? I quickly went through documentation but did not find anything. > > Yes, it's called for any modification of the user. It's an insert if > the $account parameter doesn't have a uid, and it's an update if the > $account parameter does have a uid. > >> Also, i need such a "validate" hook for "user delete" operation as >> well. Any way to do that? > > I don't think there is any way - looking at user_delete, it doesn't > call hook_user until the user is deleted. > > -- > John Fiala > From vuthecuong at luvina.net Tue Jul 22 10:04:55 2008 From: vuthecuong at luvina.net (Vu The Cuong) Date: Tue, 22 Jul 2008 17:04:55 +0700 Subject: [development] can I build multi-hierachy node Message-ID: <3DADD35EDAE49145B9BA1AB44844771160885B@lvsrv_dns.luvina.net> In Drupal I can have simple navigation such as Home->Blog But I want to more deep hierarchy like below: Home->Product->ABCproduct list->When click any link on this list->ABC products detail individual displayed. So my questions are: - Is there a way to implement this without coding? - In order to implement this, do I need to create new content type named Product? If yes, Is there a way to create this content-type without coding? Thanks in advanced. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080722/835061bf/attachment.htm From catch56 at googlemail.com Tue Jul 22 10:13:15 2008 From: catch56 at googlemail.com (Nathaniel Catchpole) Date: Tue, 22 Jul 2008 11:13:15 +0100 Subject: [development] can I build multi-hierachy node In-Reply-To: <3DADD35EDAE49145B9BA1AB44844771160885B@lvsrv_dns.luvina.net> References: <3DADD35EDAE49145B9BA1AB44844771160885B@lvsrv_dns.luvina.net> Message-ID: > So my questions are: > > - Is there a way to implement this without coding? If you're asking general site building questions and aren't sure if they require code or not please direct them to http://lists.drupal.org/listinfo/support or the support forum on drupal.org -- However, everything you described could be done with http://drupal.org/project/views - or just the taxonomy module in core. > > - In order to implement this, do I need to create new content type > named Product? Probably. >If yes, > > Is there a way to create this content-type without coding? Yes - admin/content/types Nathaniel From maciej.perlinski at gmail.com Tue Jul 22 10:35:38 2008 From: maciej.perlinski at gmail.com (Maciej Perlinski) Date: Tue, 22 Jul 2008 12:35:38 +0200 Subject: [development] Taxonomy term moderation Message-ID: <58a72c9f0807220335h1e1ebb3by99b03726008151d5@mail.gmail.com> Hello there, i went through all taxonomy associated modules descriptions and haven't found this feature, we need to let users suggest taxonomy term for their entries, if they suggest it their node already has association with it but the term is waiting for approval as soon as term got approved than its shown on in the vocabulary tree and in the node published by the user. Any suggestion on implementation ? should we approach it using db_query rewrite and made possibility to have term published /unpublished state or via making 2 vocabularies and than try to sync them(this seems on the beginning easier but taking into account we will get alot of terms and not all of them will be approved that can lead to pretty inconsistent production vocabulary?) Do you have any experience with similar functionality or any advices ? -- - Mac From bharanikumariyerphp at gmail.com Tue Jul 22 11:05:52 2008 From: bharanikumariyerphp at gmail.com (bharani kumar) Date: Tue, 22 Jul 2008 16:35:52 +0530 Subject: [development] can I build multi-hierachy node In-Reply-To: <3DADD35EDAE49145B9BA1AB44844771160885B@lvsrv_dns.luvina.net> References: <3DADD35EDAE49145B9BA1AB44844771160885B@lvsrv_dns.luvina.net> Message-ID: <2240033d0807220405j251204cfr2850e4757a44cd53@mail.gmail.com> then use the there is a module like dhtml_menu http://drupal.org/project/dhtml_menu i thing this link may help On Tue, Jul 22, 2008 at 3:34 PM, Vu The Cuong wrote: > In Drupal I can have simple navigation such as > > Home->Blog > > But I want to more deep hierarchy like below: > > Home->Product->ABCproduct list->When click any link on this list->ABC > products detail individual displayed. > > > > So my questions are: > > - Is there a way to implement this without coding? > > - In order to implement this, do I need to create new content > type named Product? If yes, > > Is there a way to create this content-type without coding? > > > > Thanks in advanced. > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.drupal.org/pipermail/development/attachments/20080722/0ae02994/attachment.htm From earnie at users.sourceforge.net Tue Jul 22 13:45:05 2008 From: earnie at users.sourceforge.net (Earnie Boyd) Date: Tue, 22 Jul 2008 09:45:05 -0400 Subject: [development] Can I Indicate failure from hook_user? In-Reply-To: References: Message-ID: <20080722094505.47cufnugxpd4o0o8@mail.progw.org> Quoting John Fiala : > > I don't think there is any way - looking at user_delete, it doesn't > call hook_user until the user is deleted. > Well that isn't too friendly. If you don't want the user to be deleted you could use a hook_form_alter to hide or remove the button. Earnie -- http://for-my-kids.com/ -- http://give-me-an-offer.com/ From pushyamitra at gmail.com Tue Jul 22 14:48:11 2008 From: pushyamitra at gmail.com (Pushyamitra Navare) Date: Tue, 22 Jul 2008 20:18:11 +0530 Subject: [development] Can I Indicate failure from hook_user? In-Reply-To: <20080722094505.47cufnugxpd4o0o8@mail.progw.org> References: <20080722094505.47cufnugxpd4o0o8@mail.progw.org> Message-ID: On Tue, Jul 22, 2008 at 7:15 PM, Earnie Boyd wrote: > Well that isn't too friendly. If you don't want the user to be deleted you > could use a hook_form_alter to hide or remove the button. > Well, ideally I would like the pre-user-delete-validate function to be called for every user. If I disable button etc. through hook_form_alter, then either all users will be deleted or none. I won't be able to validate individual users and decide to delete or not delete that user. I actually ended up modifying user.module code and calling my own validate function just before deleting user. Based on validate function's result I either delete the user or just register error. ( The obvious pain would arise when I wish to upgrade to newer Drupal version in future. I would have patch the new user.module as wel. ). For now, it's working... Pushya From anthony at thrillist.com Tue Jul 22 15:00:51 2008 From: anthony at thrillist.com (Anthony Wlodarski) Date: Tue, 22 Jul 2008 11:00:51 -0400 Subject: [development] Proper use of drupal execute to submit a cck node type manually. Message-ID: <4885F623.8030805@thrillist.com> This is my first post on this mailing list so I might as well make it an interesting one... I am currently using drupal_execute to programatically save/update/insert CCK node types. The problem is that the CCK node types never update or get saved. Here is the snippet of code that is having me scratch my head:



    // we check to see if the item has an existing nid if so then just 
update the current item
    if($item['nid'] != 0)
    {
      // load the existing node
      $node = node_load($item['nid']);

      // we must create the item form manually then call drupal_execute 
on that
      $item_form = array();
      $item_form['title'] = $item['title'];
      $item_form['body'] = $item['body_filter'];
      $item_form['field_item_address1'][0]['value'] = 
$item['field_item_address1'];
      $item_form['field_item_date'][0]['value'] = 
strtotime($item['field_item_date']);
      //todo the two taxonomies
      $item_form['field_item_latitude'][0]['value'] = 
$item['field_item_latitude'];
      $item_form['field_item_longitude'][0]['value'] = 
$item['field_item_longitude'];

      // debug stuff...*/
      print "" . print_r($item, TRUE) . "
##########
";
      print "" . print_r($item_form, TRUE) . 
"
##########
";
      print "" . print_r($node, TRUE) . "
##########
";
   
      //drupal_process_form('item_node_form', $item_form2);
      $error = drupal_execute('item_node_form', $item_form, $node);
      print "Error:
$error";
    }
    else // we have a new item to create
    {
        // todo list
    }