On 6/5/07, <b class="gmail_sendername">Mark Fredrickson</b> <<a href="mailto:mark.m.fredrickson@gmail.com">mark.m.fredrickson@gmail.com</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Flame war aside, I think there are some good points in this thread.<br>Perhaps someone can clarify two points:<br><br>1. Is it kosher to add columns to other modules' tables? E.g. Is it ok<br>for comment to add it's statistics to the node table. Similarly, I
<br>could imagine the stats module would want to add summary information,<br>and perhaps other modules as well.</blockquote><div><br>If one module is core and one is contrib, then it is not kosher (IMO). Actually<br>it is not the sanctioned way of doing things, but no one stops a module
<br>author from doing this or a site from having their own "schema fork". There<br>are consequences when upgrading, and they should be prepared to live<br>with their decisions.<br><br>If both modules are from core, then why not? We avoid the performance
<br>issues caused by having two tables, and are actually more normalized <br>that way.<br> </div></div>-- <br><a href="http://2bits.com">2bits.com</a><br><a href="http://2bits.com">http://2bits.com</a><br>Drupal development, customization and consulting.