<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><BR><DIV><DIV>On 2-Jul-07, at 8:22 AM, Augustin (Beginner) wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><FONT class="Apple-style-span" color="#0000DD"><FONT class="Apple-style-span" color="#006312">The status of a "trustworthy patch reviewer" can be earned. It is a lot</FONT></FONT></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">of hard work.</DIV></BLOCKQUOTE><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Well, there is a permission for "set issue status patch (ready to commit)"<SPAN class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">in<SPAN class="Apple-converted-space"> </SPAN>?q=admin/user/access .</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Why not make good use of it?</DIV></BLOCKQUOTE><DIV><BR class="khtml-block-placeholder"></DIV><DIV>The biggest argument against this that I can think of is that most of the people who do these kinds of good patch reviews are also some of our best developers (Jeff Eaton, chx, Moshe...). And instead of developing new cool features for Drupal, or fixing particularly gnarly bugs, they would now be collectively spending their time not only reading every single issue in the queue, but also thoroughly testing every patch in the queue, enough to give their blessing. Giving patches a thorough testing is A LOT of work -- at least a half an hour per patch for anything non-trivial -- and the more this is spread around, the better.</DIV></DIV><BR><DIV>-Angie</DIV><DIV><BR class="khtml-block-placeholder"></DIV></BODY></HTML>