On 7/3/07, <b class="gmail_sendername">Dries Buytaert</b> <<a href="mailto:dries.buytaert@gmail.com">dries.buytaert@gmail.com</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>On 02 Jul 2007, at 21:05, Augustin (Beginner) wrote:<br>> My main point is: please do listen to people who are better known<br>> than I am,<br>> when they talk about some overdue systemic changes.<br><br>The main reason that keeps patches from getting committed faster is
<br>the lack of good reviews. The main challenge is to increase the<br>amount and the quality of patch reviews and to reduce the number of<br>silly "+1"s.<br><br>People posting a "+1" waste a lot of people's time -- it makes dozens
<br>of people recheck the issue, and it does not buy you any more respect<br>or trust. If we can stop posting "+1"s (or "subscribe"s for that<br>matter), that would save me some time, it would increase the signal
<br>to noise ratio and it would avoid the false sense of support.<br></blockquote></div><br>Dries<br><br>With all due respect to your point, the "+1 without a review" also has value.<br>Obviously, it does not mean that the code is great, since a code review was
<br>not done.<br><br>It does however adds a vote on the functionality from a high level, regardless<br>of the implementation details. The person who needs this feature may not be<br>a coder, or they may be one, but have no time to review the code or test it.
<br clear="all"><br>So, I propose that people can say "+1 on the concept" or "+1 from a feature<br>point of view", making it clear that they did not review the code but like/need<br>the feature. (and for those reading this, I can see a "if you care so much then
<br>why don't you review the code" comment coming. Remember that some people <br>just can't or are under time constraints or whatever).<br><br>Others (who can do code reviews) should take this as "one person sees this
<br>as desirable", and take it on from there for ripping the code apart, or having<br>it Morbused.<br><br>Of course, others who are against the feature can also say so, as we usually see.<br>-- <br><a href="http://2bits.com">
2bits.com</a><br><a href="http://2bits.com">http://2bits.com</a><br>Drupal development, customization and consulting.