<div dir="ltr">Ryan, thanks!<br><br>I started another thread on this subject not knowing these pages exist.<br><br>~Jerad<br><br><div class="gmail_quote">On Thu, Aug 14, 2008 at 9:30 AM, Ryan Cross <span dir="ltr"><<a href="mailto:drupal@ryancross.com">drupal@ryancross.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">On Thu, Aug 14, 2008 at 10:53 PM, Ivan Sergio Borgonovo<br>
<<a href="mailto:mail@webthatworks.it">mail@webthatworks.it</a>> wrote:<br>
<br>
> There is not a compact knowledge base of several techniques that may<br>
> make more profitable for people that already maintain drupal sites<br>
> to contribute to core and contrib. I think that most developers are<br>
> still applying common wisdom and their own hand made recipes.<br>
><br>
<br>
</div>Actually, there is....<br>
<a href="http://drupal.org/patch/review" target="_blank">http://drupal.org/patch/review</a><br>
<br>
and in more general there is the entire contributors guide handbook about this.<br>
<div class="Ih2E3d"><br>
><br>
> If tests are already automatically made on submitted patches,<br>
> preparing a testing environment isn't so critical for a patch<br>
> reviewer, but it could come handy for a developer.<br>
><br>
<br>
</div>One of the major reasons for push to get unit tests written is so that<br>
this basic type of review can be automated within the issue queue. You<br>
can already load these tests yourself and test them automatically.<br>
<div class="Ih2E3d"><br>
> The material about how to put up a dev/review environment is sparse.<br>
<br>
</div>again not correct..... Setting up a test environment to review<br>
patches: <a href="http://drupal.org/node/28245" target="_blank">http://drupal.org/node/28245</a><br>
<br>
However, I think that most of this problem is not really a lack of<br>
documentation for doing these reviews. Anyone that is sufficiently<br>
interested can find this stuff out or ask someone and learn very<br>
easily. I think more of this issue is community and infrastructure<br>
based.<br>
<font color="#888888"><br>
-Ryan<br>
</font></blockquote></div><br></div>