On Fri, Oct 31, 2008 at 8:10 AM, Tomas Fulopp <span dir="ltr"><<a href="mailto:tomi@vacilando.org">tomi@vacilando.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>Just my two cents - while there are systemic reasons why this happens, the community needs to be able to see the issue purely from Markus's point of view. He seems to be a devoted Drupal developer who has put a lot of his time into developing patches only to see that they are not checked and not committed. That is to say, he has provided what he believes are solutions for various problems in several versions of Drupal, but there is nobody to actually apply them for the benefit of others. I am amazed he wrote such a polite and friendly message, asking what did he do wrong.</div>
<div><br></div><div>I think it is not enough to be just defensive and say core maintainers are busy with Drupal 7 (thousands of people are using D5 and D6), advise to check other people's patches and they might check yours (I know it works that way, but I think it is not healthy; he already provided a service), or provide statistics on how many people complain and don't review (it is a fact it is easier and faster to spot problems than to solve them). I would be surprised if developers like Markus became a trifle discouraged from providing new patches.</div>
<div><br></div><div>To summarize: this is just to show that the answers provided in this thread are unlikely to provide an efficient solution for developers like Markus. We must not be satisfied with such answers and keep searching more effective methods of recognizing and applying results of good coding. And I am sure we'll manage, for this is a marvellous community.</div>
<div><br></div><div>Tomáš</div></blockquote><div><br>So what do you want from a bunch of volunteers? Some who take on the extraordinary responsibility of being the Drupal maintainer? Have you had to work on an issue queue? If you're really concerned about your patch or code, promote it. There are many other people vying for the committers' bandwidth, make it as easy as possible for them. Work to get your patch well vetted by your peers. Make sure it is up to coding standards, well documented, and includes tests. Make sure your issue accurately and succinctly sums up What is broken, how to reproduce the issue, you expected results, what the code is actually doing, and how your solution fixes the problem. Be thorough. <br>
<br>.darrel.<br><br><br></div></div>