<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:arial, helvetica, sans-serif;font-size:12pt"><DIV></DIV>
<DIV>Pierre, if the data was that important, I would add it to another table and maybe even normalize it. This is stuff like the name and company of the commenter - both about as important as the email address that is already there. This is just not serious stuff in this case.<BR> </DIV>
<P><FONT face="bookman old style, new york, times, serif" color=#ff007f size=4><EM><STRONG>Nancy E. Wichmann, PMP</STRONG></EM></FONT></P>
<P><FONT face="arial, helvetica, sans-serif">Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.</FONT></P>
<DIV><BR></DIV>
<DIV style="FONT-SIZE: 12pt; FONT-FAMILY: arial, helvetica, sans-serif"><BR>
<DIV style="FONT-SIZE: 10pt; FONT-FAMILY: arial, helvetica, sans-serif"><FONT face=Tahoma size=2>
<HR SIZE=1>
<B><SPAN style="FONT-WEIGHT: bold">From:</SPAN></B> Pierre Rineau <pierre.rineau@makina-corpus.com><BR><B><SPAN style="FONT-WEIGHT: bold">To:</SPAN></B> development@drupal.org<BR><B><SPAN style="FONT-WEIGHT: bold">Sent:</SPAN></B> Mon, July 12, 2010 12:33:35 PM<BR><B><SPAN style="FONT-WEIGHT: bold">Subject:</SPAN></B> Re: [development] (no subject)<BR></FONT><BR>Le lundi 12 juillet 2010 à 09:19 -0700, nan wich a écrit :<BR>> <BR>> Is there an official stance on using hook_schema_alter to add columns<BR>> to core tables? For example, we collect additional data on anonymous<BR>> comments and want to actually save that data. Rather than creating<BR>> another table (and subsequent JOINs), I'd just as soon stuff that data<BR>> into the comments table, where it belongs. Should we ever disable<BR>> comments (unlikely), we probably wouldn't mind losing that data too.<BR>> <BR>> Nancy E. Wichmann, PMP<BR>> <BR>>
Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L.<BR>> King, Jr.<BR><BR>I would say, create a new table instead of populating core one.<BR><BR>Each time you'll update your statistics, it will update the core<BR>database row, which should have not been updated. It will break most of<BR>the DBMS query cache, you will drastically lower your site performances<BR>if you have a lot of data. Ever worst, some DBMS do important physical<BR>row moves on each update (like PostgreSQL), this is no good, if you<BR>don't have to update a row, don't update it.<BR><BR>You will may also experience some weird behaviors, like other modules<BR>dropping rows and recreating them identically, then loosing your<BR>statistics if they do not use drupal_write_record().<BR><BR>Pierre.<BR><BR><BR><BR></DIV></DIV></div></body></html>