[support] PHP 5.3 upgrade problems

[andy baxter]

Earnie Boyd wrote:
> Quoting andy baxter <andy at earthsong.free-online.co.uk>:
>   
>> I assume that the last declaration is the relevant one because of the
>> '&$element'. This function looks like this:
>>
>> /**
>>  * FormAPI theme function. Theme the output of an image field.
>>  */
>> function theme_imagefield_widget(&$element) {
>>   drupal_add_css(drupal_get_path('module', 'imagefield')
>> .'/imagefield.css');
>>   return theme('form_element', $element, $element['#children']);
>> }
>>
>>
>>     
>
> It isn't necessarily the definition of the function that is wrong.  It  
> is the data being passed to the function as it is defined that is the  
> problem.  You need to find all the uses of theme_imagefield_widget and  
> make sure that the data being used in the parameter is a variable.
>   
This is what I was afraid of - there are quite a few of these errors 
coming up. Most seem to be non-fatal, but I still would like to sort 
them out if possible.

I have seen it suggested just to remove the & in cases where the 
function is expecting an object. Does this make sense in PHP terms?

andy