<div dir="ltr">I think it's better to distinguish between release upgrades, security upgrades and module upgrades (upgrades for individual modules).<br><br>On the big upgrade (release upgrade) from 4.7 to 5.x, of course, the best practice was to disable all modules, basically due to the objective of making sure the upgrade to a new release was working, and also because modules had to be completely rewritten for the new release.<br>
<br>Also, the idea was to enable each contributed module one by one, in order to know what when wrong, if it did, and when it went wrong: specifically with which module lay the problem. And doing a database dump each time, you can always go back to a working scenario.<br>
<br>If you leave all modules enabled in a release upgrade you are almost definitely going to have problems and worse, you are not going to know where the problems come from.<br><br>Imagine someone upgrading from Drupal 5.x to Drupal 6.x; this is a migration, not an upgrade. Many things are going to have to be pinpointed and taken care of.<br>
<br>With security releases, I do not disable modules and have never had any problem.<br><br>On 4.7.x to 5.x see my article at <a href="http://awebfactory.com.ar/node/223">http://awebfactory.com.ar/node/223</a> (based on webchick's video from Lullabot)<br>
<br>Victor Kane<br><a href="http://awebfactory.com.ar">http://awebfactory.com.ar</a><br><br><div class="gmail_quote">On Mon, Jul 14, 2008 at 6:14 PM, KOBA | Hans Rossel <<a href="mailto:info@koba.be">info@koba.be</a>> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Interesting discussion.<br>
<br>
I also never disable modules when upgrading. I have never lost data<br>
when I disabled them originally, but as far as I remember some<br>
configurations of CCK were lost. But that was in the early days of cck<br>
and Drupal 4.7. Since then I never disabled modules and never had<br>
problems (always with backup ready). Its also quite annoying when you<br>
have more modules uploaded than enabled to have to write down which<br>
modules are needed for each installation.<br>
<br>
it could be good to hear from somebody who always does it right and<br>
disables all modules before upgrading that it has never caused<br>
problems, just to add some counterweight to this thread.<br>
<br>
Hans<br>
<a href="http://www.koba.be" target="_blank">www.koba.be</a><br>
<br>
2008/7/14, Earnie Boyd <<a href="mailto:earnie@users.sourceforge.net">earnie@users.sourceforge.net</a>>:<br>
<div><div></div><div class="Wj3C7c">> Quoting Brian Choc <<a href="mailto:bchoc@t4tcolorado.org">bchoc@t4tcolorado.org</a>>:<br>
><br>
>> I found that disabling modules during minor upgrades causes data loss<br>
>> consistently under specific circumstances, during earlier updates (e.g.<br>
>> 5.2,<br>
>> 5.3). I observed that any module-supplied node type would drop all the<br>
>> data<br>
>> in any assigned CCK fields when disabling & upgrading. For example, if<br>
>> one<br>
>> had a simplenews node with an "editor" cck field attached to it, one would<br>
>> lose all "editor" information. However, the basic simplenews node data<br>
>> would be kept, as would any cck fields attached to standard nodes. Only<br>
>> the<br>
>> combo of cck + module-supplied-node-type seemed to cause problems.<br>
>><br>
><br>
> So what you're indicating is that modules implementing hook_node_info<br>
> will loose the node_type row and thusly the nodes of that type. This<br>
> would then be a critical bug in the core base system. Or perhaps your<br>
> incident is related to only one of the CCK fields modules and then the<br>
> critical bug would lie with that module. Disabling a module should not<br>
> under any circumstance cause data to be removed.<br>
><br>
> That said, I do not disable modules either when upgrading from Drupal<br>
> version 5.x to Drupal version 5.y. However, that isn't the documented<br>
> method and the documented method needs to work.<br>
><br>
> Earnie -- <a href="http://for-my-kids.com/" target="_blank">http://for-my-kids.com/</a><br>
> -- <a href="http://give-me-an-offer.com/" target="_blank">http://give-me-an-offer.com/</a><br>
><br>
> --<br>
> [ Drupal support list | <a href="http://lists.drupal.org/" target="_blank">http://lists.drupal.org/</a> ]<br>
><br>
<br>
<br>
</div></div>--<br>
Hans Rossel<br>
KOBA Webdevelopment<br>
Kerkstraat 228<br>
9050 Gent<br>
09-334.52.60<br>
0472-79.32.16<br>
<a href="http://www.koba.be" target="_blank">www.koba.be</a><br>
<a href="mailto:info@koba.be">info@koba.be</a><br>
<div><div></div><div class="Wj3C7c">--<br>
[ Drupal support list | <a href="http://lists.drupal.org/" target="_blank">http://lists.drupal.org/</a> ]<br>
</div></div></blockquote></div><br></div>