Mabey we should offer free "learn PHP ultra-quick" ebooks for themers?<br><br>It's a shame there isn't a way to query variables and other php bits and knowledge from drupaldocs, as well as functions.<br><br>Robin
<br><br><div><span class="gmail_quote">On 12/14/05, <b class="gmail_sendername">Trae McCombs</b> <<a href="mailto:occy@occy.net">occy@occy.net</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
too bad I don't know PHP, as it would be nice for me to comprehend these<br>theme changes you guys are discussing. I think this is the disconnect<br>we typically have between themers and developers.<br><br>People will carry on a conversation about something and perhaps it'll
<br>seem like a good idea at the time, until someone finally codes it, and<br>then we go... "huh"? heh<br><br>I'm simply saying to keep us non-hackers in mind while having all these<br>discussions.<br><br>Thank you, drive through.
<br>Trae<br><br><br>Jose A. Reyero wrote:<br>> Bčr Kessels wrote:<br>><br>><br>>>Hi,<br>>><br>>>way too often i have to hack modules or even core (upload) to make it *not*<br>>>append HTML to $node->body.
<br>>><br>>>I think this practice of appending stuff to the body is very bad, since it<br>>>makes it impossible to add thatdata elsewhere, without duplication.<br>>><br>>><br>>><br>>
<br>> Yep, I agree, same problem here<br>><br>><br>>>I think that teh best option is an additional variable in $node<br>>>$node->extra<br>>>containing structured data added by all the modules.
<br>>>$node->extra->upload could, for example contain that uplaod/attachement table,<br>>>that is now hardcoded to the body.<br>>><br>>><br>>><br>>><br>><br>> First I would like to insist in that *all html* produced should be
<br>> themeable.<br>><br>> About this specific issue, I think we could<br>> a) Just use themeable functions, that can be overridden, like a<br>> 'theme_upload_node_body' but, anyway, don't store it into node->body,
<br>> but in node->output or similar<br>> b) Use that $node->extra->upload you propose but maybe better make it an<br>> array, $node->extra['upload'] so we can use a simple 'implode' at the<br>> end. Maybe weights could be useful here too
<br>><br>> The ideal would be using both, themeable functions that produce<br>> structured data, but any of them used separately would just fix the<br>> problem. However, the way to go, thinking big, would be kind of
<br>> 'generalized form API' that could be useful to build any object -page,<br>> block, node..- as structured data and then render it to HTML.<br>><br>><br>>>Waht do others think<br>>>Bčr<br>>>
<br>>>PS: Im not to sure about tis crossposting thing, but there are loads of theme<br>>>and developers issues; is it safe to assume that interested parties at least<br>>>read development? (so that we can keep this on development)
<br>>><br>>><br>><br>><br><br>--<br>Trae "occy" McCombs || <a href="http://occy.net/">http://occy.net/</a><br> Founder - <a href="http://Themes.org">Themes.org</a> // <a href="http://Linux.com">
Linux.com</a><br> CivicSpaceLabs - <a href="http://civicspacelabs.org/">http://civicspacelabs.org/</a><br></blockquote></div><br><br clear="all"><br>-- <br>Robin Monks,<br>CSL Web Administrator<br><a href="mailto:robin@civicspacelabs.org">
robin@civicspacelabs.org</a>