From Drupal-Devel@iStyledThis.nl Thu Apr 14 11:28:47 2005
From: Stefan Nagtegaal <Drupal-Devel@iStyledThis.nl>
To: development@drupal.org
Subject: [drupal-devel] Improve Drupal themability
Date: Thu, 14 Apr 2005 11:28:48 +0000
Message-ID: <8797f8b258a19bcff7e927895a76f6f7@iStyledThis.nl>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1876248561190270552=="

--===============1876248561190270552==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

All,

to improve theming of drupal I would like to introduce two new 
functions, which are theme_list() and theme_list_item()..

function theme_list($items = array(), $id) {
   if (isset($items)) {
     $output .= '<ul id="'. $id .'">';
     foreach ($items as $item) {
       $output .= theme('list_item', $item);
     }
     $output .= '</ul>';
   }
   return $output;
}

function theme_list_item($item, $class = NULL) {
   return '<li class="'. $class .'">'. $item .'</li>';
}

These two functions will help us, theme drupal. Every list is getting a 
unique id like $module-$method. For example we get:

<ul id="book navigation">
   <li class="leaf"><a href="#">...</a></li>
   <li class="leaf"><a href="#">...</a></li>
   <li class="leaf"><a href="#">...</a></li>
</ul>

With these two functions we can get all hardcoded lists (<ul><li>) out 
of drupal..
At the end, a lot of theme function will be deprecated. you can think 
about theme_status_messages(), theme_node_list().

Combining this with the modified theme_box()-approach of Ber Kessels 
(http://drupal.org/node/15332) we can theme almost anything we want and 
how we want, with less extraneous markup..

I would like to know what you guys think about this, and dicuss before 
having some major patches hitting the patch queue..



Stefan.




--===============1876248561190270552==--


From weitzman@tejasa.com Thu Apr 14 13:36:38 2005
From: Moshe Weitzman <weitzman@tejasa.com>
To: development@drupal.org
Subject: Re: [drupal-devel] Improve Drupal themability
Date: Thu, 14 Apr 2005 13:36:39 +0000
Message-ID: <425E7182.1070003@tejasa.com>
In-Reply-To: <8797f8b258a19bcff7e927895a76f6f7@iStyledThis.nl>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5764404047421353804=="

--===============5764404047421353804==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

We already have theme_item_list(). If you need more features from it, 
please submit a patch.

> about theme_status_messages(), theme_node_list().

theme_node_list() and theme_user_list() are useful wrapper functions for 
theme_item_list(). They are useful because the themer themer knows what 
type of data he is dealing with and can universally style accordingly. 
Consider prefixing all blog posts with a special icon, or prefixing 
every user with an online/offline indicator. That is easy to do today 
but would be hard if you you go to a your proposed scheme.

--===============5764404047421353804==--


From Drupal-Devel@iStyledThis.nl Thu Apr 14 13:43:48 2005
From: Stefan Nagtegaal <Drupal-Devel@iStyledThis.nl>
To: development@drupal.org
Subject: Re: [drupal-devel] Improve Drupal themability
Date: Thu, 14 Apr 2005 13:43:49 +0000
Message-ID: <a2879c800c54d35ab44f57c7404e954d@iStyledThis.nl>
In-Reply-To: <425E7182.1070003@tejasa.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4138984072383939956=="

--===============4138984072383939956==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


Op 14-apr-05 om 15:34 heeft Moshe Weitzman het volgende geschreven:

> We already have theme_item_list(). If you need more features from it, 
> please submit a patch.
>
>> about theme_status_messages(), theme_node_list().
>
> theme_node_list() and theme_user_list() are useful wrapper functions 
> for theme_item_list(). They are useful because the themer themer knows 
> what type of data he is dealing with and can universally style 
> accordingly. Consider prefixing all blog posts with a special icon, or 
> prefixing every user with an online/offline indicator. That is easy to 
> do today but would be hard if you you go to a your proposed scheme.
Why would that be hard? Every block has a unique id..

With the approach I took, it is just as easy to theme the things you 
mentioned above. the only things is, that we do not add more markup as 
strictly needed, but ofcourse your always free todo whatever you like 
in your themes.



Stefan.


--===============4138984072383939956==--


From weitzman@tejasa.com Thu Apr 14 13:49:11 2005
From: Moshe Weitzman <weitzman@tejasa.com>
To: development@drupal.org
Subject: Re: [drupal-devel] Improve Drupal themability
Date: Thu, 14 Apr 2005 13:49:12 +0000
Message-ID: <425E7472.7010007@tejasa.com>
In-Reply-To: <a2879c800c54d35ab44f57c7404e954d@iStyledThis.nl>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2481951152078345125=="

--===============2481951152078345125==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Stefan Nagtegaal wrote:
> 
> Op 14-apr-05 om 15:34 heeft Moshe Weitzman het volgende geschreven:
> 
>> We already have theme_item_list(). If you need more features from it, 
>> please submit a patch.
>>
>>> about theme_status_messages(), theme_node_list().
>>
>>
>> theme_node_list() and theme_user_list() are useful wrapper functions 
>> for theme_item_list(). They are useful because the themer themer knows 
>> what type of data he is dealing with and can universally style 
>> accordingly. Consider prefixing all blog posts with a special icon, or 
>> prefixing every user with an online/offline indicator. That is easy to 
>> do today but would be hard if you you go to a your proposed scheme.
> 
> Why would that be hard? Every block has a unique id..

Um, I have to find out all those IDs. And when I add a new module, I 
have to know that its block or page has a user list and add that to my 
stylesheet. theme_user_list() allows the themer to once and for all 
define how a user list should be displayed. Considering that your theme 
expert is sometimes unavailable after the site is launched, I think the 
theme function approach is worthwhile.

Note that these 2 approaches are not incompatible. Everything runs 
through theme_item_list() today. So just add your proposed logic there. 
I just want to refute your notion that theme_node_list() and its friends 
would be deprecated by your proposed change. They won't be.

--===============2481951152078345125==--


From Drupal-Devel@iStyledThis.nl Thu Apr 14 14:33:13 2005
From: Stefan Nagtegaal <Drupal-Devel@iStyledThis.nl>
To: development@drupal.org
Subject: Re: [drupal-devel] Improve Drupal themability
Date: Thu, 14 Apr 2005 14:33:14 +0000
Message-ID: <079d3355f22d318b2aabd2839118ef8c@iStyledThis.nl>
In-Reply-To: <425E7472.7010007@tejasa.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4213486597127435943=="

--===============4213486597127435943==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


Op 14-apr-05 om 15:47 heeft Moshe Weitzman het volgende geschreven:

> Stefan Nagtegaal wrote:
>> Op 14-apr-05 om 15:34 heeft Moshe Weitzman het volgende geschreven:
>>> We already have theme_item_list(). If you need more features from 
>>> it, please submit a patch.
>>>
>>>> about theme_status_messages(), theme_node_list().
>>>
>>>
>>> theme_node_list() and theme_user_list() are useful wrapper functions 
>>> for theme_item_list(). They are useful because the themer themer 
>>> knows what type of data he is dealing with and can universally style 
>>> accordingly. Consider prefixing all blog posts with a special icon, 
>>> or prefixing every user with an online/offline indicator. That is 
>>> easy to do today but would be hard if you you go to a your proposed 
>>> scheme.
>> Why would that be hard? Every block has a unique id..
>
> Um, I have to find out all those IDs. And when I add a new module, I 
> have to know that its block or page has a user list and add that to my 
> stylesheet. theme_user_list() allows the themer to once and for all 
> define how a user list should be displayed. Considering that your 
> theme expert is sometimes unavailable after the site is launched, I 
> think the theme function approach is worthwhile.
>
> Note that these 2 approaches are not incompatible. Everything runs 
> through theme_item_list() today. So just add your proposed logic 
> there. I just want to refute your notion that theme_node_list() and 
> its friends would be deprecated by your proposed change. They won't 
> be.

Don't forget that the classes do _not_ have to be unique so the classes 
will stay to theme things the way it was.. But, I am only introducing 
an required id to the <ul> which let us do the same as we did before on 
the surrounding <div>.

Maybe it's
Stefan


--===============4213486597127435943==--