The other place that could benefit from checking which engines are
available is the temporary table query in db_query_temporary()

It now has:

$query = preg_replace('/^SELECT/i', 'CREATE TEMPORARY TABLE '.
$tablename .' Engine=HEAP SELECT',

Would be great to check if HEAP (Memory) exists first before doing so.

So common code for engine checking can be reused.

On 6/5/07, James Walker <walkah@walkah.net> wrote:
On 6/4/07 5:36 AM, Dries Buytaert wrote:
>
> On 04 Jun 2007, at 05:11, Khalid Baheyeldin wrote:
>> An option at install time, such as a drop down list of engines that
>> are supported on the server, and selecting one is more appropriate.
>> It will require preg stuff to change the engine. Or using the new
>> schema, we can add that more elegantly (not sure how hard would
>> it be, but can't be that hard).
>
> I agree with this.  Make it an option in the 'advanced settings'
> fieldset on step 3 of the installer (setup database).

+1 - Yeah, drop down should only include available engines, and it
should be fairly simple to add thanks to schema.

--
James Walker :: http://walkah.net/ :: xmpp:walkah@walkah.net



--
2bits.com
http://2bits.com
Drupal development, customization and consulting.