I don't think there is a problem with it at all. I've done it before. That's what its there for.

To build on Brian's comments though you should use it in conjunction with hook_install/uninstall using db_add/drop_field in those functions and letting the schema API know about it in hook_schema_alter
-----
Adam A. Gregory
Drupal Developer & Consultant
Web: AdamAGregory.com
Twitter: twitter.com/adamgregory
Phone: 910.808.1717
Cell: 919.306.6138


On Mon, Jul 12, 2010 at 12:30 PM, Brian Vuyk <brian@brianvuyk.com> wrote:
I don't see any problem with it, although I would add / remove the columns with hook_install() / hook_uninstall() rather than hook_schema_alter().

Brian


On 10-07-12 12:19 PM, nan wich wrote:
Is there an official stance on using hook_schema_alter to add columns to core tables? For example, we collect additional data on anonymous comments and want to actually save that data. Rather than creating another table (and subsequent JOINs), I'd just as soon stuff that data into the comments table, where it belongs. Should we ever disable comments (unlikely), we probably wouldn't mind losing that data too.
 

Nancy E. Wichmann, PMP

Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.