On Jan 4, 2008 5:46 PM, Derek Wright <drupal@dwwright.net> wrote:

On Jan 3, 2008, at 6:28 PM, Khalid Baheyeldin wrote:

> The reason I added the file element is that I got an error on
> another module
> (system.admin.inc ...) and that element made it go away.

For clarity:

system.admin.inc is not a "module".  It's an include file that should
be included by system.module when it's doing admin-related things.
system.module is a module.  The .module files for every enabled
module are always loaded when bootstrapping Drupal.  The performance
gain from splitting modules up into .inc files (made easier by the D6
menu changes) is that you don't have to load all the code that's only
rarely used in your .module files.

 I realize it is not a module. What I meant was that another module spat out an error message
about system.admin.inc, and when adding the 'file' element (wrongly) that error went away.

When I changed the other things Peter pointed out, all was well.

Peter's point is that you should never tell the menu system to
include a .module file again, since those are *always* loaded.  You
should only tell the menu system to include a .inc file, never
a .module file.

Yup.

Thanks for the extra explanations.

--
Khalid M. Baheyeldin
2bits.com, Inc.
http://2bits.com
Drupal optimization, development, customization and consulting.