Hi all. So, I'm working with a client who
had work done by well-meaning-but-short-on-Drupal-experience
coders, who achieved some things by hacking core, and I'm
identifying the hacks and finding alternative ways to achieve
the same results.
One (probably not the only, just the first)
has me puzzled. In the original drupal_execute, the form state
is set to must_validate (this, as far as I can tell from a
grep, is not checked for anywhere), and then form_error is
called in a way to reset the static form error state.
The hack comments out
the form state assignment and call to reset the form error
state. Why would someone would want to do that, given that
it's occurring after a form is first loaded? The only thing
that comes to mind is perhaps the same from is being loaded
as was just displayed, and they don't want the displayed
errors to be reset, but surely this would have consequences
when the forms ARE different.
Any thoughts?