I'm trying to submit a patch which changes a form in install.php. Because of that change the test bot always fails with "Failed to install HEAD". At least I'm guessing that's why, the error message really gives no explanation. Is there something I can include in the patch to make the test bot succeed? The patch is here: http://drupal.org/node/394282 Thanks, -Dave
Quoting Dave Cohen <drupal@dave-cohen.com>:
I'm trying to submit a patch which changes a form in install.php. Because of that change the test bot always fails with "Failed to install HEAD". At least I'm guessing that's why, the error message really gives no explanation.
Is there something I can include in the patch to make the test bot succeed?
The patch is here: http://drupal.org/node/394282
Try applying the patch to a clean HEAD checkout. This should tell you more about why the testbot has an issue. -- Earnie http://r-feed.com Make a Drupal difference and review core patches. -- http://for-my-kids.com/ -- http://www.4offer.biz/
I'm pretty sure the test framework install runs a custom script which depends on the HEAD installer forms. So changes will cause testing failures, and committing the patch will require the script to be updated to avoid test bot meltdown. I'd probably try to force your patch to Code Needs Review to get some manual testing - and see if you can co-ordinate with Jimmy/boombatower and webchick in irc on how best to deal with it. Nat On Tue, Mar 10, 2009 at 4:24 PM, Dave Cohen <drupal@dave-cohen.com> wrote:
I'm trying to submit a patch which changes a form in install.php. Because of that change the test bot always fails with "Failed to install HEAD". At least I'm guessing that's why, the error message really gives no explanation.
Is there something I can include in the patch to make the test bot succeed?
The patch is here: http://drupal.org/node/394282
Thanks,
-Dave
Please see http://drupal.org/node/371309 "Failed to install HEAD" message makes the bot seem like a failure The bot failure message doesn't explain _why_ it failed. We need to change the error message to help people out. This same message confused the hell out of me until someone told me it meant the _Drupal installer_ was broke after the patch was applied. - John On Mar 11, 2009, at 8:56 AM, Nathaniel Catchpole wrote:
I'm pretty sure the test framework install runs a custom script which depends on the HEAD installer forms. So changes will cause testing failures, and committing the patch will require the script to be updated to avoid test bot meltdown. I'd probably try to force your patch to Code Needs Review to get some manual testing - and see if you can co-ordinate with Jimmy/boombatower and webchick in irc on how best to deal with it.
Nat
On Tue, Mar 10, 2009 at 4:24 PM, Dave Cohen <drupal@dave-cohen.com> wrote: I'm trying to submit a patch which changes a form in install.php. Because of that change the test bot always fails with "Failed to install HEAD". At least I'm guessing that's why, the error message really gives no explanation.
Is there something I can include in the patch to make the test bot succeed?
The patch is here: http://drupal.org/node/394282
Thanks,
-Dave
Thanks John, I did see your issue already. I think in my case Nat's comment is correct. My patch changes the installer form and there's no way to submit a patch which does this and which the test bot accepts. -Dave On Wednesday 11 March 2009 09:43:06 John Wilkins wrote:
Please see http://drupal.org/node/371309 "Failed to install HEAD" message makes the bot seem like a failure
...
- John
On Mar 11, 2009, at 8:56 AM, Nathaniel Catchpole wrote:
I'm pretty sure the test framework install runs a custom script which depends on the HEAD installer forms. So changes will cause testing failures, and committing the patch will require the script to be updated to avoid test bot meltdown. I'd probably try to force your patch to Code Needs Review to get some manual testing - and see if you can co-ordinate with Jimmy/boombatower and webchick in irc on how best to deal with it.
Nat
participants (4)
-
Dave Cohen -
Earnie Boyd -
John Wilkins -
Nathaniel Catchpole