Issue status update for http://drupal.org/node/23506 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: Dries Status: patch We forgot to commit the throbber image. Can't we cool up the throbber a bit? (Make it a rotating Druplicon or something. ;)) Dries Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 11:05 : Thox Attachment: http://drupal.org/files/issues/autocomplete.js.patch (1.14 KB) When using an autocomplete field, the throbber icon does not dissapear after HTTP errors (e.g. 404 if the autocomplete url is not found). Attached patch fixes this and also makes it work in one of my modules where the same autocomplete javascript object (ACDB) is shared by many controls (they're all recipe ingredient fields, so they share the same cache). ------------------------------------------------------------------------ May 24, 2005 - 11:23 : Thox Attachment: http://drupal.org/files/issues/autocomplete.js_0.patch (1.59 KB) Changed the name of the issue because it's not just HTTP errors that make the throbber start/stop at the right time. When typing something in the autocomplete box, there's a 300ms delay before the HTTP request is made. The throbber should start when the HTTP request is made and end when the HTTP request finishes.

Issue status update for http://drupal.org/node/23506 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: Steven Status: patch I didn't commit the throbber because I wasn't sure it should go into core. In any case, it was just a 5 minute try out to show off the idea. Steven Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 11:05 : Thox Attachment: http://drupal.org/files/issues/autocomplete.js.patch (1.14 KB) When using an autocomplete field, the throbber icon does not dissapear after HTTP errors (e.g. 404 if the autocomplete url is not found). Attached patch fixes this and also makes it work in one of my modules where the same autocomplete javascript object (ACDB) is shared by many controls (they're all recipe ingredient fields, so they share the same cache). ------------------------------------------------------------------------ May 24, 2005 - 11:23 : Thox Attachment: http://drupal.org/files/issues/autocomplete.js_0.patch (1.59 KB) Changed the name of the issue because it's not just HTTP errors that make the throbber start/stop at the right time. When typing something in the autocomplete box, there's a 300ms delay before the HTTP request is made. The throbber should start when the HTTP request is made and end when the HTTP request finishes. ------------------------------------------------------------------------ May 24, 2005 - 13:53 : Dries We forgot to commit the throbber image. Can't we cool up the throbber a bit? (Make it a rotating Druplicon or something. ;)) ------------------------------------------------------------------------ May 24, 2005 - 14:24 : adrian NO NO!. make it a throbbing druplicon =)

Issue status update for http://drupal.org/node/23506 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: Dries Status: patch I find the throbber handy -- it tells me up front how the textfield will work (I know what behavior to expect), and shows me when it is busy getting data. Last but not least, it is cool. It are cool but useful details like this which makes an application stand out. So I'm all for includding throbber. Steven: can you commit whatever is meant to be the final throbber image? It's not clear whether you have plans to refine it. Dries Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 11:05 : Thox Attachment: http://drupal.org/files/issues/autocomplete.js.patch (1.14 KB) When using an autocomplete field, the throbber icon does not dissapear after HTTP errors (e.g. 404 if the autocomplete url is not found). Attached patch fixes this and also makes it work in one of my modules where the same autocomplete javascript object (ACDB) is shared by many controls (they're all recipe ingredient fields, so they share the same cache). ------------------------------------------------------------------------ May 24, 2005 - 11:23 : Thox Attachment: http://drupal.org/files/issues/autocomplete.js_0.patch (1.59 KB) Changed the name of the issue because it's not just HTTP errors that make the throbber start/stop at the right time. When typing something in the autocomplete box, there's a 300ms delay before the HTTP request is made. The throbber should start when the HTTP request is made and end when the HTTP request finishes. ------------------------------------------------------------------------ May 24, 2005 - 13:53 : Dries We forgot to commit the throbber image. Can't we cool up the throbber a bit? (Make it a rotating Druplicon or something. ;)) ------------------------------------------------------------------------ May 24, 2005 - 14:24 : adrian NO NO!. make it a throbbing druplicon =) ------------------------------------------------------------------------ May 24, 2005 - 21:35 : Steven I didn't commit the throbber because I wasn't sure it should go into core. In any case, it was just a 5 minute try out to show off the idea. ------------------------------------------------------------------------ May 24, 2005 - 21:57 : Thox The throbber should go in, but I don't think it should be anything like druplicon as default. A throbbing / spinning / bouncing druplicon could go in the bluemarine theme, but I think the throbber.gif in /misc/ should be something plain. Having a throbber makes the control much more usable: http://formassembly.com/blog/ajax-not-all-about-xmlhttprequest/