[drupal-devel] Important node system changes
Hello world, I just committed a patch from chx (Karoly) that changes parts of the node system. If you maintain a module that implements a node type, you'll have to make some minimal changes for your module to work properly. We'll make sure to explain these changes at http://drupal.org/node/ 22218 ... until then, please consult my CVS commit message at http:// drupal.org/cvs?commit=18816. -- Dries Buytaert :: http://www.buytaert.net/
Dries Buytaert wrote:
Hello world,
I just committed a patch from chx (Karoly) that changes parts of the node system. If you maintain a module that implements a node type, you'll have to make some minimal changes for your module to work properly.
We'll make sure to explain these changes at http://drupal.org/node/ 22218 ... until then, please consult my CVS commit message at http:// drupal.org/cvs?commit=18816.
-- Dries Buytaert :: http://www.buytaert.net/
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
On 29/08/2005, at 12:32 PM, Moshe Weitzman wrote:
Dries Buytaert wrote:
Hello world, I just committed a patch from chx (Karoly) that changes parts of the node system. If you maintain a module that implements a node type, you'll have to make some minimal changes for your module to work properly. We'll make sure to explain these changes at http://drupal.org/ node/ 22218 ... until then, please consult my CVS commit message at http:// drupal.org/cvs?commit=18816. -- Dries Buytaert :: http://www.buytaert.net/
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
I have only just started following this issue, and I would have to agree with Moshe. For consistency, I think it would be best if hook_nodeapi were renamed to hook_node.
On 29 Aug 2005, at 04:32, Moshe Weitzman wrote:
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
Right. We can still rename the new _node hook. Suggestions for a better name? -- Dries Buytaert :: http://www.buytaert.net/
Dries Buytaert wrote:
On 29 Aug 2005, at 04:32, Moshe Weitzman wrote:
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
Right. We can still rename the new _node hook. Suggestions for a better name?
-- Dries Buytaert :: http://www.buytaert.net/
hook_node_info(), hook_node_about(), hook_node_name()
On 29-Aug-05, at 7:48 AM, Moshe Weitzman wrote:
Dries Buytaert wrote:
On 29 Aug 2005, at 04:32, Moshe Weitzman wrote:
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
Right. We can still rename the new _node hook. Suggestions for a better name? -- Dries Buytaert :: http://www.buytaert.net/
hook_node_info(), hook_node_about(), hook_node_name()
let me preface this by saying, i've not yet read the hook changes - but couldn't it all be rolled together as hook_node()?
On 29 Aug 2005, at 04:32, Moshe Weitzman wrote:
Hello world, I just committed a patch from chx (Karoly) that changes parts of the node system. If you maintain a module that implements a node type, you'll have to make some minimal changes for your module to work properly. We'll make sure to explain these changes at http://drupal.org/ node/ 22218 ... until then, please consult my CVS commit message at http:// drupal.org/cvs?commit=18816. -- Dries Buytaert :: http://www.buytaert.net/
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
The _node() hook has been renamed to _node_info(). Like that, we reserve _node() for _nodeapi(). -- Dries Buytaert :: http://www.buytaert.net/
Hello world, I just committed a patch from chx (Karoly) that changes parts of the node system. If you maintain a module that implements a node type, you'll have to make some minimal changes for your module to work properly. We'll make sure to explain these changes at http://drupal.org/ node/ 22218 ... until then, please consult my CVS commit message at http:// drupal.org/cvs?commit=18816. -- Dries Buytaert :: http://www.buytaert.net/
Some of us were hoping to switch the name of hook_nodeapi to hook_node in order to balance better with hook_user, hook_comment, hook_taxonomy, and the upcoming hook_file (). I was offline all weekend, or else i would have spoken sooner.
Renamed it to _node_info() ... -- Dries Buytaert :: http://www.buytaert.net/
participants (5)
-
Dries Buytaert -
Dries Buytaert -
James Walker -
Moshe Weitzman -
Nathan Wheatley