Project: Drupal Version: cvs Component: filter.module Category: feature requests Priority: normal Assigned to: walkah Reported by: walkah Updated by: Steven Status: patch Google dictates and the people follow ;). Personally I don't think implementing it will stop comment spam much as there will always be blogs and guestbooks that will not have this feature. Experience has shown that making a medium less effective for spam simply causes spammers to spam harder. It's only when the medium becomes 100% ineffective, that they stop. Still, it's a tiny patch and a popular thing to have. Notes: - The default value for the variable is 0 in one place, FALSE in the other. While it won't alter functionality, it's still iffy. - Bad code style ;) (space in front of parameter) - The title for the option could be clearer. Something like "Link spamming discouragement" ? The option's description already tells you about the rel="nofollow" attribute and what it is for. Steven Previous comments: ------------------------------------------------------------------------ January 19, 2005 - 17:01 : walkah Attachment: http://drupal.org/files/issues/filter-no-follow.patch (1.74 KB) google just announced a new attribute rel="nofollow" in an attempt to combat comment spam. the attached patch adds the option to add rel="nofollow" as part of HTML Filter for more info check: http://www.google.com/googleblog/2005/01/preventing-comment-spam.html -- View: http://drupal.org/node/15847 Edit: http://drupal.org/project/comments/add/15847

Project: Drupal Version: cvs Component: filter.module Category: feature requests Priority: normal Assigned to: walkah Reported by: walkah Updated by: walkah Status: patch Attachment: http://drupal.org/files/issues/filter-nofollow2.patch (2.27 KB) OK, while Dries committed the first patch, he also asked for a bit more info in the explanation. Here's another patch that should address all the nitpicks ;) walkah Previous comments: ------------------------------------------------------------------------ January 19, 2005 - 11:01 : walkah Attachment: http://drupal.org/files/issues/filter-no-follow.patch (1.74 KB) google just announced a new attribute rel="nofollow" in an attempt to combat comment spam. the attached patch adds the option to add rel="nofollow" as part of HTML Filter for more info check: http://www.google.com/googleblog/2005/01/preventing-comment-spam.html ------------------------------------------------------------------------ January 19, 2005 - 11:35 : Steven Google dictates and the people follow ;). Personally I don't think implementing it will stop comment spam much as there will always be blogs and guestbooks that will not have this feature. Experience has shown that making a medium less effective for spam simply causes spammers to spam harder. It's only when the medium becomes 100% ineffective, that they stop. Still, it's a tiny patch and a popular thing to have. Notes: - The default value for the variable is 0 in one place, FALSE in the other. While it won't alter functionality, it's still iffy. - Bad code style ;) (space in front of parameter) - The title for the option could be clearer. Something like "Link spamming discouragement" ? The option's description already tells you about the rel="nofollow" attribute and what it is for. -- View: http://drupal.org/node/15847 Edit: http://drupal.org/project/comments/add/15847

Project: Drupal Version: cvs Component: filter.module Category: feature requests Priority: normal Assigned to: walkah Reported by: walkah Updated by: walkah Status: patch why? because most people (or lots anyway) won't want to install weblink or spam.module on their blog. And ... which one should be responsible for it? Besides, to make it work, it will need the high adoption rates - look at the list of tools supporting it already in their "core". Having it in a contrib module doesn't make it any less flexible. Besides, it's a tiny patch and Dries' already committed it ;) walkah Previous comments: ------------------------------------------------------------------------ January 19, 2005 - 11:01 : walkah Attachment: http://drupal.org/files/issues/filter-no-follow.patch (1.74 KB) google just announced a new attribute rel="nofollow" in an attempt to combat comment spam. the attached patch adds the option to add rel="nofollow" as part of HTML Filter for more info check: http://www.google.com/googleblog/2005/01/preventing-comment-spam.html ------------------------------------------------------------------------ January 19, 2005 - 11:35 : Steven Google dictates and the people follow ;). Personally I don't think implementing it will stop comment spam much as there will always be blogs and guestbooks that will not have this feature. Experience has shown that making a medium less effective for spam simply causes spammers to spam harder. It's only when the medium becomes 100% ineffective, that they stop. Still, it's a tiny patch and a popular thing to have. Notes: - The default value for the variable is 0 in one place, FALSE in the other. While it won't alter functionality, it's still iffy. - Bad code style ;) (space in front of parameter) - The title for the option could be clearer. Something like "Link spamming discouragement" ? The option's description already tells you about the rel="nofollow" attribute and what it is for. ------------------------------------------------------------------------ January 19, 2005 - 11:50 : walkah Attachment: http://drupal.org/files/issues/filter-nofollow2.patch (2.27 KB) OK, while Dries committed the first patch, he also asked for a bit more info in the explanation. Here's another patch that should address all the nitpicks ;) ------------------------------------------------------------------------ January 19, 2005 - 11:52 : Anonymous IMO this should not be part of core. Why not add this to either the weblink module, or spam.module? Bèr -- View: http://drupal.org/node/15847 Edit: http://drupal.org/project/comments/add/15847