Issue status update for http://drupal.org/node/23536 Post a follow up: http://drupal.org/project/comments/add/23536 Project: Drupal Version: cvs Component: user.module Category: feature requests Priority: normal Assigned to: chx Reported by: moshe weitzman Updated by: moshe weitzman -Status: patch (code needs review) +Status: patch (ready to be committed) I applied the patch and registered as regular user and as admin. works as advertised. code looks good, and consolidates the registration forms so we don't have special admin only form. +1 moshe weitzman Previous comments: ------------------------------------------------------------------------ Tue, 24 May 2005 19:02:40 +0000 : moshe weitzman When creating a new user as an admin, it is useful and even expected to be able to complete all the profile fields which are available on the usual registration form ... the approach might be to consolidate registration so that both users and admins use a single form. ------------------------------------------------------------------------ Sat, 25 Jun 2005 22:27:41 +0000 : chx Attachment: http://drupal.org/files/issues/user_reg.patch (8.69 KB) At first I thought it'd be better if I'd keep the separate form, but this version results in shorter code and it's not so ugly. However, if you do not like it, I have the version which only adds the $extra to user_admin_create. ------------------------------------------------------------------------ Sun, 26 Jun 2005 18:08:48 +0000 : killes@www.drop.org I like this patch. ------------------------------------------------------------------------ Tue, 28 Jun 2005 01:53:01 +0000 : moshe weitzman to me, this version is great as it unifies the registration code. i did a code review and all looks good to me. i applied the patch and noticed that - i added a required checkbox field via profile.module. the check appeared on the reg form without the 'required' marker and the registration was accepted without checking the box. then i tried this for a textfield and it properly showed the 'required' marker but it didn't enforce the 'required' bit either. so then i tried to edit the user and even then we seem not to be enforcing the 'required' bit. this looks like a profile.module bug. if you are up for it, you might want to investigate the above. but truly, enforcing the required bit is not related to this patch. so +1 from me. ------------------------------------------------------------------------ Fri, 01 Jul 2005 06:00:21 +0000 : chx Attachment: http://drupal.org/files/issues/user_reg_0.patch (9.01 KB) It was intentional that the check for required fields are skipped for admins. I deleted that check. ------------------------------------------------------------------------ Wed, 06 Jul 2005 06:28:35 +0000 : Torenware Attachment: http://drupal.org/files/issues/user_reg_4.6.2.patch (8.33 KB) This patch is massively useful (at least for me...) and was exactly what I was looking for. Since I can't use the CVS version, I back-ported it to 4.6.2. It's syntactically valid, and it seems to work, although I have not tested it thoroughly. I'm uploading it in case anyone else wants to try it out, or is willing to test it. I'll be using it in any case. YMMV, of course :-) Rob Thorne Torenware Networks ------------------------------------------------------------------------ Mon, 18 Jul 2005 20:07:18 +0000 : chx Attachment: http://drupal.org/files/issues/user_reg_1.patch (8 KB) after discussions with Dries and Moshe I put the requirement uncheck and removed my description trickery.