[drupal-devel] CVS contribution etiquette
I contribute small patches to Drupal core occasionally and to third party modules more frequently. I have CVS access to the Drupal contributions, however, I tend to contribute via uploaded patch files and I'm wondering if I should be using CVS instead. But I'm hesitant to make changes to someone else's module. So what are the rules and etiquette for contributing via CVS? Should I just stick to uploading patch files? -- Dondley Communications http://www.dondleycommunications.com Communicate or Die: American Labor Unions and the Internet http://www.communicateordie.com
On Tue, 27 Sep 2005, Steve Dondley wrote:
I contribute small patches to Drupal core occasionally and to third party modules more frequently. I have CVS access to the Drupal contributions, however, I tend to contribute via uploaded patch files and I'm wondering if I should be using CVS instead. But I'm hesitant to make changes to someone else's module.
So what are the rules and etiquette for contributing via CVS? Should I just stick to uploading patch files?
Yes, unless you obtained permisssion from the maintainer to apply patches. Even if you do apply the patches yourself, it makes sense to create an issue first in case more people work on one module. Cheers, Gerhard
It is fine to contribute patches to other modules. These are in effect suggestions to the author/maintainer on specific features, fixes, ...etc. The patches have to be attached to an issue that you open for that project. Others may find your patch useful, even if the maintainer does not want to commit it, or is too busy to look at it, or whatever .. Communicating with the maintainer ahead of time is always a good idea. In some cases, the maintainer may even allow you to commit your own changes. It is on a case by case basis. On 9/27/05, Steve Dondley <sdondley@gmail.com> wrote:
I contribute small patches to Drupal core occasionally and to third party modules more frequently. I have CVS access to the Drupal contributions, however, I tend to contribute via uploaded patch files and I'm wondering if I should be using CVS instead. But I'm hesitant to make changes to someone else's module.
So what are the rules and etiquette for contributing via CVS? Should I just stick to uploading patch files?
participants (3)
-
Gerhard Killesreiter -
Khalid B -
Steve Dondley