Jeff Eaton wrote:
At absolute worst... Does anyone have feelings about replacing some of the old-and-crusty additional themes that we include with Drupal? Even if folks are absolutely desperately attached to bluemarine, how many folks are there out there who say, "You'll take away Grey Box when you pry it from my cold, dead, hands?"
I like that idea, actually. I use Grey Box all over the place. But all of those sites are on older releases (e.g. 4.4, 4.5). When I upgrade them to 4.7 or 4.8, I fully expect and want to upgrade the theme,too. So if Box Grey were not available, that would be fine with me. Go ahead and blow a few of the old themes out the airlock! :-)
On Wednesday 30 August 2006 21:01, Chris Johnson wrote:
I like that idea, actually. I use Grey Box all over the place. But all of those sites are on older releases (e.g. 4.4, 4.5). When I upgrade them to 4.7 or 4.8, I fully expect and want to upgrade the theme,too. So if Box Grey were not available, that would be fine with me.
Go ahead and blow a few of the old themes out the airlock! :-)
As long as we still have a good basic, thin theme to use as a base for new themes. Most of my 4.7-targeted themes have started as box gray and then evolved into what I wanted them to be. We need to be sure we have some nice "minimal" theme to build off of. (That could be a thin Zen, if we go that route; as long as there is one, I'm happy.) -- Larry Garfield AIM: LOLG42 larry@garfieldtech.com ICQ: 6817012 "If nature has made any one thing less susceptible than all others of exclusive property, it is the action of the thinking power called an idea, which an individual may exclusively possess as long as he keeps it to himself; but the moment it is divulged, it forces itself into the possession of every one, and the receiver cannot dispossess himself of it." -- Thomas Jefferson
Hi all, Moshe and I have been working on a patch that will make it easy to swap out session handling code and replace it with something else (like memcached, LDAP, 3rd party whatever....) The patch seems to be ready: http://drupal.org/node/77936 It doesn't change very much logic (almost none) in session handling, but rather moves code out of user.module and throttle.module and puts it into sessions.inc. If you have a spare pair of eyeballs today, give it a look-see while it is still possible to get it in for 4.8/5.0 cheers, Robert
Thanks to the people who responded and reviewed the patch. It has changed a bit since the first time. I'll summarize: - there was a flaw in the logic behind the query in user.module that counted the online authenticated users (didn't account for users who logged off explicitely) - user_logout was calling session_destroy (the php function) instead of sess_destroy (our override of that function). Changing this removed the necessity of handling a second parameter to sess_destroy: it now only accepts $uid as a parameter. - drupal_count_sessions has been renamed to sess_count for consistency. A second review would be appreciated. Robert Douglass wrote:
Hi all,
Moshe and I have been working on a patch that will make it easy to swap out session handling code and replace it with something else (like memcached, LDAP, 3rd party whatever....) The patch seems to be ready:
It doesn't change very much logic (almost none) in session handling, but rather moves code out of user.module and throttle.module and puts it into sessions.inc.
If you have a spare pair of eyeballs today, give it a look-see while it is still possible to get it in for 4.8/5.0
cheers,
Robert
participants (3)
-
Chris Johnson -
Larry Garfield -
Robert Douglass