Adding db_rewrite_sql to comment.module
Shameless patch-whoring alert! I've been working on a number of projects lately that involve fine- tuning access, and since I got to experience Andy Kirkham's lesson on hook_db_rewrite_sql, I've been loving the power of this system to handle node access. However, in contrast to what the hook documentation says ("For comments, it is cid"), comment.module doesn't contain the critical call to db_rewrite_sql in comment_render(). This patch fixes that: http://drupal.org/node/128165 I've tested this pretty extensively on 5.1, and re-rolled without errors for 6-dev. My primary application for this is an ad-hoc private comment system called whisper.module which I'll be releasing in the next month. cheers -johs Josh Koenig, Partner josh@chapterthreellc.com AIM: chap3josh 1-888-822-4273
Come to think of it, same case applies here. They're pretty trivial changes that shouldn't affect anything else. Let's get this in as well, shall we? http://drupal.org/node/114938 On 5/27/07, Josh Koenig <josh@chapterthreellc.com> wrote:
Shameless patch-whoring alert!
I've been working on a number of projects lately that involve fine- tuning access, and since I got to experience Andy Kirkham's lesson on hook_db_rewrite_sql, I've been loving the power of this system to handle node access.
However, in contrast to what the hook documentation says ("For comments, it is cid"), comment.module doesn't contain the critical call to db_rewrite_sql in comment_render(). This patch fixes that:
I've tested this pretty extensively on 5.1, and re-rolled without errors for 6-dev. My primary application for this is an ad-hoc private comment system called whisper.module which I'll be releasing in the next month.
cheers -johs
Josh Koenig, Partner josh@chapterthreellc.com AIM: chap3josh 1-888-822-4273
participants (2)
-
Ashraf Amayreh -
Josh Koenig