Re: [drupal-devel] forum.module dependent on comment.module
On Fri, 4 Mar 2005 14:18:21 -0500, Chris Cook <beerfan@gmail.com> wrote:
On Fri, 04 Mar 2005 09:38:12 -0500, Moshe Weitzman <weitzman@tejasa.com> wrote:
I don't see any value in a forum that disallows comments.
I think a better long term goal, for forum.module, is to eliminate dependance on comments altogether. When trying to integrate mailhandler and listhandler so that listserve messages are added as forum nodes it feels very strange and inappropriate to add some messages as nodes and others as comments. When I was working on this it seemed like there was more of a reason it should not be done but I don't remember now.
Hmm. Well, this is a bit like we discussed at DrupalCon about how forum is nothing more than threaded display of nodes. But, to be clear, having nodes as topic replies is very, very different from what we have now. In fact, we would have to implement threading output just for this, and also store next/prev links, much like book. Actually...it's identical to book hierarchy, except for a different display... But that's very much a hand-waving, Forum Next Generation type discussion. For now, forum responses are comments, so forum requires comments module. I *have* run sites with comments off everywhere but in forums. -- Boris Mann http://www.bryght.com
To sum up. Forum in other systems is a forum in itself and that's done. Because of this, there are admins who are enabling forum but not comments and this results in strange bugs. Easiest solution: in forum_help() in the case 'admin/help#description' a check should occur which displays an error message in the bad case. It would be rather irritating to enable module, go to forum admin, see an error message, back to admin/modules -- brrr! Yes, in admin node configure you have the _possibility_ to disable commenting on pages, stories, flexinodes whatever your site is made of but allowing it in forum. Whether admins are aware of this or not is quite another question. There is a catch here, which also requires patching, I guess: you must not be able to disable comments for forum node type. Regards NK
Boris Mann wrote:
On Fri, 4 Mar 2005 14:18:21 -0500, Chris Cook <beerfan@gmail.com> wrote:
On Fri, 04 Mar 2005 09:38:12 -0500, Moshe Weitzman <weitzman@tejasa.com> wrote:
I don't see any value in a forum that disallows comments.
I think a better long term goal, for forum.module, is to eliminate dependance on comments altogether. When trying to integrate mailhandler and listhandler so that listserve messages are added as forum nodes it feels very strange and inappropriate to add some messages as nodes and others as comments. When I was working on this it seemed like there was more of a reason it should not be done but I don't remember now.
Hmm. Well, this is a bit like we discussed at DrupalCon about how forum is nothing more than threaded display of nodes. But, to be clear, having nodes as topic replies is very, very different from what we have now. In fact, we would have to implement threading output just for this, and also store next/prev links, much like book. Actually...it's identical to book hierarchy, except for a different display...
There has been discussion about implementing comments as nodes. What would the difficulties be with such a scenario? If comments were nodes, then it would be trivial to specify additional node types that could be used as comments (files and images, anyone?). I think if relativity module were simplified and a lot of the more advanced features were moved into separate module, just leaving the relationship management part, this would be quite feasible. I'm curious to see what others think about such a scenario. -Mark
Op zaterdag 5 maart 2005 02:33, schreef Mark:
There has been discussion about implementing comments as nodes. What would the difficulties be with such a scenario? If comments were nodes, then it would be trivial to specify additional node types that could be used as comments (files and images, anyone?). I think if relativity module were simplified and a lot of the more advanced features were moved into separate module, just leaving the relationship management part, this would be quite feasible.
+1 For comments as nodes. But do not underestimate it. Furthermore: relativity.module is not an API nor a framwork (yet?) So please do not use that. Simply make your own node->node as comment relation. Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
participants (4)
-
Boris Mann -
Bèr Kessels -
Mark -
Negyesi Karoly