Issue status update for http://drupal.org/node/27897 Post a follow up: http://drupal.org/project/comments/add/27897 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kubaZygmunt Updated by: Thomas Ilsche Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/user.module.authmap.path.txt (447 bytes) Even though the patch will probably behave correctly I would suggest the following alternative for clear style (always initialize variables). Thomas Ilsche Previous comments: ------------------------------------------------------------------------ Sun, 31 Jul 2005 13:44:26 +0000 : kubaZygmunt Attachment: http://drupal.org/files/issues/user.module.authmaps.patch.txt (461 bytes) During testing uploading file I've got exception message: Unexpected PHP error [Undefined variable: authmaps] severity [E_NOTICE] in [****\modules\user.module] line [201] My patch changes: if ($authmaps) => if (isset($authmaps)) I don't know if this condition is sufficient so please review (but for my testing error message disappeared ) thank you ------------------------------------------------------------------------ Sat, 06 Aug 2005 13:48:54 +0000 : killes@www.drop.org yes, this will fix the notice and won't have unwanted side effects. This review brought to you by Patch Bingo!