[drupal-devel] [feature] Book Menu Navigation needs Theming
Issue status update for http://drupal.org/node/28198 Post a follow up: http://drupal.org/project/comments/add/28198 Project: Drupal Version: 4.6.2 Component: book.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: merlinofchaos Updated by: merlinofchaos Status: patch (code needs review) Attachment: http://drupal.org/files/issues/book-theme-menu.patch (1.88 KB) In one of my Drupal sites I re-themed a minor issue in the menus, and discovered that the book navigation system just uses code that looks similar to the menu themes, but isn't actually themed. This very small patch adds a function theme_book_menu_item modeled closely on theme_menu_item from the menu system, and lets me theme this output as necessary; I believe it's incompatible with the other book menu patch floating around (and hopefully not necessary, but I haven't looked too closely at what that patch actually does). Hopefully I didn't break anything with it! merlinofchaos
Issue status update for http://drupal.org/node/28198 Post a follow up: http://drupal.org/project/comments/add/28198 Project: Drupal Version: 4.6.2 Component: book.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: merlinofchaos Updated by: merlinofchaos Status: patch (code needs review) Attachment: http://drupal.org/files/issues/book-theme-menu_0.patch (1.79 KB) Whoops. That patch had the wrong comment (silly cut & paste); though functionally nothing was wrong with it. This patch is updated with a marginally better comment for the new function. merlinofchaos Previous comments: ------------------------------------------------------------------------ Thu, 04 Aug 2005 17:38:06 +0000 : merlinofchaos Attachment: http://drupal.org/files/issues/book-theme-menu.patch (1.88 KB) In one of my Drupal sites I re-themed a minor issue in the menus, and discovered that the book navigation system just uses code that looks similar to the menu themes, but isn't actually themed. This very small patch adds a function theme_book_menu_item modeled closely on theme_menu_item from the menu system, and lets me theme this output as necessary; I believe it's incompatible with the other book menu patch floating around (and hopefully not necessary, but I haven't looked too closely at what that patch actually does). Hopefully I didn't break anything with it!
Issue status update for http://drupal.org/node/28198 Post a follow up: http://drupal.org/project/comments/add/28198 Project: Drupal Version: 4.6.2 Component: book.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: merlinofchaos Updated by: Uwe Hermann -Status: patch (code needs review) +Status: patch (code needs work) Patch doesn't apply anymore. Also, we don't use TABs in the code. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Thu, 04 Aug 2005 17:38:06 +0000 : merlinofchaos Attachment: http://drupal.org/files/issues/book-theme-menu.patch (1.88 KB) In one of my Drupal sites I re-themed a minor issue in the menus, and discovered that the book navigation system just uses code that looks similar to the menu themes, but isn't actually themed. This very small patch adds a function theme_book_menu_item modeled closely on theme_menu_item from the menu system, and lets me theme this output as necessary; I believe it's incompatible with the other book menu patch floating around (and hopefully not necessary, but I haven't looked too closely at what that patch actually does). Hopefully I didn't break anything with it! ------------------------------------------------------------------------ Thu, 04 Aug 2005 17:40:15 +0000 : merlinofchaos Attachment: http://drupal.org/files/issues/book-theme-menu_0.patch (1.79 KB) Whoops. That patch had the wrong comment (silly cut & paste); though functionally nothing was wrong with it. This patch is updated with a marginally better comment for the new function.
participants (2)
-
merlinofchaos -
Uwe Hermann