Issue status update for http://drupal.org/node/23387 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch You're right, some calls are using <div class="container-inline"> to do this. I'll find these instances and correct them, and then attach a new patch for this. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 22, 2005 - 18:17 : Robin Monks Attachment: http://drupal.org/files/issues/empty div form item fix.patch (682 bytes) This patch uses a blank div to allow block level ellements (like input> to go inside the form element per xhtml 1.0 specs. This patch works and validates, and is required for validation. Robin ------------------------------------------------------------------------ May 23, 2005 - 20:30 : Dries Yes/no? Please advise. If this patch is required, we might want to revise the call sites of form(). I believe some are adding divs to solve exactly this.

Issue status update for http://drupal.org/node/23387 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: stefan nagtegaal Status: patch Could you please remove the spaces from your patch name? they break the link in e-mail clients quite often.. I would prefer not to use spaces at all inside patch filenames at all, I would encourage you to use something like 'patch_name.patch'.. Stefan stefan nagtegaal Previous comments: ------------------------------------------------------------------------ May 22, 2005 - 20:17 : Robin Monks Attachment: http://drupal.org/files/issues/empty div form item fix.patch (682 bytes) This patch uses a blank div to allow block level ellements (like input> to go inside the form element per xhtml 1.0 specs. This patch works and validates, and is required for validation. Robin ------------------------------------------------------------------------ May 23, 2005 - 22:30 : Dries Yes/no? Please advise. If this patch is required, we might want to revise the call sites of form(). I believe some are adding divs to solve exactly this. ------------------------------------------------------------------------ May 23, 2005 - 22:43 : Robin Monks You're right, some calls are using <div class="container-inline"> to do this. I'll find these instances and correct them, and then attach a new patch for this. Robin ------------------------------------------------------------------------ May 24, 2005 - 14:55 : Robin Monks Attachment: http://drupal.org/files/issues/empty div form item fix_0.patch (5.06 KB) Here is the new patch, which also removes unneeded (AFAIK) <div>'s from form's. Robin

Issue status update for http://drupal.org/node/23387 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Dries Status: patch You can't remove container-inlines; these ensure that the form elements are displayed as display: inline. Removing container-inlines breaks those forms! Dries Previous comments: ------------------------------------------------------------------------ May 22, 2005 - 20:17 : Robin Monks Attachment: http://drupal.org/files/issues/empty div form item fix.patch (682 bytes) This patch uses a blank div to allow block level ellements (like input> to go inside the form element per xhtml 1.0 specs. This patch works and validates, and is required for validation. Robin ------------------------------------------------------------------------ May 23, 2005 - 22:30 : Dries Yes/no? Please advise. If this patch is required, we might want to revise the call sites of form(). I believe some are adding divs to solve exactly this. ------------------------------------------------------------------------ May 23, 2005 - 22:43 : Robin Monks You're right, some calls are using <div class="container-inline"> to do this. I'll find these instances and correct them, and then attach a new patch for this. Robin ------------------------------------------------------------------------ May 24, 2005 - 14:55 : Robin Monks Attachment: http://drupal.org/files/issues/empty div form item fix_0.patch (5.06 KB) Here is the new patch, which also removes unneeded (AFAIK) <div>'s from form's. Robin ------------------------------------------------------------------------ May 24, 2005 - 14:59 : stefan nagtegaal Could you please remove the spaces from your patch name? they break the link in e-mail clients quite often.. I would prefer not to use spaces at all inside patch filenames at all, I would encourage you to use something like 'patch_name.patch'.. Stefan ------------------------------------------------------------------------ May 24, 2005 - 15:03 : Robin Monks Attachment: http://drupal.org/files/issues/empty__div_form__item_fix.patch (5.06 KB) Oh bother... Robin