+1 from me. PHPTemplate need to move to core. By the way, Pushbutton already has a port for phptemplate here http://drupal.org/node/15059 I used it with 4.6 and it seems to work fine. Regarding removing xtemplate engine, why not leave it in core? At least for 4.7, then remove it in 4.8 so people have a transition period. --- Date: Sun, 1 May 2005 17:49:07 +0200 From: Dries Buytaert <dries@buytaert.net> Subject: [drupal-devel] phptemplate in core? To: drupal-devel@drupal.org Adrian et al, here is what I'd like to see happen: get PHPTemplate in core. We'd need to: 1. remove Xtemplate from core. 2. remove the Bluemarine theme from core (Xtemplate based). 3. remove the Pushbutton theme from core (Xtemplate based). 4. add PHPTemplate to core. 5. add a PHPTemplate-based theme to core. Steps 1, 2 and 3 are easy. Steps 4 and 5 need to be discussed. - What needs to be done to get PHPTemplate in core? From what I can tell, PHPTemplate's engine-specific settings (eg. the primary and secondary links) need some work. - What PHPTemplate-based theme should we ship with core? Should we port either Bluemarine or Pushbutton to PHPTemplate or should we go with fresh themes? My requirements for such theme would be: 1. The theme must validate as XHTML. 2. The theme's CSS classes/IDs must comply Drupal's naming conventions. 3. The theme should work on all browsers without hacks. 4. The theme should be simple and easy to customize. No themes with a bazillion of small images that no one will ever change. -- Dries Buytaert :: http://www.buytaert.net/
On 01 May 2005, at 18:29, K B wrote:
Regarding removing xtemplate engine, why not leave it in core? At least for 4.7, then remove it in 4.8 so people have a transition period.
The problem with the Xtemplate engine is that its code is dated. If you use Xtemplate in combination with PHP5, it is generating lots of warnings which we are currently suppressing in a rather hack-ish way. To fix this properly, we would have to rewrite large parts of Xtemplate. I don't think we need to drag Xtemplate along in Drupal 4.7: - We can announce in advance that Drupal 4.7 will no longer support Xtemplate. - We will maintain Xtemplate in the contributions repository so it will remain available. -- Dries Buytaert :: http://www.buytaert.net/
Good approach and reasoning. Regarding Pushbutton, it is one of the widely used themes out there. Since there is a phptemplate version exists, we'd better include it in core. On 5/1/05, Dries Buytaert <dries@buytaert.net> wrote:
On 01 May 2005, at 18:29, K B wrote:
Regarding removing xtemplate engine, why not leave it in core? At least for 4.7, then remove it in 4.8 so people have a transition period.
The problem with the Xtemplate engine is that its code is dated. If you use Xtemplate in combination with PHP5, it is generating lots of warnings which we are currently suppressing in a rather hack-ish way. To fix this properly, we would have to rewrite large parts of Xtemplate.
I don't think we need to drag Xtemplate along in Drupal 4.7: - We can announce in advance that Drupal 4.7 will no longer support Xtemplate. - We will maintain Xtemplate in the contributions repository so it will remain available.
-- Dries Buytaert :: http://www.buytaert.net/
Regarding removing xtemplate engine, why not leave it in core? At least for 4.7, then remove it in 4.8 so people have a transition period.
The problem with the Xtemplate engine is that its code is dated. If you use Xtemplate in combination with PHP5, it is generating lots of warnings which we are currently suppressing in a rather hack-ish way. To fix this properly, we would have to rewrite large parts of Xtemplate.
I don't think we need to drag Xtemplate along in Drupal 4.7: - We can announce in advance that Drupal 4.7 will no longer support Xtemplate. - We will maintain Xtemplate in the contributions repository so it will remain available.
+1. There is no need to keep xtemplate in 4.7. Goba
On Sun, 1 May 2005, Dries Buytaert wrote:
- We will maintain Xtemplate in the contributions repository so it will remain available.
I am pretty sure that nobody will be bothered to maintain it. And I don't consider this to be a real problem. People should migrate their themes to phptemplate. Cheers, Gerhard
Op zondag 01 mei 2005 19:02, schreef Gerhard Killesreiter:
I am pretty sure that nobody will be bothered to maintain it. And I don't consider this to be a real problem. People should migrate their themes to phptemplate.
On top of that: if xtemplate is required by some people, then those people will maintain it. If not, then obviously it was not as good as PHPtemplate. :) Bèr -- | Bèr Kessels | webschuur.com | website development | | Turnhoutsebaan 34/3 | 2140 Antwerpen | België | | IM: ber@jabber.org.uk | MSN: berkessels@gmx.net | | pers: bler.webschuur.com | prof: www.webschuur.com | Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
On 5/1/05, Gerhard Killesreiter <killesreiter@physik.uni-freiburg.de> wrote:
On Sun, 1 May 2005, Dries Buytaert wrote:
- We will maintain Xtemplate in the contributions repository so it will remain available.
I am pretty sure that nobody will be bothered to maintain it. And I don't consider this to be a real problem. People should migrate their themes to phptemplate.
I would be more than happy to maintain it. I feel it's very important that we have options for this sort of thing... and xtemplate involves far less overhead than some of the other options available. (e.g. Smarty) Tom
participants (6)
-
Bèr Kessels -
Dries Buytaert -
Gabor Hojtsy -
Gerhard Killesreiter -
K B -
Tom Dobes