Issue status update for http://drupal.org/node/24563 Post a follow up: http://drupal.org/project/comments/add/24563 Project: Drupal Version: cvs Component: other Category: tasks Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: breyten -Status: patch (code needs review) +Status: patch (ready to be committed) But perhaps a small message could be added that the database server is usually localhost? I think that makes it clearer why the first line says databaseserver and the second localhost. breyten Previous comments: ------------------------------------------------------------------------ Wed, 08 Jun 2005 14:25:13 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/settings_clarify.patch (814 bytes) I was just following a complete newbie when he installed Drupal. I will skip the database-import part, it was hell :) But more important, IMO is that he could not really read the documentation in settings.php correctly. He assumed the part localhost/database in mysql://username:password@localhost/database referred to his database directory. Since he was working on localhost, and knew nothing of the concept of a SQL server, this is not too odd. So I chnaged this into mysql://username:password@databaseserver/databasename in the attached patch. The filled out example reamins the same, with localhost in the url (since 99% has localhost as sql server) Note: I purposely did not user database_name, sinxce that will be confused with the prefix documentation, which uses the _ in its examples. And I hate (or well... dislike) CamelCase. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:43:04 +0000 : Bèr Kessels Patch still applies. Its a minor patch, but with some usability improvment. Please review!

Issue status update for http://drupal.org/node/24563 Post a follow up: http://drupal.org/project/comments/add/24563 Project: Drupal Version: cvs Component: other Category: tasks Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch (ready to be committed) drumm, I do not understand you comment. Waht would need to be spread out over separate lines? Are you hindting at $database = 'drupal'; $database_suer = 'foo'; etc? Bèr Kessels Previous comments: ------------------------------------------------------------------------ Wed, 08 Jun 2005 14:25:13 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/settings_clarify.patch (814 bytes) I was just following a complete newbie when he installed Drupal. I will skip the database-import part, it was hell :) But more important, IMO is that he could not really read the documentation in settings.php correctly. He assumed the part localhost/database in mysql://username:password@localhost/database referred to his database directory. Since he was working on localhost, and knew nothing of the concept of a SQL server, this is not too odd. So I chnaged this into mysql://username:password@databaseserver/databasename in the attached patch. The filled out example reamins the same, with localhost in the url (since 99% has localhost as sql server) Note: I purposely did not user database_name, sinxce that will be confused with the prefix documentation, which uses the _ in its examples. And I hate (or well... dislike) CamelCase. ------------------------------------------------------------------------ Tue, 02 Aug 2005 18:43:04 +0000 : Bèr Kessels Patch still applies. Its a minor patch, but with some usability improvment. Please review! ------------------------------------------------------------------------ Tue, 02 Aug 2005 19:42:37 +0000 : breyten But perhaps a small message could be added that the database server is usually localhost? I think that makes it clearer why the first line says databaseserver and the second localhost. ------------------------------------------------------------------------ Tue, 02 Aug 2005 22:05:25 +0000 : drumm I think seprarting things out into different lines might be worth considering. This is good too.