Issue status update for http://drupal.org/node/29548 Post a follow up: http://drupal.org/project/comments/add/29548 Project: Drupal -Version: cvs +Version: 4.6.3 Component: user system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kumo Updated by: fago Status: patch (code needs review) Attachment: http://drupal.org/files/issues/php5.4.6.patch (4.88 KB) i've fixed this everywhere in core, where i found it and created a patch. as this affects 4.6 too, here is the patch for 4.6 fago Previous comments: ------------------------------------------------------------------------ Wed, 24 Aug 2005 15:51:57 +0000 : kumo Attachment: http://drupal.org/files/issues/user_pass_reset_checks.patch (1.73 KB) On the password reset page, if a user enters a non-existant username or e-mail address, the 'Further instructions have been sent to your e-mail address.' message is shown The attached patch fixes this issue. It also removes an extraneous message shown if no username or password is given or when the unrecognised username or e-mail address messages are shown. ------------------------------------------------------------------------ Thu, 25 Aug 2005 17:55:51 +0000 : fago +1 now it works. so, it doesn't display a message if the user enters nothing any more, but i think this is ok, because the login form works in the same way. however, usually patches are based in drupal's root dir. http://drupal.org/patch ------------------------------------------------------------------------ Fri, 26 Aug 2005 14:18:09 +0000 : fago i've noticed a similar problem in user_view() i think that's a php5 specific issue? in php5 is something like if ($account = user_load(array('uid' => $uid, 'status' => 1))) always true. perhaps we should fix user_load() instead?

Issue status update for http://drupal.org/node/29548 Post a follow up: http://drupal.org/project/comments/add/29548 Project: Drupal Version: 4.6.3 Component: user system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kumo Updated by: fago Status: patch (code needs review) Attachment: http://drupal.org/files/issues/php5.head_0.patch (6.78 KB) sry, i had attached the wrong patch for head. this is the right one. please review. fago Previous comments: ------------------------------------------------------------------------ Wed, 24 Aug 2005 15:51:57 +0000 : kumo Attachment: http://drupal.org/files/issues/user_pass_reset_checks.patch (1.73 KB) On the password reset page, if a user enters a non-existant username or e-mail address, the 'Further instructions have been sent to your e-mail address.' message is shown The attached patch fixes this issue. It also removes an extraneous message shown if no username or password is given or when the unrecognised username or e-mail address messages are shown. ------------------------------------------------------------------------ Thu, 25 Aug 2005 17:55:51 +0000 : fago +1 now it works. so, it doesn't display a message if the user enters nothing any more, but i think this is ok, because the login form works in the same way. however, usually patches are based in drupal's root dir. http://drupal.org/patch ------------------------------------------------------------------------ Fri, 26 Aug 2005 14:18:09 +0000 : fago i've noticed a similar problem in user_view() i think that's a php5 specific issue? in php5 is something like if ($account = user_load(array('uid' => $uid, 'status' => 1))) always true. perhaps we should fix user_load() instead? ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:15:14 +0000 : fago Attachment: http://drupal.org/files/issues/php5.4.6.patch (4.88 KB) i've fixed this everywhere in core, where i found it and created a patch. as this affects 4.6 too, here is the patch for 4.6 ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:15:51 +0000 : fago Attachment: http://drupal.org/files/issues/php5.head.patch (6.4 KB) and the patch for head

Issue status update for http://drupal.org/node/29548 Post a follow up: http://drupal.org/project/comments/add/29548 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kumo Updated by: fago -Status: patch (code needs work) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/php5.head_1.patch (7.16 KB) right, i fixed that and rerolled the patch for HEAD. fago Previous comments: ------------------------------------------------------------------------ Wed, 24 Aug 2005 15:51:57 +0000 : kumo Attachment: http://drupal.org/files/issues/user_pass_reset_checks.patch (1.73 KB) On the password reset page, if a user enters a non-existant username or e-mail address, the 'Further instructions have been sent to your e-mail address.' message is shown The attached patch fixes this issue. It also removes an extraneous message shown if no username or password is given or when the unrecognised username or e-mail address messages are shown. ------------------------------------------------------------------------ Thu, 25 Aug 2005 17:55:51 +0000 : fago +1 now it works. so, it doesn't display a message if the user enters nothing any more, but i think this is ok, because the login form works in the same way. however, usually patches are based in drupal's root dir. http://drupal.org/patch ------------------------------------------------------------------------ Fri, 26 Aug 2005 14:18:09 +0000 : fago i've noticed a similar problem in user_view() i think that's a php5 specific issue? in php5 is something like if ($account = user_load(array('uid' => $uid, 'status' => 1))) always true. perhaps we should fix user_load() instead? ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:15:14 +0000 : fago Attachment: http://drupal.org/files/issues/php5.4.6.patch (4.88 KB) i've fixed this everywhere in core, where i found it and created a patch. as this affects 4.6 too, here is the patch for 4.6 ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:15:51 +0000 : fago Attachment: http://drupal.org/files/issues/php5.head.patch (6.4 KB) and the patch for head ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:23:16 +0000 : fago Attachment: http://drupal.org/files/issues/php5.head_0.patch (6.78 KB) sry, i had attached the wrong patch for head. this is the right one. please review. ------------------------------------------------------------------------ Sun, 11 Sep 2005 22:45:17 +0000 : m3avrck I've changed the status to CVS since this patch affects CVS as well and should go in there first before 4.6.3. One problem, if I enter a valid email address, I'm getting the error 'Sorry the email address is not recognized'. Otherwise patch looks great! However, it is slightly out of date against HEAD so should be rerolled to be clean, thanks!

Issue status update for http://drupal.org/node/29548 Post a follow up: http://drupal.org/project/comments/add/29548 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kumo Updated by: m3avrck Status: patch (ready to be committed) Just tested here, patch applies cleanly and works as advertised. All outstanding bugs have been fixed, +1 let's get this in, very nice little usability fix :) m3avrck Previous comments: ------------------------------------------------------------------------ Wed, 24 Aug 2005 15:51:57 +0000 : kumo Attachment: http://drupal.org/files/issues/user_pass_reset_checks.patch (1.73 KB) On the password reset page, if a user enters a non-existant username or e-mail address, the 'Further instructions have been sent to your e-mail address.' message is shown The attached patch fixes this issue. It also removes an extraneous message shown if no username or password is given or when the unrecognised username or e-mail address messages are shown. ------------------------------------------------------------------------ Thu, 25 Aug 2005 17:55:51 +0000 : fago +1 now it works. so, it doesn't display a message if the user enters nothing any more, but i think this is ok, because the login form works in the same way. however, usually patches are based in drupal's root dir. http://drupal.org/patch ------------------------------------------------------------------------ Fri, 26 Aug 2005 14:18:09 +0000 : fago i've noticed a similar problem in user_view() i think that's a php5 specific issue? in php5 is something like if ($account = user_load(array('uid' => $uid, 'status' => 1))) always true. perhaps we should fix user_load() instead? ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:15:14 +0000 : fago Attachment: http://drupal.org/files/issues/php5.4.6.patch (4.88 KB) i've fixed this everywhere in core, where i found it and created a patch. as this affects 4.6 too, here is the patch for 4.6 ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:15:51 +0000 : fago Attachment: http://drupal.org/files/issues/php5.head.patch (6.4 KB) and the patch for head ------------------------------------------------------------------------ Tue, 30 Aug 2005 23:23:16 +0000 : fago Attachment: http://drupal.org/files/issues/php5.head_0.patch (6.78 KB) sry, i had attached the wrong patch for head. this is the right one. please review. ------------------------------------------------------------------------ Sun, 11 Sep 2005 22:45:17 +0000 : m3avrck I've changed the status to CVS since this patch affects CVS as well and should go in there first before 4.6.3. One problem, if I enter a valid email address, I'm getting the error 'Sorry the email address is not recognized'. Otherwise patch looks great! However, it is slightly out of date against HEAD so should be rerolled to be clean, thanks! ------------------------------------------------------------------------ Mon, 12 Sep 2005 15:49:08 +0000 : fago Attachment: http://drupal.org/files/issues/php5.head_1.patch (7.16 KB) right, i fixed that and rerolled the patch for HEAD. ------------------------------------------------------------------------ Tue, 13 Sep 2005 14:36:04 +0000 : Souvent22 +1. Worked well for me, and more useful to know your username was wrong rather than waiting on a email for nothing. :).