[drupal-devel] node aggregator image/file handling
Hi there, I have been working on node aggregator (now named naggregator, because of the 16 char limit in the type-col of node table ;) ). But i have some problems / concerns about images. As it stands now, we can receive two kinds of files: embedded images, and enclosed files (podcasts). I will not yet work on the latter. The first has my concern. Now, img tags will be simply re-posted in the aggregated item, thus "stealing" images from the originating host. I want to know what you people say about this behaviour. Should it the image: a) remain deeplinked, thus stealing it (Its up to the feed-provider to strip image tags if she does not want them deeplinked, after all) b) strip the image tags. thus maybe taking the feed out of its context. c) fopen() and copy the file into our own file-sytem, then rewriting the url of the image to the one we now server local. Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
On 21-Jun-05, at 1:24 AM, Bèr Kessels wrote:
Hi there,
I have been working on node aggregator (now named naggregator, because of the 16 char limit in the type-col of node table ;) ).
You should also at least look at the work done here: http://drupal.org/node/18498 It may or may not be the right approach, but it treats both feeds and feed items as nodes.
But i have some problems / concerns about images. As it stands now, we can receive two kinds of files: embedded images, and enclosed files (podcasts). I will not yet work on the latter. The first has my concern.
Now, img tags will be simply re-posted in the aggregated item, thus "stealing" images from the originating host. I want to know what you people say about this behaviour. Should it the image: a) remain deeplinked, thus stealing it (Its up to the feed-provider to strip image tags if she does not want them deeplinked, after all) b) strip the image tags. thus maybe taking the feed out of its context. c) fopen() and copy the file into our own file-sytem, then rewriting the url of the image to the one we now server local.
I can see legitimate uses for all three options. Richard made a patch that adds a tag filtering screen to the admin of the "regular" aggregator, precisely because the default behaviour is to strip <img> tags, which is not something that Drupal should decide, but users should decide. Some use cases: a) Flickr is fine with deeplinking b) copyright / usage restrictions may not be allowed c) I have a local (at home) installation of Gallery, and want my hosted Drupal account to host thumbnail images for better performance Please make this configurable. The same option should (probably) apply to enclosures as well. -- Boris Mann http://www.bmannconsulting.com
Thanks, I was aware of that huge thread, but I am not impressed with the outcomes. First of all the aggregator2 is not up to drupal standards, secondly I cannot reach any of the developers there, And thirdly, I simply have no confidence in a project and issue that is tracked in comments of a forumpost :) I tried to contact these guys/girls if anyone wanted to collaborate to get the node aggregator up and running again, or rewrite it completely, but no luck So, if anyone is reading this, please please get in touch with me, for this is becoming messy, a lot of time is wasted and even more code will get lost this way. Op dinsdag 21 juni 2005 15:20, schreef Boris Mann:
You should also at least look at the work done here: http://drupal.org/node/18498
Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
On 21-Jun-05, at 7:36 AM, Bèr Kessels wrote:
I was aware of that huge thread, but I am not impressed with the outcomes. First of all the aggregator2 is not up to drupal standards, secondly I cannot reach any of the developers there, And thirdly, I simply have no confidence in a project and issue that is tracked in comments of a forumpost :)
I tried to contact these guys/girls if anyone wanted to collaborate to get the node aggregator up and running again, or rewrite it completely, but no luck
So, if anyone is reading this, please please get in touch with me, for this is becoming messy, a lot of time is wasted and even more code will get lost this way.
Op dinsdag 21 juni 2005 15:20, schreef Boris Mann:
You should also at least look at the work done here: http://drupal.org/node/18498
The person has applied for a CVS account: http://drupal.org/node/ 18498#comment-44703 -- Boris Mann http://www.bmannconsulting.com
Op dinsdag 21 juni 2005 15:20, schreef Boris Mann:
I can see legitimate uses for all three options. Richard made a patch that adds a tag filtering screen to the admin of the "regular" aggregator, precisely because the default behaviour is to strip <img> tags, which is not something that Drupal should decide, but users should decide.
Some use cases: a) Flickr is fine with deeplinking b) copyright / usage restrictions may not be allowed c) I have a local (at home) installation of Gallery, and want my hosted Drupal account to host thumbnail images for better performance
Please make this configurable. The same option should (probably) apply to enclosures as well
Thank you, this helps me a lot. Here is my plan: * image tags can be filtered with filters, since we are dealing with nodes anyway ;) so that issue is solved for free. * grabbing of files and importnig them locally will become a small addon-module for naggregator. naggregatorfiles.module or so. that one will hook into naggregator and deal with importing of files. Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
participants (2)
-
Boris Mann -
Bèr Kessels