Folks, With the contact module is there any particular end-user requirement that is being fulfilled by having the contact tab turned on for yourself? Why would I want to contact myself? Thanks, Dan
Dan Robinson wrote:
With the contact module is there any particular end-user requirement that is being fulfilled by having the contact tab turned on for yourself? Why would I want to contact myself?
Its good to see that other people see on your own account. I could imagine an additional help message being added with instructions for disabling it. -- Neil Drumm http://delocalizedham.com/
this (and what Phani brought) up was pretty much what I figured. The other side of the coin is that less sophisticated users have looked at it and are just baffled and think it is indicative of poor design... We need to make modifications for a client and I'm wondering if we should consider a patch or just fork it. I prefer a patch but don't want to get involved if it is going to be controversial... Dan
Dan Robinson wrote:
With the contact module is there any particular end-user requirement that is being fulfilled by having the contact tab turned on for yourself? Why would I want to contact myself?
Its good to see that other people see on your own account. I could imagine an additional help message being added with instructions for disabling it.
On 25 May 2006, at 19:57, Dan Robinson wrote:
this (and what Phani brought) up was pretty much what I figured. The other side of the coin is that less sophisticated users have looked at it and are just baffled and think it is indicative of poor design... We need to make modifications for a client and I'm wondering if we should consider a patch or just fork it. I prefer a patch but don't want to get involved if it is going to be controversial...
* Modifying the code to remove the tab takes 10 minutes, at most. * Creating a patch for it takes 5 minutes, at most. Are we discussing whether a 5 minute effort is worth it? :-) -- Dries Buytaert :: http://www.buytaert.net/
On 5/26/06, Dries Buytaert <dries.buytaert@gmail.com> wrote:
On 25 May 2006, at 19:57, Dan Robinson wrote:
this (and what Phani brought) up was pretty much what I figured. The other side of the coin is that less sophisticated users have looked at it and are just baffled and think it is indicative of poor design... We need to make modifications for a client and I'm wondering if we should consider a patch or just fork it. I prefer a patch but don't want to get involved if it is going to be controversial...
* Modifying the code to remove the tab takes 10 minutes, at most. * Creating a patch for it takes 5 minutes, at most.
* getting that patch committed takes 1 minute to 100minutes depending on the controversy
Are we discussing whether a 5 minute effort is worth it? :-)
I think it's that last - previously unstated - step of getting it committed. Regards, Greg -- Greg Knaddison | Growing Venture Solutions Denver, CO | http://growingventuresolutions.com Technology Solutions for Communities, Individuals, and Small Businesses
On 26 May 2006, at 15:50, Greg Knaddison - GVS wrote:
On 25 May 2006, at 19:57, Dan Robinson wrote:
this (and what Phani brought) up was pretty much what I figured. The other side of the coin is that less sophisticated users have looked at it and are just baffled and think it is indicative of poor design... We need to make modifications for a client and I'm wondering if we should consider a patch or just fork it. I prefer a patch but don't want to get involved if it is going to be controversial...
* Modifying the code to remove the tab takes 10 minutes, at most. * Creating a patch for it takes 5 minutes, at most.
* getting that patch committed takes 1 minute to 100minutes depending on the controversy
I think it's that last - previously unstated - step of getting it committed.
Yes, it might take a bit of time to get a patch committed, but for such a small patch as this, it shouldn't be that bad. Plus, as soon it is in the patch queue, other people can help get it committed. The 'getting it committed' part is a distributed effort. -- Dries Buytaert :: http://www.buytaert.net/
Folks, Thanks for the feedback. We have made the 2 minute change to the code and I have asked our guy to submit a patch so we can get the process rolling. I got what I wanted out of this conversation which was (IMO): - General agreement that a patch might be in order Thanks for your input... Here's another real newbie question - how do i find the current patch queue for Contact? It is not separately listed in the project pages. Dan
On 25 May 2006, at 19:57, Dan Robinson wrote:
this (and what Phani brought) up was pretty much what I figured. The other side of the coin is that less sophisticated users have looked at it and are just baffled and think it is indicative of poor design... We need to make modifications for a client and I'm wondering if we should consider a patch or just fork it. I prefer a patch but don't want to get involved if it is going to be controversial...
* Modifying the code to remove the tab takes 10 minutes, at most. * Creating a patch for it takes 5 minutes, at most.
Are we discussing whether a 5 minute effort is worth it? :-)
-- Dries Buytaert :: http://www.buytaert.net/
On May 26, 2006, at 7:46 AM, Dan Robinson wrote:
Here's another real newbie question - how do i find the current patch queue for Contact? It is not separately listed in the project pages.
for now, the only way to do this is via the "advanced search" page. i.e.: http://drupal.org/project/issues/search/drupal on there, scroll through the "Components" field and select "contact.module". you can narrow the search by selecting values in the other fields, too. in the medium-near future, i hope to add a way to filter by component to the main issue query pages (i.e. directly from http://drupal.org/ project/issues/drupal). see http://drupal.org/node/65336 for info, comments, etc about that. feel free to generate a patch. ;) thanks, -derek (dww) p.s. it'd be nice to actually review some other people's patches to project for a change, instead of writing my own all the time (except nedjo of course, and der, fgm and leafish_paul... they all get credit for generating patches in the recent past, too). ;)
On 26 May 2006, at 16:46, Dan Robinson wrote:
Here's another real newbie question - how do i find the current patch queue for Contact? It is not separately listed in the project pages.
You can use the advanced issue search form: http://drupal.org/project/issues/search/drupal Here is a list with all the patches and bugs filed against the contact module: http://drupal.org/project/issues? projects=3060&components=contact.module&states=1,8,13,14 Hope that helps, -- Dries Buytaert :: http://www.buytaert.net/
that's the trick - thanks Dries and Derek - I looked through the advanced search but missed this previously..
On 26 May 2006, at 16:46, Dan Robinson wrote:
Here's another real newbie question - how do i find the current patch queue for Contact? It is not separately listed in the project pages.
You can use the advanced issue search form: http://drupal.org/project/issues/search/drupal
Here is a list with all the patches and bugs filed against the contact module: http://drupal.org/project/issues?projects=3060&components=contact.module&sta...
Hope that helps,
-- Dries Buytaert :: http://www.buytaert.net/
Maybe to check whether the contact module is wrking, I do that everytime on my messenger ( I add myself) and also send a mail to myself. On 5/25/06, Dan Robinson <dan@civicactions.com> wrote:
Folks,
With the contact module is there any particular end-user requirement that is being fulfilled by having the contact tab turned on for yourself? Why would I want to contact myself?
Thanks,
Dan
-- Phani Kumar Arava Grad Student 1560 Worthington Street Department Of Computer Science Columbus Ohio 43201 2015 Neil Avenue Ohio State University Columbus Ohio-43210 Contact: (614)-316-8198 URL : www.cse.ohio-state.edu/~arava/ mailto: arava.3@osu.edu,phani.arava@gmail.com, arava_phani@yahoo.com
participants (6)
-
Dan Robinson -
Derek Wright -
Dries Buytaert -
Greg Knaddison - GVS -
Neil Drumm -
Phani Kumar Arava