Re: [development] xhtml and embed tag: best way to compliance?
I just spent the last few hours fixing my "fix" for the "Click to activate..." thing with IE. It turns out that the "flashvars" parameter, and many others, don't survive the "rewrite" in the current fix. Here's the new code: var objects = document.getElementsByTagName( 'object' ); for ( var i = 0; i < objects.length; i++ ) { var obj = objects[ i ]; var clone = obj .cloneNode( true ); var parent = obj .parentNode; var sibling = obj .nextSibling; parent.removeChild( obj ); parent.insertBefore( clone, sibling ); clone.outerHTML = clone.outerHTML; } Not as "clean" as before but then again it's a fix for IE, so it's almost to be expected. Karl
Great Karl!!! I was just having problem with flowplayer (a flash flv player which get played movie path from a flashvar) I think that this new implementation will help! Great work! New video module with XHTML valid code to be released soon. Fabio Karl Rudd wrote:
I just spent the last few hours fixing my "fix" for the "Click to activate..." thing with IE.
It turns out that the "flashvars" parameter, and many others, don't survive the "rewrite" in the current fix.
Here's the new code:
var objects = document.getElementsByTagName( 'object' ); for ( var i = 0; i < objects.length; i++ ) { var obj = objects[ i ]; var clone = obj .cloneNode( true ); var parent = obj .parentNode; var sibling = obj .nextSibling; parent.removeChild( obj ); parent.insertBefore( clone, sibling ); clone.outerHTML = clone.outerHTML; }
Not as "clean" as before but then again it's a fix for IE, so it's almost to be expected.
Karl
Fabio Varesano wrote:
New video module with XHTML valid code to be released soon.
What will your module be called so I can look out for it :-) ... and what is there currently (XHTML or not). I remember looking once and found nought. sime
The module is called video. http://drupal.org/node/25274 The cvs version is still not XHTML valid. I'm working on it. Fabio sime wrote:
Fabio Varesano wrote:
New video module with XHTML valid code to be released soon.
What will your module be called so I can look out for it :-)
... and what is there currently (XHTML or not). I remember looking once and found nought.
sime
Ok! I just implemented this new solution. Everything works well, only Quicktime has still problems. IE find an error on this : clone.outerHTML = clone.outerHTML; Do you have ideas about this? You can get the my last video module XHTML at http://www.varesano.net/video-demo/ After the Quicktime fix I will post here and on drupal.org asking for help on testing the new code. I need help on try different browsers and plug-in versions on the new video module generated code. Fabio Karl Rudd wrote:
I just spent the last few hours fixing my "fix" for the "Click to activate..." thing with IE.
It turns out that the "flashvars" parameter, and many others, don't survive the "rewrite" in the current fix.
Here's the new code:
var objects = document.getElementsByTagName( 'object' ); for ( var i = 0; i < objects.length; i++ ) { var obj = objects[ i ]; var clone = obj .cloneNode( true ); var parent = obj .parentNode; var sibling = obj .nextSibling; parent.removeChild( obj ); parent.insertBefore( clone, sibling ); clone.outerHTML = clone.outerHTML; }
Not as "clean" as before but then again it's a fix for IE, so it's almost to be expected.
Karl
On Wednesday 14 June 2006 04:07 am, Fabio Varesano wrote:
I will post here and on drupal.org asking for help on testing the new code. I need help on try different browsers and plug-in versions on the new video module generated code.
http://www.varesano.net/video-demo/ I tried to post a comment on your site as an anonymous user, but I couldn't: "Validation error, please try again. If this error persists, please contact the site administrator." I had this problem with my site, too: anonymous users couldn't post comments during the 4.7 beta period, but it works now... Just letting you know about this. Here is the comment I was trying to post here: http://www.varesano.net/video-demo/?q=node/10 It's probably not a problem with your video module, but for the record, I have never been able to play an embedded youtube video with Konqueror. (up to KDE 3.4, never tried 3.5). I CAN play them on the youtube website, but if the video is embedded in any blog like here, I click the play button, then I see the message "Loading..." but nothing ever loads or play. Can other KDE users confirm this, or does this work better with KDE 3.5, or is it the flash version that is not adapted??? In any case, thanks to Fabio for his efforts creating a nice Drupal video module. Augustin. -- http://www.wechange.org/ Because we and the world need to change. http://www.reuniting.info/ Intimate Relationships, peace and harmony in the couple. http://www.gnosis-usa.com/ Revolutionary Psychology, White Tantrism, Dream Yoga... http://www.masquilier.org/ Condorcet, Approval alternative, better voting methods.
Yes... confirmed. I tried with Konqueror in KDE 3.5 and the youtube video is never loaded. Fabio Anguo wrote:
On Wednesday 14 June 2006 04:07 am, Fabio Varesano wrote:
I will post here and on drupal.org asking for help on testing the new code. I need help on try different browsers and plug-in versions on the new video module generated code.
http://www.varesano.net/video-demo/ I tried to post a comment on your site as an anonymous user, but I couldn't: "Validation error, please try again. If this error persists, please contact the site administrator." I had this problem with my site, too: anonymous users couldn't post comments during the 4.7 beta period, but it works now... Just letting you know about this.
Here is the comment I was trying to post here: http://www.varesano.net/video-demo/?q=node/10
It's probably not a problem with your video module, but for the record, I have never been able to play an embedded youtube video with Konqueror. (up to KDE 3.4, never tried 3.5). I CAN play them on the youtube website, but if the video is embedded in any blog like here, I click the play button, then I see the message "Loading..." but nothing ever loads or play.
Can other KDE users confirm this, or does this work better with KDE 3.5, or is it the flash version that is not adapted???
In any case, thanks to Fabio for his efforts creating a nice Drupal video module.
Augustin.
participants (4)
-
Anguo -
Fabio Varesano -
Karl Rudd -
sime