Based on http://drupal.org/node/101009 the value of version should be $Name$ to allow the packaging system to do the right thing. I am finding values other than $Name$ in info files. Earnie Boyd
Earnie Boyd wrote:
Based on http://drupal.org/node/101009 the value of version should be $Name$ to allow the packaging system to do the right thing. I am finding values other than $Name$ in info files.
Many developers created their .info files before we had established this standard. Hopefully over time they'll catch up to this.
Quoting Earl Miles <merlin@logrus.com>:
Earnie Boyd wrote:
Based on http://drupal.org/node/101009 the value of version should be $Name$ to allow the packaging system to do the right thing. I am finding values other than $Name$ in info files.
Many developers created their .info files before we had established this standard. Hopefully over time they'll catch up to this.
Hmm... I was thinking I just updated from CVS and found some modules with new info files that did do this? When was the standard established, sometime in November correct? -rw-r--r-- 1 boyde Administ 133 Dec 15 12:47 ./banner/banner.info version = 5.0-dev I'm not meaning to pick on banner just giving a cited example. Many others don't include the version string at all, I suppose that is ok or should it be supplied as stated with ``version = $Head$''? Earnie
Earnie Boyd wrote:
-rw-r--r-- 1 boyde Administ 133 Dec 15 12:47 ./banner/banner.info version = 5.0-dev
I'm not meaning to pick on banner just giving a cited example. Many others don't include the version string at all, I suppose that is ok or should it be supplied as stated with ``version = $Head$''?
Well, it's wrong but not insanely wrong, since really only people updating out of CVS will see this, and putting the actual version in CVS is probably ok too. It's harder because it has to be updated manually. For the most part it's not something to be too worried about, but it would be nice if contributors were consistent. You should feel free to submit an issue about this and see if that's what the module maintainer intended or if it's simply the result of not having read the right information (there are, after all, vast quantities of information to sift through) when doing the port.
On Dec 20, 2006, at 4:20 PM, Earnie Boyd wrote:
Based on http://drupal.org/node/101009 the value of version should be $Name$
actually, the page says (correctly) it should be "$Name$" (with quotes -- see your other email about needing to use quotes for strings in .ini files with non-alphanumeric characters). CVS will expand $Name$ to the name of the tag or branch you used to check out the file.
to allow the packaging system to do the right thing.
nope, the packaging system always does the right thing, regardless of what (if anything) the .info file says about the version. putting 'version = "$Name$"' in there is only a convenience for the subset of power-users who deploy their sites directly via "cvs checkout" instead of downloading packaged releases from drupal.org.
I am finding values other than $Name$ in info files.
don't be fooled by core. core modules use a somewhat sneaky trick for slightly better version info than "$Name$" -- they use the "VERSION" php define, instead. contrib should never do this. however, again, what the developers put in the .info files themselves only matters for the subset of people getting their source directly out of cvs. everyone else gets the nice human-readable version string, automatically included by the packaging script. cheers, -derek
participants (3)
-
Derek Wright -
Earl Miles -
Earnie Boyd