Re: [drupal-devel] Module Review: spam_mtblacklist
On Thu, 27 Jan 2005, Michael Jervis wrote:
Contributions/modules/spam_mtblacklist
Adds to the spam module, one new field in spam_custom, provides import and updates of spam blacklists from the MT Blacklist project.
Since the module is apparently only usefull together with the spam module it would be nice if it could either be integrated or at least distributed with Jeremy's spam module. This way we would avoid the "yet another module" thing. Cheers, Gerhard
---- Since the module is apparently only usefull together with the spam module it would be nice if it could either be integrated or at least distributed with Jeremy's spam module. This way we would avoid the "yet another module" thing. ---- Jeremy agreed it should be done as a separate module:
I've been thinking, I intend to implement this as a new module that requires the spam module and works with it to keep the code modular and separate. I think this is the right way to go as it allows the functionality to be totally removed if people don't want it.
I agree it should be a seperate module.
Sadly drupal's contrib system doesn't allow to distribute them together. (I don't think)
Hi Mike,
Contributions/modules/spam_mtblacklist
Adds to the spam module, one new field in spam_custom, provides import and updates of spam blacklists from the MT Blacklist project.
Since the module is apparently only usefull together with the spam module it would be nice if it could either be integrated or at least distributed with Jeremy's spam module. This way we would avoid the "yet another module" thing.
It does make sense to distribute this with the spam module. How about creating a subdirectory in the spam folder? Place the module, database script, and a README.txt explaining what the module does, etc. That will mean that everyone who downloads the spam module will also get a copy of the spam_mtblacklist. (And is why a README is important, so people know whether or not they want to install/enable it). In other words, the module could go here: contributions/modules/spam/spam_mtblacklist Sorry, I've not had time to actually look at / try it. ;) Cheers, -Jeremy
Op donderdag 27 januari 2005 23:50, schreef Jeremy Andrews:
In other words, the module could go here: contributions/modules/spam/spam_mtblacklist
Sorry, I've not had time to actually look at / try it. ;)
And dont forget to adjust your "components" in the project-settings. You should remove the items: Code, interface etc, and add: "Spam module", "Mtblacklist module". That way you can track your issues correctly. (In fact IMO these "collective distros" should be the only ones showing components, in all other cases its useless clutter.) Regards, Bèr -- [ Bèr Kessels | Drupal services www.webschuur.com ]
It does make sense to distribute this with the spam module. How about creating a >subdirectory in the spam folder?
Ok I'll move it to there and document it when I get a chance. There's no way to move it within CVS is there? Mike
participants (4)
-
Bèr Kessels -
Gerhard Killesreiter -
Jeremy Andrews -
Michael Jervis