Issue status update for http://drupal.org/node/19353 Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: jjeff Updated by: jjeff -Status: by design +Status: active Hi Moshe, That would be true if 'preview post' was not set to 'optional' (see above). However, because of this setting, 'submit' should always be available. Even if there was an error. The system shouldn't require a user to preview their post just because there was an error the first time they submitted. -Jeff jjeff Previous comments: ------------------------------------------------------------------------ March 23, 2005 - 21:34 : jjeff With 'preview post' set to 'optional' (in admin/node/configure), the node/add pages show a both 'preview' and 'submit' buttons at the bottom of the page (the correct behavior). But if your submitted page has an error (if for instance you forgot to add a Title), the 'submit' button goes away leaving only the 'preview' button. The submit button seems to get clobbered whenever the drupal_set_message() is called, but there may be more to it than this. ------------------------------------------------------------------------ March 23, 2005 - 22:57 : moshe weitzman if your form submission has errors, then we remove the submit button until you fix those errors. please re-open this case with more detail if this does not resolve the issue ... by design.

Issue status update for http://drupal.org/node/19353 Project: Drupal Version: cvs Component: node system -Category: bug reports +Category: tasks Priority: normal Assigned to: Anonymous Reported by: jjeff Updated by: Bèr Kessels Status: active IMHO, this is a useabilty task: not so much a bug. WE should re-think this, since indeed its strange behaviour. When "preview" is required this all works as it should. But lets takea case where preview is optional: I fill in a form incorrect press [submit] I get the form back with an error. I correct that error, and want to re-submit. Not possible. I have to preview (but I already fixed that error, so I should be able to submit right away, as i did in step 1) After preview I find out i fixed the error (doh) I can now submit. That is one page-load and two steps too much, IMO. Very valid issue IMO and really not a "By Design", unless someone has reasons why it should be like it is now. Bèr Kessels Previous comments: ------------------------------------------------------------------------ March 24, 2005 - 03:34 : jjeff With 'preview post' set to 'optional' (in admin/node/configure), the node/add pages show a both 'preview' and 'submit' buttons at the bottom of the page (the correct behavior). But if your submitted page has an error (if for instance you forgot to add a Title), the 'submit' button goes away leaving only the 'preview' button. The submit button seems to get clobbered whenever the drupal_set_message() is called, but there may be more to it than this. ------------------------------------------------------------------------ March 24, 2005 - 04:57 : moshe weitzman if your form submission has errors, then we remove the submit button until you fix those errors. please re-open this case with more detail if this does not resolve the issue ... by design. ------------------------------------------------------------------------ March 24, 2005 - 05:50 : jjeff Hi Moshe, That would be true if 'preview post' was not set to 'optional' (see above). However, because of this setting, 'submit' should always be available. Even if there was an error. The system shouldn't require a user to preview their post just because there was an error the first time they submitted. -Jeff ------------------------------------------------------------------------ March 24, 2005 - 08:20 : Eric Scouten Can somebody please justify *why* this is "by design"? The existing behavior strikes me as almost the single most annoying thing about Drupal. I often hack it out of my site installations.

Issue status update for http://drupal.org/node/19353 Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: Anonymous Reported by: jjeff Updated by: moshe weitzman Status: active i'll agree that this needs changing ... it is 'by *crappy* design moshe weitzman Previous comments: ------------------------------------------------------------------------ March 23, 2005 - 21:34 : jjeff With 'preview post' set to 'optional' (in admin/node/configure), the node/add pages show a both 'preview' and 'submit' buttons at the bottom of the page (the correct behavior). But if your submitted page has an error (if for instance you forgot to add a Title), the 'submit' button goes away leaving only the 'preview' button. The submit button seems to get clobbered whenever the drupal_set_message() is called, but there may be more to it than this. ------------------------------------------------------------------------ March 23, 2005 - 22:57 : moshe weitzman if your form submission has errors, then we remove the submit button until you fix those errors. please re-open this case with more detail if this does not resolve the issue ... by design. ------------------------------------------------------------------------ March 23, 2005 - 23:50 : jjeff Hi Moshe, That would be true if 'preview post' was not set to 'optional' (see above). However, because of this setting, 'submit' should always be available. Even if there was an error. The system shouldn't require a user to preview their post just because there was an error the first time they submitted. -Jeff ------------------------------------------------------------------------ March 24, 2005 - 02:20 : Eric Scouten Can somebody please justify *why* this is "by design"? The existing behavior strikes me as almost the single most annoying thing about Drupal. I often hack it out of my site installations. ------------------------------------------------------------------------ March 24, 2005 - 04:56 : Bèr Kessels IMHO, this is a useabilty task: not so much a bug. WE should re-think this, since indeed its strange behaviour. When "preview" is required this all works as it should. But lets takea case where preview is optional: I fill in a form incorrect press [submit] I get the form back with an error. I correct that error, and want to re-submit. Not possible. I have to preview (but I already fixed that error, so I should be able to submit right away, as i did in step 1) After preview I find out i fixed the error (doh) I can now submit. That is one page-load and two steps too much, IMO. Very valid issue IMO and really not a "By Design", unless someone has reasons why it should be like it is now. ------------------------------------------------------------------------ March 24, 2005 - 06:48 : leafish_paul +1 for Bèr's suggestions and for allowing submission immediately after correcting errors. Its extremely annoying. If previews are optional, then they should be optional regardless.

Issue status update for http://drupal.org/node/19353 Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: Anonymous Reported by: jjeff Updated by: TDobes Status: active Interestingly enough, the behavior for comment.module is different and (IMO) correct. The patch that accomplished this [1] explains the behavior quite clearly. Let's match node.module's behavior to that currently taken by comment.module. This would be good from a consistency standpoint and would also resolve this ever-annoying problem. [1] http://drupal.org/node/12555 TDobes Previous comments: ------------------------------------------------------------------------ March 23, 2005 - 20:34 : jjeff With 'preview post' set to 'optional' (in admin/node/configure), the node/add pages show a both 'preview' and 'submit' buttons at the bottom of the page (the correct behavior). But if your submitted page has an error (if for instance you forgot to add a Title), the 'submit' button goes away leaving only the 'preview' button. The submit button seems to get clobbered whenever the drupal_set_message() is called, but there may be more to it than this. ------------------------------------------------------------------------ March 23, 2005 - 21:57 : moshe weitzman if your form submission has errors, then we remove the submit button until you fix those errors. please re-open this case with more detail if this does not resolve the issue ... by design. ------------------------------------------------------------------------ March 23, 2005 - 22:50 : jjeff Hi Moshe, That would be true if 'preview post' was not set to 'optional' (see above). However, because of this setting, 'submit' should always be available. Even if there was an error. The system shouldn't require a user to preview their post just because there was an error the first time they submitted. -Jeff ------------------------------------------------------------------------ March 24, 2005 - 01:20 : Eric Scouten Can somebody please justify *why* this is "by design"? The existing behavior strikes me as almost the single most annoying thing about Drupal. I often hack it out of my site installations. ------------------------------------------------------------------------ March 24, 2005 - 03:56 : Bèr Kessels IMHO, this is a useabilty task: not so much a bug. WE should re-think this, since indeed its strange behaviour. When "preview" is required this all works as it should. But lets takea case where preview is optional: I fill in a form incorrect press [submit] I get the form back with an error. I correct that error, and want to re-submit. Not possible. I have to preview (but I already fixed that error, so I should be able to submit right away, as i did in step 1) After preview I find out i fixed the error (doh) I can now submit. That is one page-load and two steps too much, IMO. Very valid issue IMO and really not a "By Design", unless someone has reasons why it should be like it is now. ------------------------------------------------------------------------ March 24, 2005 - 05:48 : leafish_paul +1 for Bèr's suggestions and for allowing submission immediately after correcting errors. Its extremely annoying. If previews are optional, then they should be optional regardless. ------------------------------------------------------------------------ March 24, 2005 - 07:18 : moshe weitzman i'll agree that this needs changing ... it is 'by *crappy* design ------------------------------------------------------------------------ March 24, 2005 - 08:03 : jhriggs Another +1 on Bèr's suggestion.

Issue status update for http://drupal.org/node/19353 Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: TDobes Reported by: jjeff Updated by: Steven -Status: patch +Status: fixed Applied to HEAD. Steven Previous comments: ------------------------------------------------------------------------ March 24, 2005 - 03:34 : jjeff With 'preview post' set to 'optional' (in admin/node/configure), the node/add pages show a both 'preview' and 'submit' buttons at the bottom of the page (the correct behavior). But if your submitted page has an error (if for instance you forgot to add a Title), the 'submit' button goes away leaving only the 'preview' button. The submit button seems to get clobbered whenever the drupal_set_message() is called, but there may be more to it than this. ------------------------------------------------------------------------ March 24, 2005 - 04:57 : moshe weitzman if your form submission has errors, then we remove the submit button until you fix those errors. please re-open this case with more detail if this does not resolve the issue ... by design. ------------------------------------------------------------------------ March 24, 2005 - 05:50 : jjeff Hi Moshe, That would be true if 'preview post' was not set to 'optional' (see above). However, because of this setting, 'submit' should always be available. Even if there was an error. The system shouldn't require a user to preview their post just because there was an error the first time they submitted. -Jeff ------------------------------------------------------------------------ March 24, 2005 - 08:20 : Eric Scouten Can somebody please justify *why* this is "by design"? The existing behavior strikes me as almost the single most annoying thing about Drupal. I often hack it out of my site installations. ------------------------------------------------------------------------ March 24, 2005 - 10:56 : Bèr Kessels IMHO, this is a useabilty task: not so much a bug. WE should re-think this, since indeed its strange behaviour. When "preview" is required this all works as it should. But lets takea case where preview is optional: I fill in a form incorrect press [submit] I get the form back with an error. I correct that error, and want to re-submit. Not possible. I have to preview (but I already fixed that error, so I should be able to submit right away, as i did in step 1) After preview I find out i fixed the error (doh) I can now submit. That is one page-load and two steps too much, IMO. Very valid issue IMO and really not a "By Design", unless someone has reasons why it should be like it is now. ------------------------------------------------------------------------ March 24, 2005 - 12:48 : leafish_paul +1 for Bèr's suggestions and for allowing submission immediately after correcting errors. Its extremely annoying. If previews are optional, then they should be optional regardless. ------------------------------------------------------------------------ March 24, 2005 - 14:18 : moshe weitzman i'll agree that this needs changing ... it is 'by *crappy* design ------------------------------------------------------------------------ March 24, 2005 - 15:03 : jhriggs Another +1 on Bèr's suggestion. ------------------------------------------------------------------------ March 26, 2005 - 06:18 : TDobes Interestingly enough, the behavior for comment.module is different and (IMO) correct. The patch that accomplished this [1] explains the behavior quite clearly. Let's match node.module's behavior to that currently taken by comment.module. This would be good from a consistency standpoint and would also resolve this ever-annoying problem. [1] http://drupal.org/node/12555 ------------------------------------------------------------------------ March 27, 2005 - 12:47 : TDobes Attachment: http://drupal.org/files/issues/improve_node_submit_behavior.patch (844 bytes) Here's a patch. It matches the behavior of the "submit" button on node.module to that of comment.module. The submit now always appears if node preview is optional. Submit will disappear if node preview is required AND it is (a.) the first time the user has viewed the node form or (b.) there is an error on the form. Note that people still cannot submit invalid data, as node.module will not allow the form to be submitted with invalid data. I recommend that this be reviewed/applied before 4.6 is released, as it seems to annoy a lot of people (myself included) and would be an excellent usability improvement.