Okay, in keeping with recent sentiments expressed on this list, here are two module ideas: 1. Longer site slogan - My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; it's just so simple that I can't see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesn't fit either very well. I'm sure there is at least one other Drupaller who will need this some time or another, so I'd like to find a better place 2. This customer wants drop down menu tabs and the theme's Suckerfish menus work fine for this. However, they would prefer that the menu tab not point to the first page in the menu tree. In searching DO, I didn't like any solution to the "menu no-link" problem. What I would prefer, and am prepared to start writing, is a little module that provides a page (not a block) that shows the tree structure of that menu item (title and description). Before I spend too much time, does anyone do this already or know of a module I didn't find? Nancy E. Wichmann, PMP (781) 697-6344 Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
On #2, we have menu_node_views() in dev that might help. http://drupal.org/project/menu_node_views And menu block might already handle that. We've built similar things in Panels with Menu Block panes. http://drupal.org/project/menu_block - Ken On Wed, Dec 16, 2009 at 11:32 AM, Nancy Wichmann <nan_wich@bellsouth.net> wrote:
Okay, in keeping with recent sentiments expressed on this list, here are two module ideas:
1. Longer site slogan – My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; it’s just so simple that I can’t see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesn’t fit either very well. I’m sure there is at least one other Drupaller who will need this some time or another, so I’d like to find a better place
2. This customer wants drop down menu tabs and the theme’s Suckerfish menus work fine for this. However, they would prefer that the menu tab not point to the first page in the menu tree. In searching DO, I didn’t like any solution to the “menu no-link” problem. What I would prefer, and am prepared to start writing, is a little module that provides a page (not a block) that shows the tree structure of that menu item (title and description). Before I spend too much time, does anyone do this already or know of a module I didn’t find?
Nancy E. Wichmann, PMP
(781) 697-6344
Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
-- Ken Rickard agentrickard@gmail.com http://ken.therickards.com
Very close, Ken, but no cigar. But I wonder if I can borrow your API. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr. -----Original Message----- From: development-bounces@drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Ken Rickard Sent: Wednesday, December 16, 2009 2:10 PM To: development@drupal.org Subject: Re: [development] Two module ideas On #2, we have menu_node_views() in dev that might help. http://drupal.org/project/menu_node_views And menu block might already handle that. We've built similar things in Panels with Menu Block panes. http://drupal.org/project/menu_block - Ken On Wed, Dec 16, 2009 at 11:32 AM, Nancy Wichmann <nan_wich@bellsouth.net> wrote:
Okay, in keeping with recent sentiments expressed on this list, here are two module ideas:
1. Longer site slogan My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; its just so simple that I cant see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesnt fit either very well. Im sure there is at least one other Drupaller who will need this some time or another, so Id like to find a better place
2. This customer wants drop down menu tabs and the themes Suckerfish menus work fine for this. However, they would prefer that the menu tab not point to the first page in the menu tree. In searching DO, I didnt like any solution to the menu no-link problem. What I would prefer, and am prepared to start writing, is a little module that provides a page (not a block) that shows the tree structure of that menu item (title and description). Before I spend too much time, does anyone do this already or know of a module I didnt find?
Nancy E. Wichmann, PMP
(781) 697-6344
Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
-- Ken Rickard agentrickard@gmail.com http://ken.therickards.com No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.716 / Virus Database: 270.14.109/2567 - Release Date: 12/16/09 03:02:00
Always. Menu Node Views is a merged project for all things menu-related, so it might actually be made to fit your needs. On Wed, Dec 16, 2009 at 6:23 PM, Nancy Wichmann <nan_wich@bellsouth.net> wrote:
Very close, Ken, but no cigar. But I wonder if I can borrow your API.
Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
-----Original Message----- From: development-bounces@drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Ken Rickard Sent: Wednesday, December 16, 2009 2:10 PM To: development@drupal.org Subject: Re: [development] Two module ideas
On #2, we have menu_node_views() in dev that might help.
http://drupal.org/project/menu_node_views
And menu block might already handle that. We've built similar things in Panels with Menu Block panes.
http://drupal.org/project/menu_block
- Ken
On Wed, Dec 16, 2009 at 11:32 AM, Nancy Wichmann <nan_wich@bellsouth.net> wrote:
Okay, in keeping with recent sentiments expressed on this list, here are two module ideas:
1. Longer site slogan – My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; it’s just so simple that I can’t see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesn’t fit either very well. I’m sure there is at least one other Drupaller who will need this some time or another, so I’d like to find a better place
2. This customer wants drop down menu tabs and the theme’s Suckerfish menus work fine for this. However, they would prefer that the menu tab not point to the first page in the menu tree. In searching DO, I didn’t like any solution to the “menu no-link” problem. What I would prefer, and am prepared to start writing, is a little module that provides a page (not a block) that shows the tree structure of that menu item (title and description). Before I spend too much time, does anyone do this already or know of a module I didn’t find?
Nancy E. Wichmann, PMP
(781) 697-6344
Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
-- Ken Rickard agentrickard@gmail.com http://ken.therickards.com No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.716 / Virus Database: 270.14.109/2567 - Release Date: 12/16/09 03:02:00
-- Ken Rickard agentrickard@gmail.com http://ken.therickards.com
Nancy, thanks a lot for following this recommendation. I hope that everyone sees the benefits of announcing a module before development and I hope all other developers follow Nancy's footsteps in this regard. Perhaps reconsidering the idea of making this compulsory would be a good idea. I do not want to get into this conversation again, but simply trying to emphasize to everyone the benefits gained and trying to show that this cannot be considered raising the barrier for existing/potential developers. Regards, AA On Thu, Dec 17, 2009 at 4:45 AM, Ken Rickard <agentrickard@gmail.com> wrote:
Always.
Menu Node Views is a merged project for all things menu-related, so it might actually be made to fit your needs.
On Wed, Dec 16, 2009 at 6:23 PM, Nancy Wichmann <nan_wich@bellsouth.net> wrote:
Very close, Ken, but no cigar. But I wonder if I can borrow your API.
Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
-----Original Message----- From: development-bounces@drupal.org [mailto: development-bounces@drupal.org] On Behalf Of Ken Rickard Sent: Wednesday, December 16, 2009 2:10 PM To: development@drupal.org Subject: Re: [development] Two module ideas
On #2, we have menu_node_views() in dev that might help.
http://drupal.org/project/menu_node_views
And menu block might already handle that. We've built similar things in Panels with Menu Block panes.
http://drupal.org/project/menu_block
- Ken
On Wed, Dec 16, 2009 at 11:32 AM, Nancy Wichmann <nan_wich@bellsouth.net
wrote:
Okay, in keeping with recent sentiments expressed on this list, here are two module ideas:
1. Longer site slogan – My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; it’s just so simple that I can’t see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesn’t fit either very well. I’m sure there is at least one other Drupaller who will need this some time or another, so I’d like to find a better place
2. This customer wants drop down menu tabs and the theme’s Suckerfish menus work fine for this. However, they would prefer that the menu tab not point to the first page in the menu tree. In searching DO, I didn’t like any solution to the “menu no-link” problem. What I would prefer, and am prepared to start writing, is a little module that provides a page (not a block) that shows the tree structure of that menu item (title and description). Before I spend too much time, does anyone do this already or know of a module I didn’t find?
Nancy E. Wichmann, PMP
(781) 697-6344
Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
-- Ken Rickard agentrickard@gmail.com http://ken.therickards.com No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.716 / Virus Database: 270.14.109/2567 - Release Date: 12/16/09 03:02:00
-- Ken Rickard agentrickard@gmail.com http://ken.therickards.com
-- Ashraf Amayreh http://aamayreh.org
On Wed, 2009-12-16 at 11:32 -0500, Nancy Wichmann wrote:
Okay, in keeping with recent sentiments expressed on this list, here are two module ideas:
1. Longer site slogan – My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; it’s just so simple that I can’t see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesn’t fit either very well. I’m sure there is at least one other Drupaller who will need this some time or another, so I’d like to find a better place
My opinion is that core should not limit site slogan to 128 chars, may be that would be a good topic for a feature/bug request on drupal.org Pïerre.
Core should not have a site slogan, that should be a block in a region and done with it. Many themes, including Fusion, have such regions, otherwise it is pretty easy to create a content top or a node top region. #smallcore ftw! Victor Kane http://awebfactory.com.ar http://projectflowandtracker.com On Fri, Dec 18, 2009 at 6:36 AM, Pierre Rineau < pierre.rineau@makina-corpus.com> wrote:
On Wed, 2009-12-16 at 11:32 -0500, Nancy Wichmann wrote:
Okay, in keeping with recent sentiments expressed on this list, here are two module ideas:
1. Longer site slogan – My current customer wanted a slogan longer than 128 characters (yes, there is a good reason). Rather than doing a simple core hack, I wrote a simple little module that uses hook_form_alter() to change it. I actually already have this done; it’s just so simple that I can’t see contributing it as a separate module. Since I am a maintainer on both Helpers and Util, I thought about them, but it really doesn’t fit either very well. I’m sure there is at least one other Drupaller who will need this some time or another, so I’d like to find a better place
My opinion is that core should not limit site slogan to 128 chars, may be that would be a good topic for a feature/bug request on drupal.org
Pïerre.
Victor Kane wrote:
Core should not have a site slogan, that should be a block in a region
I have no problem with core supporting a slogan, although I can see that as really belonging to themes. Some themes don't even support it. Support for a mission is the same, although it is generally implemented as a block, as you suggest. However, that is not the issue here. The theme I am using supports slogans in a manner which is useful in this case. The problem is that core does not specify a #maxlength parameter so it defaults to 128 and that is inadequate for my needs. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
Pierre Rineau wrote:
good topic for a feature/bug request I agree, but we have to live with the current situation through D7 since it is now frozen.
So the issue is where to put this trivial change. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
Nancy and list: Personally I think this falls under the '5 lines or less of code' and 'trivial modification', so it would be more appropriate for a custom module in your site rather than a full-blown project on drupal.org. Dave Reid dave@davereid.net On Fri, Dec 18, 2009 at 7:40 AM, Nancy Wichmann <nan_wich@bellsouth.net>wrote:
I agree, but we have to live with the current situation through D7 since it is now frozen.
So the issue is where to put this trivial change.
Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.
On Fri, Dec 18, 2009 at 11:29 AM, Dave Reid <dave@davereid.net> wrote:
Personally I think this falls under the '5 lines or less of code' and 'trivial modification', so it would be more appropriate for a custom module in your site rather than a full-blown project on drupal.org.
Agreed - the other place for stuff like this is the CVS sandbox http://drupalcode.org/viewvc/drupal/contributions/sandbox/ Regards, Greg -- Greg Knaddison | 303-800-5623 | http://growingventuresolutions.com Mastering Drupal - http://www.masteringdrupal.com
I totally agree, Dave, that's why I was hoping someone had a module it would fit into. Worse case is that I can add it to Util. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr. From: development-bounces@drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Dave Reid Sent: Friday, December 18, 2009 1:30 PM To: development@drupal.org Subject: Re: [development] Two module ideas Nancy and list: Personally I think this falls under the '5 lines or less of code' and 'trivial modification', so it would be more appropriate for a custom module in your site rather than a full-blown project on drupal.org. Dave Reid dave@davereid.net On Fri, Dec 18, 2009 at 7:40 AM, Nancy Wichmann <nan_wich@bellsouth.net> wrote: I agree, but we have to live with the current situation through D7 since it is now frozen. So the issue is where to put this trivial change. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr. No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.716 / Virus Database: 270.14.112/2571 - Release Date: 12/18/09 02:35:00
I totally agree, Dave, that's why I was hoping someone had a module it would fit into. Worse case is that I can add it to Util.
function custom_form_system_site_information_settings_alter(&$form) { $form['site_slogan']['#type'] = 'textarea'; } 3 lines, actually. I'd say that this is even too specific for Util. Luckily, D7 will allow you to put this code into your theme, so you don't even need a custom.module. sun
Well, if you want to split hairs... function longer_slogan_form_alter(&$form, &$form_state, $form_id) { switch ($form_id) { case 'system_site_information_settings': $form['site_slogan']['#type'] = 'textarea'; $form['site_slogan']['#rows'] = 1; $form['site_slogan']['#maxlength'] = 256; break; } return $form; } function longer_slogan_uninstall() { $slogan = variable_get('site_slogan', ''); if (drupal_strlen($slogan) > 128) { drupal_set_message(t('The current slogan exceeds the default maximum length (128). It will continue to work, but the Site Information form will fail if edited.'), 'error'); } } I would be happy if core just changed the 128 default to 256. And yes, I will be submitting a patch for D8. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr. -----Original Message----- From: development-bounces@drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Daniel F. Kudwien Sent: Friday, December 18, 2009 2:45 PM To: development@drupal.org Subject: Re: [development] Two module ideas
I totally agree, Dave, that's why I was hoping someone had a module it would fit into. Worse case is that I can add it to Util.
function custom_form_system_site_information_settings_alter(&$form) { $form['site_slogan']['#type'] = 'textarea'; } 3 lines, actually. I'd say that this is even too specific for Util. Luckily, D7 will allow you to put this code into your theme, so you don't even need a custom.module. sun No virus found in this incoming message. Checked by AVG - www.avg.com Version: 9.0.716 / Virus Database: 270.14.112/2571 - Release Date: 12/18/09 02:35:00
participants (8)
-
Ashraf Amayreh -
Daniel F. Kudwien -
Dave Reid -
Greg Knaddison -
Ken Rickard -
Nancy Wichmann -
Pierre Rineau -
Victor Kane