Issue status update for http://drupal.org/node/27948 Post a follow up: http://drupal.org/project/comments/add/27948 Project: Drupal Version: cvs Component: profile.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: robertDouglass Updated by: robertDouglass Status: patch (ready to be committed) performance aside, we can fix the bug, right? robertDouglass Previous comments: ------------------------------------------------------------------------ Mon, 01 Aug 2005 12:27:39 +0000 : robertDouglass This needs confirmation but I am unable to get fields to be shown in the author information block. The 'Link to full user profile' will work, but when I deselect 'Link to full user profile' from admin/block/configure/profile/0 and select the other fields instead, the block fails to materialize. ------------------------------------------------------------------------ Thu, 11 Aug 2005 23:08:32 +0000 : tostinni Attachment: http://drupal.org/files/issues/profile.module_2.patch (1.09 KB) This little patch does the trick. The bug came from the fact that the query retrieving user profiles, didn't take all public fields. ------------------------------------------------------------------------ Thu, 01 Sep 2005 18:57:21 +0000 : killes@www.drop.org Attachment: http://drupal.org/files/issues/profile_1.patch (1.12 KB) I've looked at the patch, changes "in" to "IN" and removed trailign DOS newlines, and can confirm that it works. ------------------------------------------------------------------------ Thu, 01 Sep 2005 18:58:15 +0000 : killes@www.drop.org changing status ------------------------------------------------------------------------ Fri, 02 Sep 2005 07:21:03 +0000 : Dries Is using IN() equivalent to using OR or is one faster than the other? ------------------------------------------------------------------------ Fri, 02 Sep 2005 12:47:56 +0000 : killes@www.drop.org Cvbge and I think that it is equivalent in this case. it is unsure whether it is faster, but IN () is usually regarded as being fast: http://mysql.com/in ------------------------------------------------------------------------ Fri, 02 Sep 2005 13:28:39 +0000 : tostinni I'm not a DB expert, but I got a little experience on Oracle (great you can answer ;) but I think it should happen pretty much the same), so IMVHO, I think that they're doing the same, in fact, looking at Oracle explain plan, it's exactly the same between a OR and a IN clause. They both do the same explain plan using "INLIST ITERATOR" in fact, the cost is the same, but explain plan tells me that it takes slightly less bytes to achieve it... Ok sorry if very off topic and useless, but I thought it worthes to mention that. Back to our query, I think whatever we put OR or IN clause, we shouldn't expect speed problem with this, as it's very little the change. If we do care about it, I think we should add an INDEX on this column. Also, I think IN clauses in this case (using 2 or more coma separated values) is much clearer than writing a lot of OR.