Re: [drupal-devel] [contributions:dries] /themes/pushbutton arrow-next-hover.png arrow-next-visited.png arrow-next.png arrow-prev-hover.png arrow-prev-visited.png arrow-prev.png arrow-up-hover.png arrow-up-visited.png arrow-up.png background.png forum-container.jpg
On 4 May 2005 18:01:46 -0000, drupal-cvs@drupal.org <drupal-cvs@drupal.org> wrote:
User: dries Branch: HEAD Date: Wed, 04 May 2005 18:01:46 +0000
Added files: /themes/pushbutton arrow-next-hover.png arrow-next-visited.png arrow-next.png arrow-prev-hover.png arrow-prev-visited.png arrow-prev.png arrow-up-hover.png arrow-up-visited.png arrow-up.png background.png forum-container.jpg forum-link.png header-a.jpg header-b.jpg header-c.png icon-block.png icon-comment.png logo-active.jpg logo-background.jpg logo-hover.jpg logo.png screenshot.png style.css tabs-off.png tabs-on.png tabs-option-hover.png tabs-option-off.png tabs-option-on.png xtemplate.xtmpl
Log message: - Moving pushbutton to contrib. Maybe we should convert it to PHPtemplate?
See the pushbutton_phptemplate theme in contrib [1]. Apparently, it was only added for 4.5, so it might need some minor updates for 4.6+. I have not used it personally, so I am not sure how well it works. [1] http://cvs.drupal.org/viewcvs/drupal/contributions/themes/pushbutton_phptemp...
I have tested Pushbutton phptemplate just after 4.6 came out, with 4.6, and it works fine without any modifications. I can't recall which version I pulled out though, 4.5 or the then cvs. On 5/4/05, Tom Dobes <tdobes@gmail.com> wrote:
On 4 May 2005 18:01:46 -0000, drupal-cvs@drupal.org <drupal-cvs@drupal.org> wrote:
User: dries Branch: HEAD Date: Wed, 04 May 2005 18:01:46 +0000
Log message: - Moving pushbutton to contrib. Maybe we should convert it to PHPtemplate?
See the pushbutton_phptemplate theme in contrib [1]. Apparently, it was only added for 4.5, so it might need some minor updates for 4.6+. I have not used it personally, so I am not sure how well it works.
[1] http://cvs.drupal.org/viewcvs/drupal/contributions/themes/pushbutton_phptemp...
I forgot to mention: here is the project for this theme version. http://drupal.org/node/15059 As you can see, it is fairly recent (Jan 2005). I have no idea it is in the attic. On 5/4/05, K B <kbahey@gmail.com> wrote:
I have tested Pushbutton phptemplate just after 4.6 came out, with 4.6, and it works fine without any modifications.
I can't recall which version I pulled out though, 4.5 or the then cvs.
On 5/4/05, Tom Dobes <tdobes@gmail.com> wrote:
On 4 May 2005 18:01:46 -0000, drupal-cvs@drupal.org <drupal-cvs@drupal.org> wrote:
User: dries Branch: HEAD Date: Wed, 04 May 2005 18:01:46 +0000
Log message: - Moving pushbutton to contrib. Maybe we should convert it to PHPtemplate?
See the pushbutton_phptemplate theme in contrib [1]. Apparently, it was only added for 4.5, so it might need some minor updates for 4.6+. I have not used it personally, so I am not sure how well it works.
[1] http://cvs.drupal.org/viewcvs/drupal/contributions/themes/pushbutton_phptemp...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Most phptemplate 4.5 templates work without change on phptemplate 4.6. I think friendselectric is one of the few that doesn't. (because of changes to theme_ functions that it overrides iirc.) On 04 May 2005, at 8:41 PM, K B wrote:
I forgot to mention: here is the project for this theme version.
As you can see, it is fairly recent (Jan 2005). I have no idea it is in the attic.
On 5/4/05, K B <kbahey@gmail.com> wrote:
I have tested Pushbutton phptemplate just after 4.6 came out, with 4.6, and it works fine without any modifications.
I can't recall which version I pulled out though, 4.5 or the then cvs.
On 5/4/05, Tom Dobes <tdobes@gmail.com> wrote:
On 4 May 2005 18:01:46 -0000, drupal-cvs@drupal.org <drupal-cvs@drupal.org> wrote:
User: dries Branch: HEAD Date: Wed, 04 May 2005 18:01:46 +0000
Log message: - Moving pushbutton to contrib. Maybe we should convert it to PHPtemplate?
See the pushbutton_phptemplate theme in contrib [1]. Apparently, it was only added for 4.5, so it might need some minor updates for 4.6+. I have not used it personally, so I am not sure how well it works.
[1] http://cvs.drupal.org/viewcvs/drupal/contributions/themes/ pushbutton_phptemplate/Attic/
- -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) iD8DBQFCeTW4gegMqdGlkasRApSaAJwNJL24WdSEmMLD43oPNEud+b112ACfcwuM MpGx/oSD2Nh3UNzBlCZqgTc= =rPS1 -----END PGP SIGNATURE-----
On 5/4/05, Adrian Rossouw <adrian@bryght.com> wrote:
Most phptemplate 4.5 templates work without change on phptemplate 4.6.
Two changes must be made to update a 4.5 phptemplate theme (without custom code) to current CVS HEAD: 1. The name for the search field must be changed from "keys" to "edit[keys]" 2. The #help item surrounding $help must be removed. (A div#help is now included in the $help variable, as generated by theme_help) A couple other changes landed on core copy of pushbutton which will need to be merged. I will work on this over the weekend if no one else takes up the project before then. Tom
On 5/4/05, Tom Dobes <tdobes@gmail.com> wrote:
2. The #help item surrounding $help must be removed. (A div#help is now included in the $help variable, as generated by theme_help)
Tom Can you explain this a little bit more? Is this something that needs to happen for every theme, or specific to pushbutton? Can you also explain more what needs to be changed in more detail? Thanks
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05 May 2005, at 12:38 AM, K B wrote:
Can you explain this a little bit more? Is this something that needs to happen for every theme, or specific to pushbutton? Can you also explain more what needs to be changed in more detail? This is for all phptemplate templates. The underlying theme_ functions have been changed to be more consistent.
We found it was common in all templates to have : <?php if ($help) : ?> <div class='help'><?php print $help ?></div> <?php endif; ?> The html in there was moved to a theme_help function , so now you only have to do : <?php print $help ?> in your templates. The new menu stuff that still needs to land will change the templates too. The end result of the link changes will be that we will change : <?php if (is_array($primary_links)) : ?> <ul> <?php foreach ($primary_links as $link): ?> <li><?php print $link?></li> <?php endforeach; ?> </ul> <?php endif; ?> into : <?php print ($primary_links) ?> Similarly, due to a new theme_ function we will be introducing. PHPTemplate only landed today,and there's a lot of things in the theme system that will be changing in the near to mid future. These will all be documented fairly soon. - -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) iD8DBQFCeVFrgegMqdGlkasRAlGrAJ9kUijI6IBfTl38cYU2L8wbOzC8NQCcCtD6 Z57FFVaU/Z4ZClNsZ0d4C5M= =rveH -----END PGP SIGNATURE-----
On 04 May 2005, at 23:17, Tom Dobes wrote:
On 5/4/05, Adrian Rossouw <adrian@bryght.com> wrote:
Most phptemplate 4.5 templates work without change on phptemplate 4.6.
Two changes must be made to update a 4.5 phptemplate theme (without custom code) to current CVS HEAD: 1. The name for the search field must be changed from "keys" to "edit[keys]" 2. The #help item surrounding $help must be removed. (A div#help is now included in the $help variable, as generated by theme_help)
A couple other changes landed on core copy of pushbutton which will need to be merged. I will work on this over the weekend if no one else takes up the project before then.
FYI: I haven't made these changes when I committed the pushbutton theme. Sorry. At this point, it might be a good idea to: (i) Announce the inclusion of PHPTemplate and the /removal/ of Xtemplate so people can take this into account when creating themes for Drupal 4.6. (ii) Copy (part of) the information to a "Converting 4.6 themes to HEAD" page in the "Theme developer's guide". See http://drupal.org/node/13222. -- Dries Buytaert :: http://www.buytaert.net/
On 04 May 2005, at 20:41, K B wrote:
I forgot to mention: here is the project for this theme version.
As you can see, it is fairly recent (Jan 2005). I have no idea it is in the attic.
I added the PHPTemplate-based port of pushbutton to core. TODO: - Evolve Pushbutton and Bluemarine so they got something fresh and crispy by the time Drupal 4.7 is released. In general, it wouldn't hurt to show off some of Drupal's theme capabilities a bit more. - Ensure that the 'new' Pushbutton and Bluemarine validate as XHTML - Ensure that the 'new' Pushbutton and Bluemarine pass the most important web accessibility tests. - See if we can make administration pages stand out. This should be fairly easy with some CSS magic. -- Dries Buytaert :: http://www.buytaert.net/
participants (4)
-
Adrian Rossouw -
Dries Buytaert -
K B -
Tom Dobes