[drupal-devel] [bug] collapsible fieldset icon and ie 5.0
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: minor Assigned to: fago Reported by: fago Updated by: fago Status: patch (code needs review) Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached fago
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: cvs Component: other Category: bug reports Priority: minor Assigned to: fago Reported by: fago Updated by: Thox Status: patch (code needs review) I'd like to see your IE table fix in the patch too, it's much cleaner than any of the approaches I was trying. I've tested the current patch and it works fine in IE5, IE6, FF, Opera, and an old copy of Konqueror. I'd like to know that the patch doesn't affect Safari before it gets applied. Thox Previous comments: ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:04:21 +0000 : fago Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: cvs Component: other Category: bug reports Priority: minor Assigned to: fago Reported by: fago Updated by: stefan nagtegaal Status: patch (code needs review) I can confirm that it does not effect Safari, because the CSS is never applied to the document because the AJAX/JS doesn't work on Safari.. stefan nagtegaal Previous comments: ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:04:21 +0000 : fago Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:22:58 +0000 : Thox I'd like to see your IE table fix in the patch too, it's much cleaner than any of the approaches I was trying. I've tested the current patch and it works fine in IE5, IE6, FF, Opera, and an old copy of Konqueror. I'd like to know that the patch doesn't affect Safari before it gets applied.
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: cvs Component: other Category: bug reports Priority: minor Assigned to: fago Reported by: fago Updated by: fago Status: patch (code needs review) Attachment: http://drupal.org/files/issues/ie-table-fix.patch (495 bytes) ok, here it is :) -> fixes tables in collapsed fieldsets for IE5 and 6 i've tested both patches in IE5.0, IE6, FF, opera7 and konqueror 3.4 fago Previous comments: ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:04:21 +0000 : fago Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:22:58 +0000 : Thox I'd like to see your IE table fix in the patch too, it's much cleaner than any of the approaches I was trying. I've tested the current patch and it works fine in IE5, IE6, FF, Opera, and an old copy of Konqueror. I'd like to know that the patch doesn't affect Safari before it gets applied. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:56:44 +0000 : stefan nagtegaal I can confirm that it does not effect Safari, because the CSS is never applied to the document because the AJAX/JS doesn't work on Safari..
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: cvs Component: other Category: bug reports -Priority: minor +Priority: critical Assigned to: fago Reported by: fago Updated by: gordon -Status: patch (code needs review) +Status: patch (ready to be committed) +1 This flex my problems with the tables not expanding correctly under IE. Please apply. gordon Previous comments: ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:04:21 +0000 : fago Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:22:58 +0000 : Thox I'd like to see your IE table fix in the patch too, it's much cleaner than any of the approaches I was trying. I've tested the current patch and it works fine in IE5, IE6, FF, Opera, and an old copy of Konqueror. I'd like to know that the patch doesn't affect Safari before it gets applied. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:56:44 +0000 : stefan nagtegaal I can confirm that it does not effect Safari, because the CSS is never applied to the document because the AJAX/JS doesn't work on Safari.. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:59:35 +0000 : fago Attachment: http://drupal.org/files/issues/ie-table-fix.patch (495 bytes) ok, here it is :) -> fixes tables in collapsed fieldsets for IE5 and 6 i've tested both patches in IE5.0, IE6, FF, opera7 and konqueror 3.4
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: cvs Component: other Category: bug reports Priority: critical Assigned to: fago Reported by: fago Updated by: Dries -Status: patch (ready to be committed) +Status: patch (code needs work) I'd add a code comment to document why this is needed. You can shorten that patch by merging it with the next block in the CSS file. Dries Previous comments: ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:04:21 +0000 : fago Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:22:58 +0000 : Thox I'd like to see your IE table fix in the patch too, it's much cleaner than any of the approaches I was trying. I've tested the current patch and it works fine in IE5, IE6, FF, Opera, and an old copy of Konqueror. I'd like to know that the patch doesn't affect Safari before it gets applied. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:56:44 +0000 : stefan nagtegaal I can confirm that it does not effect Safari, because the CSS is never applied to the document because the AJAX/JS doesn't work on Safari.. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:59:35 +0000 : fago Attachment: http://drupal.org/files/issues/ie-table-fix.patch (495 bytes) ok, here it is :) -> fixes tables in collapsed fieldsets for IE5 and 6 i've tested both patches in IE5.0, IE6, FF, opera7 and konqueror 3.4 ------------------------------------------------------------------------ Thu, 18 Aug 2005 00:33:11 +0000 : gordon +1 This flex my problems with the tables not expanding correctly under IE. Please apply.
Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: cvs Component: other Category: bug reports Priority: critical Assigned to: fago Reported by: fago Updated by: fago -Status: patch (code needs work) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/ie-fieldset-fix.patch (696 bytes) i 've followed dries hints and created a new patch. this one includes both above patches. fago Previous comments: ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:04:21 +0000 : fago Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:22:58 +0000 : Thox I'd like to see your IE table fix in the patch too, it's much cleaner than any of the approaches I was trying. I've tested the current patch and it works fine in IE5, IE6, FF, Opera, and an old copy of Konqueror. I'd like to know that the patch doesn't affect Safari before it gets applied. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:56:44 +0000 : stefan nagtegaal I can confirm that it does not effect Safari, because the CSS is never applied to the document because the AJAX/JS doesn't work on Safari.. ------------------------------------------------------------------------ Wed, 17 Aug 2005 20:59:35 +0000 : fago Attachment: http://drupal.org/files/issues/ie-table-fix.patch (495 bytes) ok, here it is :) -> fixes tables in collapsed fieldsets for IE5 and 6 i've tested both patches in IE5.0, IE6, FF, opera7 and konqueror 3.4 ------------------------------------------------------------------------ Thu, 18 Aug 2005 00:33:11 +0000 : gordon +1 This flex my problems with the tables not expanding correctly under IE. Please apply. ------------------------------------------------------------------------ Thu, 18 Aug 2005 05:18:02 +0000 : Dries I'd add a code comment to document why this is needed. You can shorten that patch by merging it with the next block in the CSS file.
participants (5)
-
Dries -
fago -
gordon -
stefan nagtegaal -
Thox