Re: [bug] Allow embedded images in project description
Thanks for the feedback Dries. I'd be happy to take another crack at this patch later this week. I have a business trip that will keep me tied up until probably Friday at least. On 3/6/06, Dries <drupal-devel@drupal.org> wrote:
Issue status update for http://drupal.org/node/49575 Post a follow up: http://drupal.org/project/comments/add/49575
Project: Project Version: cvs Component: User interface Category: bug reports Priority: normal Assigned to: Anonymous Reported by: der Updated by: Dries Status: patch (code needs review)
Code comment: we should wrap a check_url() around the screenshot URL (depending on the format). We should add an alt-attribute for level 1 accessibility.
What happens with projects who configured a screenshot link? The Drupal project's screenshot link, for example, points to a gallery (see http://drupal.org/project/drupal). Maybe we need to add a second URL so we can do stuff like they do at the Firefox plugin directory (see
https://addons.mozilla.org/extensions/moreinfo.php?id=220&application=firefo... and note the 'more previews' link below the screenshot).
Would you be able to work on this some more, so we can implement this properly? I'd be happy to help test/review such functionality and roll it out on drupal.org.
Dries
Previous comments: ------------------------------------------------------------------------
Wed, 15 Feb 2006 21:09:41 +0000 : der
Per the related discussion [1] on the infrastructure mailing list, there needs to be a way to embed an image in the description of a project. This is particularly useful for showing theme screenshots. [1] http://lists.drupal.org/archives/infrastructure/2006-02/msg00154.html
------------------------------------------------------------------------
Sat, 04 Mar 2006 05:35:47 +0000 : der
Attachment: http://drupal.org/files/issues/project.module_1.patch (1.69KB)
Here's a patch that uses the existing screenshots db field for the img tag source.
------------------------------------------------------------------------
Mon, 06 Mar 2006 15:09:14 +0000 : der
Just a comment on this patch. The intent of this feature request was to allow screenshot images to be displayed for "theme" projects. But the patch doesn't limit it to any particular project type. My assumption is that it could be controlled in the stylesheet.
participants (1)
-
David Reed