Issue status update for http://drupal.org/node/27846 Post a follow up: http://drupal.org/project/comments/add/27846 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: kubaZygmunt Updated by: Dries Status: patch variable_get is part of bootstrap.inc and therefore, it always exists. The test is probably redundant. Please test and resubmit. Thanks kuba. Dries Previous comments: ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:03:03 +0000 : kubaZygmunt Attachment: http://drupal.org/files/issues/database.mysql.inc_0.patch (657 bytes) Another simple patch which removes error: Notice: Undefined index: dev_query in ***\includes\database.mysql.inc on line 80

Issue status update for http://drupal.org/node/27846 Post a follow up: http://drupal.org/project/comments/add/27846 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: critical Assigned to: chx Reported by: kubaZygmunt Updated by: chx -Status: patch (code needs review) +Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/database_inc_0.patch (2.27 KB) Stupid, stupid me! I forgot that we merged init.inc with bootstrap.inc chx Previous comments: ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:03:03 +0000 : kubaZygmunt Attachment: http://drupal.org/files/issues/database.mysql.inc_0.patch (657 bytes) Another simple patch which removes error: Notice: Undefined index: dev_query in ***\includes\database.mysql.inc on line 80 ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:59:51 +0000 : Dries variable_get is part of bootstrap.inc and therefore, it always exists. The test is probably redundant. Please test and resubmit. Thanks kuba. ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:36:29 +0000 : chx I always forget to post this patch. This line was part of the bootstrap patch, so this is my work -- I do not know what got in me when I mistyped which function exists. Why this line is necessary? Because after the bootstrap patch you can not be sure that bootstrap.inc is there when you are running a db_query. Also there is a need to check for $GLOBALS['conf']['dev_query']. I'll post immediately. ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:49:29 +0000 : chx Attachment: http://drupal.org/files/issues/database_inc.patch (2.35 KB) I came up with this easier to read, simpler code. I even -gasp- commented it.

Issue status update for http://drupal.org/node/27846 Post a follow up: http://drupal.org/project/comments/add/27846 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: critical Assigned to: chx Reported by: kubaZygmunt Updated by: chx Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/database_inc_2.patch (2.26 KB) how many stupid errors can one make? well, tomorrow I am thirty, I am surely will be much wiser :) chx Previous comments: ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:03:03 +0000 : kubaZygmunt Attachment: http://drupal.org/files/issues/database.mysql.inc_0.patch (657 bytes) Another simple patch which removes error: Notice: Undefined index: dev_query in ***\includes\database.mysql.inc on line 80 ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:59:51 +0000 : Dries variable_get is part of bootstrap.inc and therefore, it always exists. The test is probably redundant. Please test and resubmit. Thanks kuba. ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:36:29 +0000 : chx I always forget to post this patch. This line was part of the bootstrap patch, so this is my work -- I do not know what got in me when I mistyped which function exists. Why this line is necessary? Because after the bootstrap patch you can not be sure that bootstrap.inc is there when you are running a db_query. Also there is a need to check for $GLOBALS['conf']['dev_query']. I'll post immediately. ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:49:29 +0000 : chx Attachment: http://drupal.org/files/issues/database_inc.patch (2.35 KB) I came up with this easier to read, simpler code. I even -gasp- commented it. ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:56:08 +0000 : chx Attachment: http://drupal.org/files/issues/database_inc_0.patch (2.27 KB) Stupid, stupid me! I forgot that we merged init.inc with bootstrap.inc ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:58:54 +0000 : chx Attachment: http://drupal.org/files/issues/database_inc_1.patch (2.26 KB)