critical project module issues: duplicate calls to menu items, and $_POST variables unset
Updating drupal.org to CVS HEAD is being held up in part by two critical bugs in the project module: http://drupal.org/node/50337 version select broken when browsing projects http://drupal.org/node/50786 comment issues broken Both of these bugs cropped up recently after things were working fine, and they seem to reflect the same underlying problem. The menu item functions implementing these functionalities (project_page_overview() and project_comment_page(), respectively) are called twice in the course of the page handling, when presumably they should be called only once. The first time they're called they have access to $_POST variables, but the second time they don't, and so, seemingly, fail for lack of data. Is anyone aware of a recent change to core that might be producing these double calls? Or changes in the handling of $_POST variables so that they are unset? Any ideas would be very welcome!
Is anyone aware of a recent change to core that might be producing these double calls? Or changes in the handling of $_POST variables so that they are unset?
Any ideas would be very welcome!
Off-hand, the only thing I can think about is http://drupal.org/node/51189 (Change default submit redirect to $_GET['q']) -- this was in response to another patch a bit earlier that did something or other like get rid of the default drupal_goto at the end of form submission so this could be overridden by modules. (sorry can't find nid right now) If project module hasn't been updated to handle that, it's possible that it's redirecting back to itself and then running again? I'd have to install it and take a look though, which I won't be able to do tonight, sorry. ;( -Angie
On 3/3/06, Nedjo Rogers <nedjo@islandnet.com> wrote:
Updating drupal.org to CVS HEAD is being held up in part by two critical bugs in the project module:
http://drupal.org/node/50337 version select broken when browsing projects http://drupal.org/node/50786 comment issues broken
I fixed both (and some more) in CVS HEAD. -- Dries Buytaert :: http://buytaert.net/
participants (3)
-
Angie Byron -
Dries Buytaert -
Nedjo Rogers