[drupal-devel] [bug] Prefix UPDATE statements in prefix.sh
Issue status update for http://drupal.org/node/24749 Project: Drupal Version: cvs Component: other Category: bug reports Priority: minor Assigned to: Anonymous Reported by: Axel Updated by: Axel Status: patch Attachment: http://drupal.org/files/issues/prefix-update.patch (297 bytes) The patch adds prefixing for UPDATE SQL statements in prefix.sh. Axel
Issue status update for http://drupal.org/node/24749 Project: Drupal Version: cvs Component: other Category: bug reports Priority: minor Assigned to: Anonymous Reported by: Axel Updated by: Axel Status: patch Attachment: http://drupal.org/files/issues/prefix-update_0.patch (358 bytes) Sorry, previous patch broken (space was skiped). Next patch works ok. Also prefixing for DROP TABLE IF EXISTS statement added. Axel Previous comments: ------------------------------------------------------------------------ June 10, 2005 - 18:54 : Axel Attachment: http://drupal.org/files/issues/prefix-update.patch (297 bytes) The patch adds prefixing for UPDATE SQL statements in prefix.sh.
Issue status update for http://drupal.org/node/24749 Post a follow up: http://drupal.org/project/comments/add/24749 Project: Drupal Version: cvs Component: other -Category: bug reports +Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Axel Updated by: killes@www.drop.org -Status: patch (code needs review) +Status: patch (ready to be committed) I've tested the patch and can say it works. Don't know if we need this feature, as neither statement is used by Drupal core. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ Fri, 10 Jun 2005 15:54:34 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update.patch (297 bytes) The patch adds prefixing for UPDATE SQL statements in prefix.sh. ------------------------------------------------------------------------ Fri, 10 Jun 2005 16:13:28 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update_0.patch (358 bytes) Sorry, previous patch broken (space was skiped). Next patch works ok. Also prefixing for DROP TABLE IF EXISTS statement added.
Issue status update for http://drupal.org/node/24749 Post a follow up: http://drupal.org/project/comments/add/24749 Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Axel Updated by: Bèr Kessels Status: patch (ready to be committed) I would say: go for it. It works, and I already once had to hand-edit all my custom modules because this thing was not in the prefix.sh This works as expected, and makes prefixing contributed sql files easier. Bèr Kessels Previous comments: ------------------------------------------------------------------------ Fri, 10 Jun 2005 15:54:34 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update.patch (297 bytes) The patch adds prefixing for UPDATE SQL statements in prefix.sh. ------------------------------------------------------------------------ Fri, 10 Jun 2005 16:13:28 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update_0.patch (358 bytes) Sorry, previous patch broken (space was skiped). Next patch works ok. Also prefixing for DROP TABLE IF EXISTS statement added. ------------------------------------------------------------------------ Mon, 01 Aug 2005 00:27:18 +0000 : killes@www.drop.org I've tested the patch and can say it works. Don't know if we need this feature, as neither statement is used by Drupal core.
Issue status update for http://drupal.org/node/24749 Post a follow up: http://drupal.org/project/comments/add/24749 Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Axel Updated by: Cvbge -Status: patch (ready to be committed) +Status: patch (code needs work) DROP TABLE IF EXISTS does not work with postgresql (it does not support IF EXISTS statement) Cvbge Previous comments: ------------------------------------------------------------------------ Fri, 10 Jun 2005 15:54:34 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update.patch (297 bytes) The patch adds prefixing for UPDATE SQL statements in prefix.sh. ------------------------------------------------------------------------ Fri, 10 Jun 2005 16:13:28 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update_0.patch (358 bytes) Sorry, previous patch broken (space was skiped). Next patch works ok. Also prefixing for DROP TABLE IF EXISTS statement added. ------------------------------------------------------------------------ Mon, 01 Aug 2005 00:27:18 +0000 : killes@www.drop.org I've tested the patch and can say it works. Don't know if we need this feature, as neither statement is used by Drupal core. ------------------------------------------------------------------------ Mon, 08 Aug 2005 10:40:00 +0000 : Bèr Kessels I would say: go for it. It works, and I already once had to hand-edit all my custom modules because this thing was not in the prefix.sh This works as expected, and makes prefixing contributed sql files easier.
Issue status update for http://drupal.org/node/24749 Post a follow up: http://drupal.org/project/comments/add/24749 Project: Drupal Version: cvs Component: other Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Axel Updated by: Axel -Status: patch (code needs work) +Status: patch (code needs review) Patch don't touch DROP TABLE IF EXISTS, it's already presents in the script. Anyway prefix.sh don't change any statements in SQL, just prefix tables. If IF EXISTS presented in SQL for Postgres then it is SQL-script problem, not prefix.sh. Axel Previous comments: ------------------------------------------------------------------------ Fri, 10 Jun 2005 15:54:34 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update.patch (297 bytes) The patch adds prefixing for UPDATE SQL statements in prefix.sh. ------------------------------------------------------------------------ Fri, 10 Jun 2005 16:13:28 +0000 : Axel Attachment: http://drupal.org/files/issues/prefix-update_0.patch (358 bytes) Sorry, previous patch broken (space was skiped). Next patch works ok. Also prefixing for DROP TABLE IF EXISTS statement added. ------------------------------------------------------------------------ Mon, 01 Aug 2005 00:27:18 +0000 : killes@www.drop.org I've tested the patch and can say it works. Don't know if we need this feature, as neither statement is used by Drupal core. ------------------------------------------------------------------------ Mon, 08 Aug 2005 10:40:00 +0000 : Bèr Kessels I would say: go for it. It works, and I already once had to hand-edit all my custom modules because this thing was not in the prefix.sh This works as expected, and makes prefixing contributed sql files easier. ------------------------------------------------------------------------ Mon, 08 Aug 2005 11:27:40 +0000 : Cvbge DROP TABLE IF EXISTS does not work with postgresql (it does not support IF EXISTS statement)
participants (4)
-
Axel -
Bèr Kessels -
Cvbge -
killes