[drupal-devel] [task] Remove a useless form_group()
Issue status update for http://drupal.org/node/27647 Post a follow up: http://drupal.org/project/comments/add/27647 Project: Drupal Version: cvs Component: throttle.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/throttle.module.diff (4.51 KB) The entire throttle settings page is enclosed in a single form_group(). That shouldn't happen since the title of the group and the border aren't doing anything to help scanability of the page. drumm
Issue status update for http://drupal.org/node/27647 Post a follow up: http://drupal.org/project/comments/add/27647 Project: Drupal Version: cvs Component: throttle.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: Dries Status: patch Slightly related, slightly off-topic but how about we move "simple settings" that are on a sub-page to the main settings page at admin/settings? Right now, some settings are on the main settings page while others are on sub-pages. It's pretty random. (Moving the settings would require them to have a form_group(), hence this comment.) Dries Previous comments: ------------------------------------------------------------------------ Thu, 28 Jul 2005 01:26:54 +0000 : drumm Attachment: http://drupal.org/files/issues/throttle.module.diff (4.51 KB) The entire throttle settings page is enclosed in a single form_group(). That shouldn't happen since the title of the group and the border aren't doing anything to help scanability of the page.
On Fri, Jul 29, 2005 at 09:05:22AM +0200, Dries wrote:
Slightly related, slightly off-topic but how about we move "simple settings" that are on a sub-page to the main settings page at admin/settings? Right now, some settings are on the main settings page while others are on sub-pages. It's pretty random. (Moving the settings would require them to have a form_group(), hence this comment.)
I do not think this is a good idea since there is a separation now. Each setting page corresponds with a module and each form group on the main settings page corresponds with something in Drupal core. I think there are currently inconsistencies in this system and other systems should be considered, mocked up, and patched in. I think for now removing what distinction there is would be a bad idea. -Neil
Issue status update for http://drupal.org/node/27647 Post a follow up: http://drupal.org/project/comments/add/27647 Project: Drupal Version: cvs Component: throttle.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Uhh.. can we start another thread for that? drumm Previous comments: ------------------------------------------------------------------------ Thu, 28 Jul 2005 01:26:54 +0000 : drumm Attachment: http://drupal.org/files/issues/throttle.module.diff (4.51 KB) The entire throttle settings page is enclosed in a single form_group(). That shouldn't happen since the title of the group and the border aren't doing anything to help scanability of the page. ------------------------------------------------------------------------ Fri, 29 Jul 2005 07:05:21 +0000 : Dries Slightly related, slightly off-topic but how about we move "simple settings" that are on a sub-page to the main settings page at admin/settings? Right now, some settings are on the main settings page while others are on sub-pages. It's pretty random. (Moving the settings would require them to have a form_group(), hence this comment.)
participants (3)
-
Dries -
drumm
-
neil＠civicspacelabs.org