Issue status update for http://drupal.org/node/16282 Post a follow up: http://drupal.org/project/comments/add/16282 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Robin Monks Reported by: arnabdotorg Updated by: Uwe Hermann -Status: active +Status: patch (code needs review) I have rerolled the patch, it applies more cleanly to HEAD now. Also, I fixed a bug (I think), $feed['TITLE'] should have been $feed['TEXT'], right? The patch as is works for me. Please lets try to get this into 4.7. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Thu, 27 Jan 2005 06:13:35 +0000 : arnabdotorg Attachment: http://drupal.org/files/issues/import_opml.patch (3.96 KB) The aggregator supports OPML export for all feeds, but not import. This patch enables import of OPML lists, allowing people to import lists of RSS feeds they've already assembled in another RSS app. Demo: http://arnab.drupaldevs.org/aggregator Patch: http://arnab.drupaldevs.org/tmp/import_opml.patch ------------------------------------------------------------------------ Thu, 27 Jan 2005 21:22:23 +0000 : Dries 1. This patch does not conform Drupal's coding style at all. 2. The error handling of aggregator_import() is bare bones (not helpful). 3. Use drupal_xml_parser_create() instead of xml_parser_create(). 4. Drop the "sorry"'s. 5. form_set_error() is used incorrectly. Please refine and resubmit. ------------------------------------------------------------------------ Fri, 06 May 2005 19:40:36 +0000 : Matt_T_hat No doubt I've just irritated some one but after spending the day finding out how to run diff/patch on win32 and getting that done - guess what! That's right the form for OPML is tantalisingly there and yet it is beyond me to get it to anything (like submit). The browse button gets the page to hang for a few moments but that is all. ------------------------------------------------------------------------ Wed, 11 May 2005 19:05:41 +0000 : robertDouglass Would be nice if someone could revive this code. ------------------------------------------------------------------------ Wed, 11 May 2005 22:16:32 +0000 : Matt_T_hat A-Ha! I got it to work. The OPML list must have been downloaded and can then be uploaded (via browse) and then it will work. Very well. ------------------------------------------------------------------------ Wed, 25 May 2005 10:04:52 +0000 : arnabdotorg Too lazy|busy to handle this, it would be nice to see this come through. ------------------------------------------------------------------------ Thu, 26 May 2005 11:47:13 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/OPML.import.patch (3.25 KB) I'm cleaning this up now, here is what I've got so far: - Now Uses drupal_xml_phraser_create - Applies Aganist HEAD - Some Sorry's removed. To be done: - Conform to coding style - Don't give error on existing entry - Fix form error code Robin ------------------------------------------------------------------------ Wed, 08 Jun 2005 23:02:49 +0000 : Robin Monks I haven't given up, it's just taking a while. Robin

Issue status update for http://drupal.org/node/16282 Post a follow up: http://drupal.org/project/comments/add/16282 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal -Assigned to: Robin Monks +Assigned to: Anonymous Reported by: arnabdotorg Updated by: Robin Monks Status: patch (code needs review) Please make sure this patch checks that the site is not already listed in the . Also, please reassign this patch to yourself. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ Thu, 27 Jan 2005 06:13:35 +0000 : arnabdotorg Attachment: http://drupal.org/files/issues/import_opml.patch (3.96 KB) The aggregator supports OPML export for all feeds, but not import. This patch enables import of OPML lists, allowing people to import lists of RSS feeds they've already assembled in another RSS app. Demo: http://arnab.drupaldevs.org/aggregator Patch: http://arnab.drupaldevs.org/tmp/import_opml.patch ------------------------------------------------------------------------ Thu, 27 Jan 2005 21:22:23 +0000 : Dries 1. This patch does not conform Drupal's coding style at all. 2. The error handling of aggregator_import() is bare bones (not helpful). 3. Use drupal_xml_parser_create() instead of xml_parser_create(). 4. Drop the "sorry"'s. 5. form_set_error() is used incorrectly. Please refine and resubmit. ------------------------------------------------------------------------ Fri, 06 May 2005 19:40:36 +0000 : Matt_T_hat No doubt I've just irritated some one but after spending the day finding out how to run diff/patch on win32 and getting that done - guess what! That's right the form for OPML is tantalisingly there and yet it is beyond me to get it to anything (like submit). The browse button gets the page to hang for a few moments but that is all. ------------------------------------------------------------------------ Wed, 11 May 2005 19:05:41 +0000 : robertDouglass Would be nice if someone could revive this code. ------------------------------------------------------------------------ Wed, 11 May 2005 22:16:32 +0000 : Matt_T_hat A-Ha! I got it to work. The OPML list must have been downloaded and can then be uploaded (via browse) and then it will work. Very well. ------------------------------------------------------------------------ Wed, 25 May 2005 10:04:52 +0000 : arnabdotorg Too lazy|busy to handle this, it would be nice to see this come through. ------------------------------------------------------------------------ Thu, 26 May 2005 11:47:13 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/OPML.import.patch (3.25 KB) I'm cleaning this up now, here is what I've got so far: - Now Uses drupal_xml_phraser_create - Applies Aganist HEAD - Some Sorry's removed. To be done: - Conform to coding style - Don't give error on existing entry - Fix form error code Robin ------------------------------------------------------------------------ Wed, 08 Jun 2005 23:02:49 +0000 : Robin Monks I haven't given up, it's just taking a while. Robin ------------------------------------------------------------------------ Sat, 20 Aug 2005 02:27:59 +0000 : Uwe Hermann I have rerolled the patch, it applies more cleanly to HEAD now. Also, I fixed a bug (I think), $feed['TITLE'] should have been $feed['TEXT'], right? The patch as is works for me. Please lets try to get this into 4.7. ------------------------------------------------------------------------ Sat, 20 Aug 2005 02:28:36 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/OPML.import_0.patch (3.35 KB) Forgot the patch.

Issue status update for http://drupal.org/node/16282 Post a follow up: http://drupal.org/project/comments/add/16282 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Uwe Hermann Reported by: arnabdotorg Updated by: Prometheus6 Status: patch (code needs review) I think he's talking about this: + //Adding '@' to bypass the problem of duplicate INSERTS + @aggregator_save_feed($edit); Prometheus6 Previous comments: ------------------------------------------------------------------------ Thu, 27 Jan 2005 06:13:35 +0000 : arnabdotorg Attachment: http://drupal.org/files/issues/import_opml.patch (3.96 KB) The aggregator supports OPML export for all feeds, but not import. This patch enables import of OPML lists, allowing people to import lists of RSS feeds they've already assembled in another RSS app. Demo: http://arnab.drupaldevs.org/aggregator Patch: http://arnab.drupaldevs.org/tmp/import_opml.patch ------------------------------------------------------------------------ Thu, 27 Jan 2005 21:22:23 +0000 : Dries 1. This patch does not conform Drupal's coding style at all. 2. The error handling of aggregator_import() is bare bones (not helpful). 3. Use drupal_xml_parser_create() instead of xml_parser_create(). 4. Drop the "sorry"'s. 5. form_set_error() is used incorrectly. Please refine and resubmit. ------------------------------------------------------------------------ Fri, 06 May 2005 19:40:36 +0000 : Matt_T_hat No doubt I've just irritated some one but after spending the day finding out how to run diff/patch on win32 and getting that done - guess what! That's right the form for OPML is tantalisingly there and yet it is beyond me to get it to anything (like submit). The browse button gets the page to hang for a few moments but that is all. ------------------------------------------------------------------------ Wed, 11 May 2005 19:05:41 +0000 : robertDouglass Would be nice if someone could revive this code. ------------------------------------------------------------------------ Wed, 11 May 2005 22:16:32 +0000 : Matt_T_hat A-Ha! I got it to work. The OPML list must have been downloaded and can then be uploaded (via browse) and then it will work. Very well. ------------------------------------------------------------------------ Wed, 25 May 2005 10:04:52 +0000 : arnabdotorg Too lazy|busy to handle this, it would be nice to see this come through. ------------------------------------------------------------------------ Thu, 26 May 2005 11:47:13 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/OPML.import.patch (3.25 KB) I'm cleaning this up now, here is what I've got so far: - Now Uses drupal_xml_phraser_create - Applies Aganist HEAD - Some Sorry's removed. To be done: - Conform to coding style - Don't give error on existing entry - Fix form error code Robin ------------------------------------------------------------------------ Wed, 08 Jun 2005 23:02:49 +0000 : Robin Monks I haven't given up, it's just taking a while. Robin ------------------------------------------------------------------------ Sat, 20 Aug 2005 02:27:59 +0000 : Uwe Hermann I have rerolled the patch, it applies more cleanly to HEAD now. Also, I fixed a bug (I think), $feed['TITLE'] should have been $feed['TEXT'], right? The patch as is works for me. Please lets try to get this into 4.7. ------------------------------------------------------------------------ Sat, 20 Aug 2005 02:28:36 +0000 : Uwe Hermann Attachment: http://drupal.org/files/issues/OPML.import_0.patch (3.35 KB) Forgot the patch. ------------------------------------------------------------------------ Mon, 22 Aug 2005 22:45:45 +0000 : Robin Monks Please make sure this patch checks that the site is not already listed in the . Also, please reassign this patch to yourself. Robin ------------------------------------------------------------------------ Tue, 23 Aug 2005 21:45:57 +0000 : Uwe Hermann "not listed in the ......"? What is missing?