[drupal-devel] Requesting code review on HTTP auth module
Greetings, I've been working on a module to replace Drupal's login form with HTTP auth. Since this has to do with authentication, I'd appreciate some code (and logic) review. The module is in http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/junyor/http_auth/. Thanks! -- Tim Altman
How is this different from: http://drupal.org/project/webserver_auth ? On Apr 28, 2005, at 11:06 AM, Tim Altman wrote:
I've been working on a module to replace Drupal's login form with HTTP auth. Since this has to do with authentication, I'd appreciate some code (and logic) review. The module is in http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/junyor/ http_auth/. Thanks!
Allie Micka pajunas interactive, inc. http://www.pajunas.com/ scalable web hosting and open source solutions
On Thu, 28 Apr 2005 18:33:41 +0200, Allie Micka <allie@pajunas.com> wrote:
How is this different from: http://drupal.org/project/webserver_auth ?
That module relies on the server to provide the HTTP auth (through .htaccess). My module users the HTTP auth support built into PHP. -- Tim Altman
On 28-Apr-05, at 9:35 AM, Tim Altman wrote:
On Thu, 28 Apr 2005 18:33:41 +0200, Allie Micka <allie@pajunas.com> wrote:
How is this different from: http://drupal.org/project/webserver_auth ?
That module relies on the server to provide the HTTP auth (through .htaccess). My module users the HTTP auth support built into PHP.
(I'm missing the beginning of this thread because of some DNS issues.) I'm announcing securesite.module (http://www.drupal.org/project/securesite) today, which, um, does the same thing :( Maybe look at it and see if any changes can be merged? It works great: we're pulling down RSS feeds from a site with private organic group content and using Basic Auth to get access. Thanks to Karoly (chx) for putting this together. -- Boris Mann http://www.bryght.com Vancouver 778-896-2747 / San Francisco 415-367-3595 SKYPE borismann
On Thu, 28 Apr 2005 18:48:09 +0200, Boris Mann <boris@bryght.com> wrote:
On 28-Apr-05, at 9:35 AM, Tim Altman wrote:
On Thu, 28 Apr 2005 18:33:41 +0200, Allie Micka <allie@pajunas.com> wrote:
How is this different from: http://drupal.org/project/webserver_auth ?
That module relies on the server to provide the HTTP auth (through .htaccess). My module users the HTTP auth support built into PHP.
[...]
I'm announcing securesite.module (http://www.drupal.org/project/securesite) today, which, um, does the same thing :(
...only better. ;)
Maybe look at it and see if any changes can be merged? It works great: we're pulling down RSS feeds from a site with private organic group content and using Basic Auth to get access.
Will do. -- Tim Altman
On Thu, 28 Apr 2005 18:06:08 +0200, Tim Altman <web@timaltman.com> wrote:
Greetings,
I've been working on a module to replace Drupal's login form with HTTP auth. Since this has to do with authentication, I'd appreciate some code (and logic) review. The module is in http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/junyor/http_auth/. Thanks!
NK clued me in that his securesite.module is much better than this, so don't worry about any more reviews. Thanks! -- Tim Altman
participants (3)
-
Allie Micka -
Boris Mann -
Tim Altman