[drupal-devel] module and theme names
Fellow developers, for the second time in three months I named my module the same as the theme. Do not do this. :) Should we put a safety belt somewhere in system to protect stupid developers like me from the effects? (like theme_comment going to an awfully wrong place...) Regards NK
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08 Nov 2005, at 3:45 AM, Karoly Negyesi wrote:
Fellow developers,
for the second time in three months I named my module the same as the theme. Do not do this. :)
Which is why i would prefer if we did away with themename_something and just moved to template_something, and possibly even engine_something. All themes (.theme files even) would become inherently copy-able. The only thing we lose is not being able to load more than one at a time. I think we can do this, but we need to introduce meta-data first. (ie: a 'config' file where you specify things like 'features' and 'regions', or in the case of template engines, a regex to use for finding templates) - -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) iD8DBQFDcD/ogegMqdGlkasRAsQ4AJ9hGhVciADvbpdM1gdIWpCQUlvl4gCgyhOp 33Uha/HnFDAVL9ad1Hw5GXM= =YjxX -----END PGP SIGNATURE-----
Adrian Rossouw wrote:
Which is why i would prefer if we did away with themename_something and just moved to template_something, and possibly even engine_something.
All themes (.theme files even) would become inherently copy-able. The only thing we lose is not being able to load more than one at a time. I think we can do this, but we need to introduce meta-data first.
If I understand the above correctly, using template_something or engine_something would prevent a site from having more than one theme enabled. Is that correct? I'm not really sure I've got it right. Assuming that is true, then this would be a problem for some of my sites, and I would guess it would likewise be a problem for other sites, as well. I often use a theme that looks really nice at the user level, but which breaks horribly in the admin pages. I then also enable blue marine for the site admin, so that they can view the admin pages in a sane fashion. I realize this is a hack of sorts to get around themes which don't handle admin correctly, but there are more themes like this than there are not. If I'm all wrong, feel free to ignore this message. :-) ..chrisxj
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08 Nov 2005, at 8:01 PM, Chris Johnson wrote:
Adrian Rossouw wrote:
Which is why i would prefer if we did away with themename_something and just moved to template_something, and possibly even engine_something. All themes (.theme files even) would become inherently copy-able. The only thing we lose is not being able to load more than one at a time. I think we can do this, but we need to introduce meta-data first.
If I understand the above correctly, using template_something or engine_something would prevent a site from having more than one theme enabled. Is that correct? I'm not really sure I've got it right. No, it would stop you from having more than one theme loaded at the same time, which is different to having more than one theme enabled.
Ie: you don't have the templates / theme functions for both your admin theme and your normal theme loaded all the time, you only load the one you are using. The only time multiple themes are actually being loaded, is because of the _features hook and the _regions hook, which i think should both be handled by external config files. - -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (Darwin) iD8DBQFDcPbjgegMqdGlkasRAthHAJ42AE8/YQL0UNN2R+L1UaVFfYWWUQCgoWTo Zrz53H8crwzJAilVE8iXTEU= =LJ/P -----END PGP SIGNATURE-----
On Tuesday 08 November 2005 09:45 am, Karoly Negyesi wrote:
for the second time in three months I named my module the same as the theme. Do not do this. :)
Different, but closely related: http://drupal.org/node/36326#comment-53175 i.e. naming path aliases the same as hard coded (hook_menu) path aliases... B. -- http://www.wechange.org/ Because we and the world need to change. http://www.reuniting.info/ Intimate Relationships, peace and harmony in the couple. http://www.gnosis-usa.com/ Revolutionary Psychology, White Tantrism, Dream Yoga... http://www.masquilier.org/ Condorcet, Approval alternative, better voting methods.
participants (4)
-
Adrian Rossouw -
Anguo -
Chris Johnson -
Karoly Negyesi