Hi all. I've been using D7 to get familiar with it, testing / writing patches, and to begin porting my contrib module. It is awesome, but the one thing that sticks out to me is the inclusion of Overlay in core. Why are we including Overlay enabled by default in core? What functional purpose does it serve beyond eye-candy? I realize that it potentially allows you to remain on your current front-end page while doing some admin tasks, but isn't that why tabbed browsing was invented? This breaks anyways when you get redirected with a drupal_goto() somewhere. My biggest complaint is that It slows down the admin work of the site considerably, at least in my workflow. I don't mean to take away from the work that was put into overlay - some very talented people have put a lot of time and effort into building it, polishing it, and fixing some oddball performance issues. But it just doesn't seem to stick with the core philosophy. At least this module should be disabled by default in core. Brian
Hi Brian, You may wish to check out this issue: http://drupal.org/node/659488 . Needs review :). Ezra Ezra Barnett Gildesgame | http://growingventuresolutions.com | http://ezra-g.com On Tue, Jan 5, 2010 at 10:14 AM, Brian Vuyk <brian@brianvuyk.com> wrote:
Hi all.
I've been using D7 to get familiar with it, testing / writing patches, and to begin porting my contrib module. It is awesome, but the one thing that sticks out to me is the inclusion of Overlay in core.
Why are we including Overlay enabled by default in core? What functional purpose does it serve beyond eye-candy? I realize that it potentially allows you to remain on your current front-end page while doing some admin tasks, but isn't that why tabbed browsing was invented? This breaks anyways when you get redirected with a drupal_goto() somewhere.
My biggest complaint is that It slows down the admin work of the site considerably, at least in my workflow.
I don't mean to take away from the work that was put into overlay - some very talented people have put a lot of time and effort into building it, polishing it, and fixing some oddball performance issues. But it just doesn't seem to stick with the core philosophy.
At least this module should be disabled by default in core.
Brian
Hi Brian, Have you tried opening admin links in new tabs and it did not work as it did before? As far as I know the implementation, it should work as before (open the given admin page in the Seven theme without an overlay). So I think it is in no way against your preferred use of tabbed browsing. (Ezra already pointed to http://drupal.org/node/659488 to follow up with some commentary :) Gábor On Tue, Jan 5, 2010 at 4:14 PM, Brian Vuyk <brian@brianvuyk.com> wrote:
Hi all.
I've been using D7 to get familiar with it, testing / writing patches, and to begin porting my contrib module. It is awesome, but the one thing that sticks out to me is the inclusion of Overlay in core.
Why are we including Overlay enabled by default in core? What functional purpose does it serve beyond eye-candy? I realize that it potentially allows you to remain on your current front-end page while doing some admin tasks, but isn't that why tabbed browsing was invented? This breaks anyways when you get redirected with a drupal_goto() somewhere.
My biggest complaint is that It slows down the admin work of the site considerably, at least in my workflow.
I don't mean to take away from the work that was put into overlay - some very talented people have put a lot of time and effort into building it, polishing it, and fixing some oddball performance issues. But it just doesn't seem to stick with the core philosophy.
At least this module should be disabled by default in core.
Brian
Have you tried opening admin links in new tabs and it did not work as it did before?
Of course it works. But they open in the overlay again, which presents me with a smaller working area, and really nothing added except a shiny-looking AJAX / JS annoyance. If people are doing opening Overlay in tabs anyways, what is the point of having Overlay at all? Anyways, I will follow up in the issue Ezra posted. Brian On 10-01-05 10:22 AM, Gábor Hojtsy wrote:
Hi Brian,
Have you tried opening admin links in new tabs and it did not work as it did before? As far as I know the implementation, it should work as before (open the given admin page in the Seven theme without an overlay). So I think it is in no way against your preferred use of tabbed browsing. (Ezra already pointed to http://drupal.org/node/659488 to follow up with some commentary :)
Gábor
On Tue, Jan 5, 2010 at 4:14 PM, Brian Vuyk<brian@brianvuyk.com> wrote:
Hi all.
I've been using D7 to get familiar with it, testing / writing patches, and to begin porting my contrib module. It is awesome, but the one thing that sticks out to me is the inclusion of Overlay in core.
Why are we including Overlay enabled by default in core? What functional purpose does it serve beyond eye-candy? I realize that it potentially allows you to remain on your current front-end page while doing some admin tasks, but isn't that why tabbed browsing was invented? This breaks anyways when you get redirected with a drupal_goto() somewhere.
My biggest complaint is that It slows down the admin work of the site considerably, at least in my workflow.
I don't mean to take away from the work that was put into overlay - some very talented people have put a lot of time and effort into building it, polishing it, and fixing some oddball performance issues. But it just doesn't seem to stick with the core philosophy.
At least this module should be disabled by default in core.
Brian
On Tue, Jan 5, 2010 at 4:33 PM, Brian Vuyk <brian@brianvuyk.com> wrote:
Have you tried opening admin links in new tabs and it did not work as it did before?
Of course it works. But they open in the overlay again, which presents me with a smaller working area, and really nothing added except a shiny-looking AJAX / JS annoyance. If people are doing opening Overlay in tabs anyways, what is the point of having Overlay at all?
I'm getting you open in new tab but then open links in that tab, which will indeed use the overlay. It will not remember you did not want it to open in the overlay, because opening new tabs is not designed to sidestep the overlay but to "branch" your admin work (just as it did before). Drupal remembering that you started using the admin pages in a full browser window (by opening a new tab for example), so it will not open overlays sounds like a possibly good feature request turned out in your personal user testing. Gábor
Pretty please, let's do not *repeat* the entire discussion here. The issue already contains background information and steps to proceed. Thanks. sun
participants (4)
-
Brian Vuyk -
Daniel F. Kudwien -
Ezra B. Gildesgame -
Gábor Hojtsy