Issue status update for http://drupal.org/node/17592 Project: Drupal Version: cvs Component: other Category: bug reports Priority: normal Assigned to: killes@www.drop.org Reported by: Carl McDade Updated by: killes@www.drop.org -Status: won't fix +Status: patch My patch still applies just fine and I am not aware of any discussion. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ February 19, 2005 - 18:50 : Carl McDade Attachment: http://drupal.org/files/issues/common_11.patch (503 bytes) There should be an effort to externalize all english text into default variables. It makes a great step towards true internatiolization. Does not cost anything in terms of performance or matainance. What it does do is make the code that uses hard coded strings open and more resuable. It adds the flexibility in phrasology that is necessary in internationalizing Drupal. It creates more usability in that better text instructions can be delivered to the user based on the situation of the process. I have made this slight change in my install which allows me to give a descriptive message based on the url tried. This can be done in both english and swedish without me having to use gettext and the like. <?php --- common_1.inc    2005-02-19 17:33:21.451910400 +0100 +++ common_2.inc    2005-02-19 17:34:40.876116800 +0100 @@ -427,8 +427,8 @@ function object2array($object) {   * Always consider whether to use drupal_access_denied() instead to return a   * proper (and customizable) 403 error.   */ -function message_access() { -  return t('You are not authorized to access this page.'); +function message_access($message = 'You are not authorized to access this page.') { +  return t($message); } *Warning*: Unterminated comment starting line 13 in */home/www/drupal.org/modules/codefilter/codefilter.module* on line *28* ------------------------------------------------------------------------ February 19, 2005 - 20:47 : killes@www.drop.org Attachment: http://drupal.org/files/issues/message-access.patch (2.99 KB) The original description is a bit unclear, but the underlying concern seems to be that the error messages are not specific to the situation they occur in. I share this concern. The attached patch removes the function message_access() (which hails from 2001) and replaces the six calls to it by hopefully better chosen strings. Since I do not use blogapi.module I welcome suggestions for better phrases. Since this is actually a usability bug fix i hope this can get into 4.6. ------------------------------------------------------------------------ February 20, 2005 - 00:35 : chx Attachment: http://drupal.org/files/issues/message-access_0.patch (3.2 KB) While we are at it, we could open up drupal_access_denied so that the title can be changed per call. It costs almost nothing, breaks nothing, so why not? ------------------------------------------------------------------------ February 20, 2005 - 03:47 : Steven Can someone point out to me how this is related to i18n, at all? ------------------------------------------------------------------------ March 23, 2005 - 23:01 : Dries As discussued, this is not going to work as is.